[Qemu-devel] [PATCH 0/3] s390x/cpumodel fixes for 4.1

Christian Borntraeger posted 3 patches 4 years, 8 months ago
Test docker-clang@ubuntu passed
Test s390x passed
Test asan passed
Test docker-mingw@fedora passed
Test FreeBSD passed
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190715142304.215018-1-borntraeger@de.ibm.com
Maintainers: Christian Borntraeger <borntraeger@de.ibm.com>, Halil Pasic <pasic@linux.ibm.com>, David Hildenbrand <david@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Richard Henderson <rth@twiddle.net>
target/s390x/cpu_features_def.inc.h | 2 +-
target/s390x/gen-features.c         | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
[Qemu-devel] [PATCH 0/3] s390x/cpumodel fixes for 4.1
Posted by Christian Borntraeger 4 years, 8 months ago
Some fallout of the gen15 cpu model. As this is new in 4.1
it is still time to fixup some aspects.

Christian Borntraeger (3):
  s390x/cpumodel: remove esort from the default model
  s390x/cpumodel: also change name of vxbeh
  s390x/cpumodel: change internal name of vxp to make description

 target/s390x/cpu_features_def.inc.h | 2 +-
 target/s390x/gen-features.c         | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

-- 
2.21.0


Re: [Qemu-devel] [PATCH 0/3] s390x/cpumodel fixes for 4.1
Posted by Cornelia Huck 4 years, 8 months ago
On Mon, 15 Jul 2019 16:23:01 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> Some fallout of the gen15 cpu model. As this is new in 4.1
> it is still time to fixup some aspects.
> 
> Christian Borntraeger (3):
>   s390x/cpumodel: remove esort from the default model
>   s390x/cpumodel: also change name of vxbeh
>   s390x/cpumodel: change internal name of vxp to make description
> 
>  target/s390x/cpu_features_def.inc.h | 2 +-
>  target/s390x/gen-features.c         | 5 ++---
>  2 files changed, 3 insertions(+), 4 deletions(-)
> 

Thanks, queued to s390-fixes (with s/vxp/vxpdeh/).

Re: [Qemu-devel] [PATCH 0/3] s390x/cpumodel fixes for 4.1
Posted by no-reply@patchew.org 4 years, 8 months ago
Patchew URL: https://patchew.org/QEMU/20190715142304.215018-1-borntraeger@de.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190715142304.215018-1-borntraeger@de.ibm.com
Type: series
Subject: [Qemu-devel] [PATCH 0/3] s390x/cpumodel fixes for 4.1

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190715142304.215018-1-borntraeger@de.ibm.com -> patchew/20190715142304.215018-1-borntraeger@de.ibm.com
Switched to a new branch 'test'
7bc436d3ed s390x/cpumodel: change internal name of vxp to make description
6b0474bbb3 s390x/cpumodel: also change name of vxbeh
2a3445555a s390x/cpumodel: remove esort from the default model

=== OUTPUT BEGIN ===
1/3 Checking commit 2a3445555a55 (s390x/cpumodel: remove esort from the default model)
2/3 Checking commit 6b0474bbb3ec (s390x/cpumodel: also change name of vxbeh)
WARNING: line over 80 characters
#29: FILE: target/s390x/cpu_features_def.inc.h:107:
+DEF_FEAT(VECTOR_BCD_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")

total: 0 errors, 1 warnings, 8 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/3 Checking commit 7bc436d3eda4 (s390x/cpumodel: change internal name of vxp to make description)
ERROR: line over 90 characters
#22: FILE: target/s390x/cpu_features_def.inc.h:107:
+DEF_FEAT(VECTOR_PACKED_DECIMAL_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")

total: 1 errors, 0 warnings, 24 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190715142304.215018-1-borntraeger@de.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com