From nobody Fri May 3 08:58:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563189346; cv=none; d=zoho.com; s=zohoarc; b=RQNS7o3+ntYh17S3hwrMpRthshUJRCvW1vOj9aJPNpKmlRsar/i/kv1UwO6+4pgbcIdHNNuD4xDEFACjcvZR+rfPOeZXbyQdMHvC4snNU2nX+kl/VMFqiMztmskHV9Vkdyrsh45bs9XNDAgDpeqIYB9bcQhKndQUeouF370Z7PM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563189346; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=hwzP0iDNKUBNCZT+heXNevMffAq5KMe3cPFrKyTyqhw=; b=kKcggCgb22qYY4PVBWgoKfVoF4GAHwK5WBVAnVQYOSTQFc9MVNAZE5dVit65bYu536oZ9e/T75Ndk85r4EtmAN8Tu+fzEQFXJca9BaAMx9WPUn+BgC8zsjNIqrA2cOCnpPuX1fgrc5JmefftzUUNelOocxzOLRfN++TkyF80DtU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1563189346337426.4230233929909; Mon, 15 Jul 2019 04:15:46 -0700 (PDT) Received: from localhost ([::1]:37246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmyxJ-0005vu-Bu for importer@patchew.org; Mon, 15 Jul 2019 07:15:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47172) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmywu-0004pX-49 for qemu-devel@nongnu.org; Mon, 15 Jul 2019 07:15:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmyws-0002Th-77 for qemu-devel@nongnu.org; Mon, 15 Jul 2019 07:15:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45706) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hmywr-0002RL-Ug for qemu-devel@nongnu.org; Mon, 15 Jul 2019 07:15:14 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C8D36307D88D for ; Mon, 15 Jul 2019 11:15:11 +0000 (UTC) Received: from dgilbert-t580.localhost (ovpn-117-181.ams2.redhat.com [10.36.117.181]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0ECE71001B18; Mon, 15 Jul 2019 11:15:09 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, dinechin@redhat.com Date: Mon, 15 Jul 2019 12:15:01 +0100 Message-Id: <20190715111501.22368-2-dgilbert@redhat.com> In-Reply-To: <20190715111501.22368-1-dgilbert@redhat.com> References: <20190715111501.22368-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Mon, 15 Jul 2019 11:15:11 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 1/1] Fix build error when VNC is configured out X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Christophe de Dinechin In hmp_change(), the variable hmp_mon is only used by code under #ifdef CONFIG_VNC. This results in a build error when VNC is configured out with the default of treating warnings as errors: monitor/hmp-cmds.c: In function =E2=80=98hmp_change=E2=80=99: monitor/hmp-cmds.c:1946:17: error: unused variable =E2=80=98hmp_mon=E2=80= =99 [-Werror=3Dunused-variable] 1946 | MonitorHMP *hmp_mon =3D container_of(mon, MonitorHMP, common); | ^~~~~~~ Signed-off-by: Christophe de Dinechin Message-Id: <20190625123905.25434-1-dinechin@redhat.com> Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Dr. David Alan Gilbert --- monitor/hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 99ceb0846b..5ca3ebe942 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -1962,7 +1962,6 @@ static void hmp_change_read_arg(void *opaque, const c= har *password, =20 void hmp_change(Monitor *mon, const QDict *qdict) { - MonitorHMP *hmp_mon =3D container_of(mon, MonitorHMP, common); const char *device =3D qdict_get_str(qdict, "device"); const char *target =3D qdict_get_str(qdict, "target"); const char *arg =3D qdict_get_try_str(qdict, "arg"); @@ -1980,6 +1979,7 @@ void hmp_change(Monitor *mon, const QDict *qdict) if (strcmp(target, "passwd") =3D=3D 0 || strcmp(target, "password") =3D=3D 0) { if (!arg) { + MonitorHMP *hmp_mon =3D container_of(mon, MonitorHMP, comm= on); monitor_read_password(hmp_mon, hmp_change_read_arg, NULL); return; } --=20 2.21.0