[Qemu-devel] [PATCH v2] Remove old global variables max_cpus and smp_cpus

Stefan Weil posted 1 patch 6 days ago
Test docker-clang@ubuntu passed
Test asan passed
Test docker-mingw@fedora passed
Test FreeBSD passed
Test checkpatch passed
Test s390x passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190712134307.31112-1-sw@weilnetz.de
include/sysemu/sysemu.h | 2 --
1 file changed, 2 deletions(-)

[Qemu-devel] [PATCH v2] Remove old global variables max_cpus and smp_cpus

Posted by Stefan Weil 6 days ago
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
v2: Remove also max_cpus (merci à Laurent Vivier <laurent@vivier.eu>)

 include/sysemu/sysemu.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index 984c439ac9..e70edf7c1c 100644
--- a/include/sysemu/sysemu.h
+++ b/include/sysemu/sysemu.h
@@ -103,8 +103,6 @@ extern const char *keyboard_layout;
 extern int win2k_install_hack;
 extern int alt_grab;
 extern int ctrl_grab;
-extern int smp_cpus;
-extern unsigned int max_cpus;
 extern int cursor_hide;
 extern int graphic_rotate;
 extern int no_quit;
-- 
2.20.1


Re: [Qemu-devel] [PATCH v2] Remove old global variables max_cpus and smp_cpus

Posted by Peter Maydell 6 days ago
On Fri, 12 Jul 2019 at 14:43, Stefan Weil <sw@weilnetz.de> wrote:
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> v2: Remove also max_cpus (merci à Laurent Vivier <laurent@vivier.eu>)
>
>  include/sysemu/sysemu.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> index 984c439ac9..e70edf7c1c 100644
> --- a/include/sysemu/sysemu.h
> +++ b/include/sysemu/sysemu.h
> @@ -103,8 +103,6 @@ extern const char *keyboard_layout;
>  extern int win2k_install_hack;
>  extern int alt_grab;
>  extern int ctrl_grab;
> -extern int smp_cpus;
> -extern unsigned int max_cpus;
>  extern int cursor_hide;
>  extern int graphic_rotate;
>  extern int no_quit;

Hi -- this looks like an inadvertent duplicate of Alex's
patch from yesterday:

https://patchew.org/QEMU/20190711130546.18578-1-alex.bennee@linaro.org/

thanks
-- PMM

Re: [Qemu-devel] [PATCH v2] Remove old global variables max_cpus and smp_cpus

Posted by Laurent Vivier 6 days ago
Le 12/07/2019 à 15:43, Stefan Weil a écrit :
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> v2: Remove also max_cpus (merci à Laurent Vivier <laurent@vivier.eu>)
> 
>  include/sysemu/sysemu.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> index 984c439ac9..e70edf7c1c 100644
> --- a/include/sysemu/sysemu.h
> +++ b/include/sysemu/sysemu.h
> @@ -103,8 +103,6 @@ extern const char *keyboard_layout;
>  extern int win2k_install_hack;
>  extern int alt_grab;
>  extern int ctrl_grab;
> -extern int smp_cpus;
> -extern unsigned int max_cpus;
>  extern int cursor_hide;
>  extern int graphic_rotate;
>  extern int no_quit;
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>