[Qemu-devel] [PATCH v1 1/7] tests/docker: add test-misc for building tools & docs

Alex Bennée posted 7 patches 5 weeks ago

[Qemu-devel] [PATCH v1 1/7] tests/docker: add test-misc for building tools & docs

Posted by Alex Bennée 5 weeks ago
Add yet another test type so we cna quickly exercise the miscellaneous
build products of the build system under various docer configurations.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/docker/test-misc | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100755 tests/docker/test-misc

diff --git a/tests/docker/test-misc b/tests/docker/test-misc
new file mode 100755
index 00000000000..d480afedca7
--- /dev/null
+++ b/tests/docker/test-misc
@@ -0,0 +1,22 @@
+#!/bin/bash -e
+#
+# Build the miscellaneous components
+#
+# Copyright (c) 2019 Linaro Ltd.
+#
+# Authors:
+#  Alex Bennée <alex.bennee@linaro.org>
+#
+# This work is licensed under the terms of the GNU GPL, version 2 or later.
+# See the COPYING file in the top-level directory.
+#
+# SPDX-License-Identifier: GPL-2.0-or-later
+
+. common.rc
+
+cd "$BUILD_DIR"
+
+# build everything else but QEMU
+configure_qemu --disable-user --disable-system --enable-docs --enable-tools
+build_qemu
+install_qemu
-- 
2.20.1


Re: [Qemu-devel] [PATCH v1 1/7] tests/docker: add test-misc for building tools & docs

Posted by Philippe Mathieu-Daudé 5 weeks ago
On 7/12/19 1:18 PM, Alex Bennée wrote:
> Add yet another test type so we cna quickly exercise the miscellaneous

"cna" -> "can"

> build products of the build system under various docer configurations.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  tests/docker/test-misc | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100755 tests/docker/test-misc
> 
> diff --git a/tests/docker/test-misc b/tests/docker/test-misc
> new file mode 100755
> index 00000000000..d480afedca7
> --- /dev/null
> +++ b/tests/docker/test-misc
> @@ -0,0 +1,22 @@
> +#!/bin/bash -e
> +#
> +# Build the miscellaneous components
> +#
> +# Copyright (c) 2019 Linaro Ltd.
> +#
> +# Authors:
> +#  Alex Bennée <alex.bennee@linaro.org>
> +#
> +# This work is licensed under the terms of the GNU GPL, version 2 or later.
> +# See the COPYING file in the top-level directory.
> +#
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +
> +. common.rc
> +
> +cd "$BUILD_DIR"
> +
> +# build everything else but QEMU
> +configure_qemu --disable-user --disable-system --enable-docs --enable-tools
> +build_qemu
> +install_qemu
> 

I got:

$ make docker-test-misc@debian-win32-cross
  BUILD   debian9
  GEN
/home/phil/source/qemu/docker-src.2019-07-13-17.03.48.3829/qemu.tar
  BUILD   debian9-mxe
usage: git archive [<options>] <tree-ish> [<path>...]
   or: git archive --list
   or: git archive --remote <repo> [--exec <cmd>] [<options>] <tree-ish>
[<path>...]
   or: git archive --remote <repo> [--exec <cmd>] --list

    --format <fmt>        archive format
    --prefix <prefix>     prepend prefix to each pathname in the archive
    -o, --output <file>   write the archive to this file
    --worktree-attributes
                          read .gitattributes in working directory
    -v, --verbose         report archived files on stderr
    -0                    store only
    -1                    compress faster
    -9                    compress better

    -l, --list            list supported archive formats

    --remote <repo>       retrieve the archive from remote repository <repo>
    --exec <command>      path to the remote git-upload-archive command

failed to archive qemu
make[1]: *** [tests/docker/Makefile.include:31:
qemu/docker-src.2019-07-13-17.03.48.3829] Error 1

And remembered some script/archive patch on the list:
https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg02073.html

With it amended this works correctly, so:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [Qemu-devel] [PATCH v1 1/7] tests/docker: add test-misc for building tools & docs

Posted by Alex Bennée 5 weeks ago
Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> On 7/12/19 1:18 PM, Alex Bennée wrote:
>> Add yet another test type so we cna quickly exercise the miscellaneous
>
> "cna" -> "can"
>
>> build products of the build system under various docer configurations.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  tests/docker/test-misc | 22 ++++++++++++++++++++++
>>  1 file changed, 22 insertions(+)
>>  create mode 100755 tests/docker/test-misc
>>
>> diff --git a/tests/docker/test-misc b/tests/docker/test-misc
>> new file mode 100755
>> index 00000000000..d480afedca7
>> --- /dev/null
>> +++ b/tests/docker/test-misc
>> @@ -0,0 +1,22 @@
>> +#!/bin/bash -e
>> +#
>> +# Build the miscellaneous components
>> +#
>> +# Copyright (c) 2019 Linaro Ltd.
>> +#
>> +# Authors:
>> +#  Alex Bennée <alex.bennee@linaro.org>
>> +#
>> +# This work is licensed under the terms of the GNU GPL, version 2 or later.
>> +# See the COPYING file in the top-level directory.
>> +#
>> +# SPDX-License-Identifier: GPL-2.0-or-later
>> +
>> +. common.rc
>> +
>> +cd "$BUILD_DIR"
>> +
>> +# build everything else but QEMU
>> +configure_qemu --disable-user --disable-system --enable-docs --enable-tools
>> +build_qemu
>> +install_qemu
>>
>
> I got:
>
> $ make docker-test-misc@debian-win32-cross
>   BUILD   debian9
>   GEN
> /home/phil/source/qemu/docker-src.2019-07-13-17.03.48.3829/qemu.tar
>   BUILD   debian9-mxe
> usage: git archive [<options>] <tree-ish> [<path>...]
>    or: git archive --list
>    or: git archive --remote <repo> [--exec <cmd>] [<options>] <tree-ish>
> [<path>...]
>    or: git archive --remote <repo> [--exec <cmd>] --list
>
>     --format <fmt>        archive format
>     --prefix <prefix>     prepend prefix to each pathname in the archive
>     -o, --output <file>   write the archive to this file
>     --worktree-attributes
>                           read .gitattributes in working directory
>     -v, --verbose         report archived files on stderr
>     -0                    store only
>     -1                    compress faster
>     -9                    compress better
>
>     -l, --list            list supported archive formats
>
>     --remote <repo>       retrieve the archive from remote repository <repo>
>     --exec <command>      path to the remote git-upload-archive command
>
> failed to archive qemu
> make[1]: *** [tests/docker/Makefile.include:31:
> qemu/docker-src.2019-07-13-17.03.48.3829] Error 1

Hmm I haven't been able to get this... does it depend on having
uncommited changes in a subproject?

>
> And remembered some script/archive patch on the list:
> https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg02073.html

I'll look at snarfing that.

>
> With it amended this works correctly, so:
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>


--
Alex Bennée