From nobody Wed Apr 24 19:15:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562850573; cv=none; d=zoho.com; s=zohoarc; b=dKDwe27NTNgDjftFQjCkSq3OdrdCzt2jOP6m7c7cloICNCG7w1L3wIjiTgRmT1iK7sak6bDrXgyzjfadGRq1XRMrpHBpbiEMI1I0Auu2j3YzUgZAQ+SFhtf0XamaEW/9R1SMJElmkNI2L4+JuvJxjlEF8avc15G0x+UFMg3yAfo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562850573; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=s4f6x86fFsGRFZ2xd1HBzI3+J8zUxwzoZlX7Y5nIgkY=; b=B2b6Kjobejeih+9UBDR0aiU6QfcTX/VD3bCC8c5SG1KbB1neQcccTPc8/r0t+yXSNLLWvt2Z6O9/+BjI9x+g4r+nbClDJD+8uVnCA90qoZsVooAXuZ15E1P/4m9DKy4RbMicuyb59u8dMBvijHQjhfkVf0ryLoitGUEhhymjfm0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562850573033772.2629793797533; Thu, 11 Jul 2019 06:09:33 -0700 (PDT) Received: from localhost ([::1]:41640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlYpH-0002K3-So for importer@patchew.org; Thu, 11 Jul 2019 09:09:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35983) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlYo2-0001FA-3V for qemu-devel@nongnu.org; Thu, 11 Jul 2019 09:08:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlYo0-0006IW-RO for qemu-devel@nongnu.org; Thu, 11 Jul 2019 09:08:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47416) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hlYny-0006F9-Is; Thu, 11 Jul 2019 09:08:10 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 780363084243; Thu, 11 Jul 2019 13:08:09 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-45.brq.redhat.com [10.40.204.45]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A13C1600CD; Thu, 11 Jul 2019 13:08:01 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Date: Thu, 11 Jul 2019 15:07:59 +0200 Message-Id: <20190711130759.27720-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Thu, 11 Jul 2019 13:08:09 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH-for-4.1] hw/block/pflash_cfi02: Explicit switch fallthrough for ERASE commands X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , Stephen Checkoway , qemu-block@nongnu.org, Max Reitz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Previous to commit ddb6f2254, the DQ2 bit was incorrectly set during PROGRAM command (0xA0). The commit reordered the switch cases to only set the DQ2 bit for the ERASE commands using a fallthrough, but did not explicit the fallthrough is intentional. Mark the switch fallthrough with a comment interpretable by C preprocessors and static analysis tools. Reported-by: Coverity (CID 1403012) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell --- hw/block/pflash_cfi02.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c index 83084b9d72..f68837a449 100644 --- a/hw/block/pflash_cfi02.c +++ b/hw/block/pflash_cfi02.c @@ -367,6 +367,7 @@ static uint64_t pflash_read(void *opaque, hwaddr offset= , unsigned int width) case 0x30: /* Sector Erase */ /* Toggle bit 2 during erase, but not program. */ toggle_dq2(pfl); + /* fall through */ case 0xA0: /* Program */ /* Toggle bit 6 */ toggle_dq6(pfl); --=20 2.20.1