[Qemu-devel] [PATCH for 4.1?] includes: remove stale [smp|max]_cpus externs

Alex Bennée posted 1 patch 1 week ago
Test asan passed
Test FreeBSD passed
Test docker-clang@ubuntu passed
Test s390x passed
Test docker-mingw@fedora passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190711130546.18578-1-alex.bennee@linaro.org
include/sysemu/sysemu.h | 2 --
1 file changed, 2 deletions(-)

[Qemu-devel] [PATCH for 4.1?] includes: remove stale [smp|max]_cpus externs

Posted by Alex Bennée 1 week ago
Commit a5e0b3311 removed these in favour of querying machine
properties. Remove the extern declarations as well.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Like Xu <like.xu@linux.intel.com>
---
 include/sysemu/sysemu.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index 984c439ac9..e70edf7c1c 100644
--- a/include/sysemu/sysemu.h
+++ b/include/sysemu/sysemu.h
@@ -103,8 +103,6 @@ extern const char *keyboard_layout;
 extern int win2k_install_hack;
 extern int alt_grab;
 extern int ctrl_grab;
-extern int smp_cpus;
-extern unsigned int max_cpus;
 extern int cursor_hide;
 extern int graphic_rotate;
 extern int no_quit;
-- 
2.20.1


Re: [Qemu-devel] [PATCH for 4.1?] includes: remove stale [smp|max]_cpus externs

Posted by Like Xu 1 week ago
On 2019/7/11 21:05, Alex Bennée wrote:
> Commit a5e0b3311 removed these in favour of querying machine
> properties. Remove the extern declarations as well.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Like Xu <like.xu@linux.intel.com>

Reviewed-by: Like Xu <like.xu@linux.intel.com>

> ---
>   include/sysemu/sysemu.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> index 984c439ac9..e70edf7c1c 100644
> --- a/include/sysemu/sysemu.h
> +++ b/include/sysemu/sysemu.h
> @@ -103,8 +103,6 @@ extern const char *keyboard_layout;
>   extern int win2k_install_hack;
>   extern int alt_grab;
>   extern int ctrl_grab;
> -extern int smp_cpus;
> -extern unsigned int max_cpus;
>   extern int cursor_hide;
>   extern int graphic_rotate;
>   extern int no_quit;
> 


Re: [Qemu-devel] [PATCH for 4.1?] includes: remove stale [smp|max]_cpus externs

Posted by Richard Henderson 1 week ago
On 7/11/19 3:05 PM, Alex Bennée wrote:
> Commit a5e0b3311 removed these in favour of querying machine
> properties. Remove the extern declarations as well.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Like Xu <like.xu@linux.intel.com>
> ---
>  include/sysemu/sysemu.h | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~