From nobody Mon May 20 23:47:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562778330; cv=none; d=zoho.com; s=zohoarc; b=Fzqy7tEQ1TXw+VoueIY3ROH2eIAJdbS5Wfg/+iEf1y6k6IUlePHJSlxDxzYn0amYwo7if5ms9VXLpr98qHTa0M12lgy+HQeEvo1C5hmv2ba+r7ydQF3XSu/S4D8168whWK1XBJmwRi7Ac+qydavux0iuxN9WmAEqCcd2Kjkjcko= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562778330; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=YcYskFB9JtDpX5FbCyDxn7B+LFLORh+pRBbIwdxMOxc=; b=ClM6qFctMhn1De892+4rY81ZeSYBsMxyPZ6MqdJrI0QCSIex6aMsXNaf/tddB3QYCTXkyNVrck/WSDElsmBxrrqa6QN9dpznZMYfcpAhkrOHJ7XT4uvJZICYv07+j4cb58/ie8J119DOYlgMrH9G/okptHi6SnXVCZKtm0SMl7A= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562778330634512.0435083673013; Wed, 10 Jul 2019 10:05:30 -0700 (PDT) Received: from localhost ([::1]:35488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlG22-0004Z4-2d for importer@patchew.org; Wed, 10 Jul 2019 13:05:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41907) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlG0d-0003yk-PM for qemu-devel@nongnu.org; Wed, 10 Jul 2019 13:04:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlG0c-0008Sd-Hl for qemu-devel@nongnu.org; Wed, 10 Jul 2019 13:03:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42952) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hlG0Z-0008PJ-Vc; Wed, 10 Jul 2019 13:03:56 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4C9493091740; Wed, 10 Jul 2019 17:03:54 +0000 (UTC) Received: from maximlenovopc.usersys.redhat.com (unknown [10.35.206.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE2B31001B12; Wed, 10 Jul 2019 17:03:50 +0000 (UTC) From: Maxim Levitsky To: qemu-devel@nongnu.org Date: Wed, 10 Jul 2019 20:03:49 +0300 Message-Id: <20190710170349.1548-1-mlevitsk@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Wed, 10 Jul 2019 17:03:54 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] LUKS: support preallocation in qemu-img X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Maxim Levitsky , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" preallocation=3Doff and preallocation=3Dmetadata both allocate luks header only, and preallocation=3Dfalloc/full is passed to underlying file, with the given image size. Note that the actual preallocated size is a bit smaller due to luks header. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=3D1534951 Signed-off-by: Maxim Levitsky --- block/crypto.c | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/block/crypto.c b/block/crypto.c index 8237424ae6..74b789d278 100644 --- a/block/crypto.c +++ b/block/crypto.c @@ -251,6 +251,7 @@ static int block_crypto_open_generic(QCryptoBlockFormat= format, static int block_crypto_co_create_generic(BlockDriverState *bs, int64_t size, QCryptoBlockCreateOptions *opts, + PreallocMode prealloc, Error **errp) { int ret; @@ -266,6 +267,13 @@ static int block_crypto_co_create_generic(BlockDriverS= tate *bs, goto cleanup; } =20 + if (prealloc !=3D PREALLOC_MODE_OFF) { + ret =3D blk_truncate(blk, size, prealloc, errp); + if (ret < 0) { + goto cleanup; + } + } + data =3D (struct BlockCryptoCreateData) { .blk =3D blk, .size =3D size, @@ -516,7 +524,7 @@ block_crypto_co_create_luks(BlockdevCreateOptions *crea= te_options, Error **errp) }; =20 ret =3D block_crypto_co_create_generic(bs, luks_opts->size, &create_op= ts, - errp); + PREALLOC_MODE_OFF, errp); if (ret < 0) { goto fail; } @@ -534,12 +542,28 @@ static int coroutine_fn block_crypto_co_create_opts_l= uks(const char *filename, QCryptoBlockCreateOptions *create_opts =3D NULL; BlockDriverState *bs =3D NULL; QDict *cryptoopts; + PreallocMode prealloc; + char *buf =3D NULL; int64_t size; int ret; + Error *local_err =3D NULL; =20 /* Parse options */ size =3D qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE, 0); =20 + buf =3D qemu_opt_get_del(opts, BLOCK_OPT_PREALLOC); + prealloc =3D qapi_enum_parse(&PreallocMode_lookup, buf, + PREALLOC_MODE_OFF, &local_err); + g_free(buf); + if (local_err) { + error_propagate(errp, local_err); + return -EINVAL; + } + + if (prealloc =3D=3D PREALLOC_MODE_METADATA) { + prealloc =3D PREALLOC_MODE_OFF; + } + cryptoopts =3D qemu_opts_to_qdict_filtered(opts, NULL, &block_crypto_create_opts_luk= s, true); @@ -565,7 +589,7 @@ static int coroutine_fn block_crypto_co_create_opts_luk= s(const char *filename, } =20 /* Create format layer */ - ret =3D block_crypto_co_create_generic(bs, size, create_opts, errp); + ret =3D block_crypto_co_create_generic(bs, size, create_opts, prealloc= , errp); if (ret < 0) { goto fail; } --=20 2.17.2