From nobody Fri May 17 14:45:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1562735448; cv=none; d=zoho.com; s=zohoarc; b=DQprtGkMYaqJO/9BGEebopKqy2lpkWp4tRiU2UVzuT9o0Aj0A4JgLMoBSorJaNFdXwwTtHE88cPPZ63DrgDs2Opzvb8i3R2Ic55bYCYlloAPekrwBduBaiHH9csIOPml9ATVXA3PGUHTQB3dVsqbFXniEischewinEBiFk2Tjos= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562735448; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Q9zY28VtkLmxzq8eHNzK3hgD/EOrOVIT+2Rzkgk26L4=; b=OipwvGk90VVhd8yx1KoFOubAx5FNdw6MwFjZfw1T8sa5IT3jaAkyB/+pxaJxQsWGAj5l0kTpQO7rQmNvRBMX5ARSGffYjefmCI0xVCg6k+7khTOmoPtG8E7/wu+Fwto2yK30ZWjyquucCqMhnMZNnxgH9hlfjPsft0rchf/FfaY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562735447970859.737778478297; Tue, 9 Jul 2019 22:10:47 -0700 (PDT) Received: from localhost ([::1]:57972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hl4sE-0003dB-98 for importer@patchew.org; Wed, 10 Jul 2019 01:10:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44275) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hl4qk-0002QM-C3 for qemu-devel@nongnu.org; Wed, 10 Jul 2019 01:09:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hl4qi-0000IQ-CL for qemu-devel@nongnu.org; Wed, 10 Jul 2019 01:09:02 -0400 Received: from mga02.intel.com ([134.134.136.20]:6071) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hl4qg-0000AM-T3 for qemu-devel@nongnu.org; Wed, 10 Jul 2019 01:09:00 -0400 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jul 2019 22:08:56 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga005.fm.intel.com with ESMTP; 09 Jul 2019 22:08:55 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,473,1557212400"; d="scan'208";a="364360409" From: Wei Yang To: qemu-devel@nongnu.org Date: Wed, 10 Jul 2019 13:08:13 +0800 Message-Id: <20190710050814.31344-2-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190710050814.31344-1-richardw.yang@linux.intel.com> References: <20190710050814.31344-1-richardw.yang@linux.intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.20 Subject: [Qemu-devel] [PATCH 1/2] migration/postcopy: reduce one operation to calculate fixup_start_addr X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wei Yang , dgilbert@redhat.com, quintela@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Use the same way for run_end to calculate run_start, which saves one operation. Signed-off-by: Wei Yang Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 410e0f89fe..c4dc36e525 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -2884,10 +2884,12 @@ static void postcopy_chunk_hostpages_pass(Migration= State *ms, bool unsent_pass, host_offset =3D run_start % host_ratio; if (host_offset) { do_fixup =3D true; - run_start -=3D host_offset; - fixup_start_addr =3D run_start; - /* For the next pass */ - run_start =3D run_start + host_ratio; + fixup_start_addr =3D run_start - host_offset; + /* + * This host page has gone, the next loop iteration starts + * from after the fixup + */ + run_start =3D fixup_start_addr + host_ratio; } else { /* Find the end of this run */ unsigned long run_end; --=20 2.17.1 From nobody Fri May 17 14:45:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1562735449; cv=none; d=zoho.com; s=zohoarc; b=A4dqTrqiEk+/Ir3CbdXMJW8wWiC7NMTKOs409Qan9ZWkXqX6qD3afEZN2nD9+5qpAdvhuhCA+94N82886OM69nMNCv7YETABunxYgxC2AZXy0IiOR9sg39WZM0JNMW2LtSfZehhAM17N8SN/ugYFxHnZHzirBuPy6aZbtOJYxEU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562735449; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=JO4KMfjtfPTMIdhDQI/KeNtRTeWfhmgu2Ar74nSIkW4=; b=ES4n5SBCOVgCvrK6BBPQAxDHJe/zPwwT+R3bwSAhSquBRIO4YOGgHv87MPtfZzQEnsa7cPNdQV1avjDYQw9hGeDwk58B9M0xUEFquK/ETfvNzx4/NmVsOUrqwBjKNR4Y7onKhb4WfR6IqaQhhhZcM8SAZyXMEkI/HyTF82FUVHo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562735449692986.2054775089457; Tue, 9 Jul 2019 22:10:49 -0700 (PDT) Received: from localhost ([::1]:57976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hl4sQ-0003gs-LD for importer@patchew.org; Wed, 10 Jul 2019 01:10:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44297) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hl4qm-0002QY-9a for qemu-devel@nongnu.org; Wed, 10 Jul 2019 01:09:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hl4qk-0000Pu-G1 for qemu-devel@nongnu.org; Wed, 10 Jul 2019 01:09:04 -0400 Received: from mga02.intel.com ([134.134.136.20]:6071) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hl4qi-0000AM-IN for qemu-devel@nongnu.org; Wed, 10 Jul 2019 01:09:02 -0400 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jul 2019 22:08:57 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga005.fm.intel.com with ESMTP; 09 Jul 2019 22:08:57 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,473,1557212400"; d="scan'208";a="364360413" From: Wei Yang To: qemu-devel@nongnu.org Date: Wed, 10 Jul 2019 13:08:14 +0800 Message-Id: <20190710050814.31344-3-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190710050814.31344-1-richardw.yang@linux.intel.com> References: <20190710050814.31344-1-richardw.yang@linux.intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.20 Subject: [Qemu-devel] [PATCH 2/2] migration/postcopy: do_fixup is true when host_offset is non-zero X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wei Yang , dgilbert@redhat.com, quintela@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This means it is not necessary to spare an extra variable to hold this condition. Use host_offset directly is fine. Signed-off-by: Wei Yang Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index c4dc36e525..b0ca0059c4 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -2873,7 +2873,6 @@ static void postcopy_chunk_hostpages_pass(MigrationSt= ate *ms, bool unsent_pass, } =20 while (run_start < pages) { - bool do_fixup =3D false; unsigned long fixup_start_addr; unsigned long host_offset; =20 @@ -2883,7 +2882,6 @@ static void postcopy_chunk_hostpages_pass(MigrationSt= ate *ms, bool unsent_pass, */ host_offset =3D run_start % host_ratio; if (host_offset) { - do_fixup =3D true; fixup_start_addr =3D run_start - host_offset; /* * This host page has gone, the next loop iteration starts @@ -2905,7 +2903,6 @@ static void postcopy_chunk_hostpages_pass(MigrationSt= ate *ms, bool unsent_pass, */ host_offset =3D run_end % host_ratio; if (host_offset) { - do_fixup =3D true; fixup_start_addr =3D run_end - host_offset; /* * This host page has gone, the next loop iteration starts @@ -2921,7 +2918,7 @@ static void postcopy_chunk_hostpages_pass(MigrationSt= ate *ms, bool unsent_pass, } } =20 - if (do_fixup) { + if (host_offset) { unsigned long page; =20 /* Tell the destination to discard this page */ --=20 2.17.1