From nobody Mon Feb 9 15:29:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562720958; cv=none; d=zoho.com; s=zohoarc; b=eLQdV4skJ9iZthxr9ySyMLgnB5xWy2dw45ObMAZFKdHpL3dJ7aYBUwjfyjGnFl+ArUxE4vOhQ/de6lBuyp0SScREFrZ5asNdYdVP9KuX+HScSZKvGGIw0MZRZFsAukVcR7e0Tw4oFCxt0Y8ZJVbCRbOEkQuv+4A0yPARGXpyzOI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562720958; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=61l2NO4oCuZigcYArZr4chjlJJB+0El7YzlAoMnzGlc=; b=Pofy0bnB3rZPIrxDvbqgH+DzQjLSzU8mtiA+a/rCmcVTa6W4ab8pe47yQEbNkdFcvBfIi5+X+uc4Fhxj520amWwo0Ldu0xs7rFRVjI5yup3U9KSs59xkPGSR///TugKWz1tbm7mpEpLC8D+SVgfS1HC0qsgNn62akzaGnmckxjg= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562720958653569.8954835654791; Tue, 9 Jul 2019 18:09:18 -0700 (PDT) Received: from localhost ([::1]:57338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hl16e-0002GT-05 for importer@patchew.org; Tue, 09 Jul 2019 21:09:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49257) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hl13t-0000VB-Oc for qemu-devel@nongnu.org; Tue, 09 Jul 2019 21:06:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hl13m-0004T5-Vn for qemu-devel@nongnu.org; Tue, 09 Jul 2019 21:06:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57000) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hl13h-0004Jh-56; Tue, 09 Jul 2019 21:06:11 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 43C9E3082AED; Wed, 10 Jul 2019 01:06:07 +0000 (UTC) Received: from probe.bos.redhat.com (dhcp-17-215.bos.redhat.com [10.18.17.215]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7BCD61001B19; Wed, 10 Jul 2019 01:06:06 +0000 (UTC) From: John Snow To: qemu-block@nongnu.org, qemu-devel@nongnu.org Date: Tue, 9 Jul 2019 21:05:54 -0400 Message-Id: <20190710010556.32365-7-jsnow@redhat.com> In-Reply-To: <20190710010556.32365-1-jsnow@redhat.com> References: <20190710010556.32365-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 10 Jul 2019 01:06:07 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 6/8] block/backup: issue progress updates for skipped regions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , John Snow , Markus Armbruster , Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The way bitmap backups work is by starting at 75% if it needs to copy just 25% of the disk. The way sync=3Dtop currently works, however, is to start at 0% and then never update the progress if it doesn't copy a region. If it needs to copy 25% of the disk, we'll finish at 25%. Update the progress when we skip regions. Signed-off-by: John Snow Reviewed-by: Max Reitz --- block/backup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/backup.c b/block/backup.c index a64b768e24..38c4a688c6 100644 --- a/block/backup.c +++ b/block/backup.c @@ -417,6 +417,7 @@ static int coroutine_fn backup_loop(BackupBlockJob *job) if (job->sync_mode =3D=3D MIRROR_SYNC_MODE_TOP && bdrv_is_unallocated_range(bs, offset, job->cluster_size)) { + job_progress_update(&job->common.job, job->cluster_size); bdrv_reset_dirty_bitmap(job->copy_bitmap, offset, job->cluster_size); continue; --=20 2.21.0