[Qemu-devel] [PATCH RESEND v6 00/14] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

Tao Xu posted 14 patches 4 years, 8 months ago
Test checkpatch passed
Test s390x failed
Test asan failed
Test docker-mingw@fedora passed
Test FreeBSD passed
Test docker-clang@ubuntu failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190709071520.8745-1-tao3.xu@intel.com
Maintainers: Beniamino Galvani <b.galvani@gmail.com>, Jan Kiszka <jan.kiszka@web.de>, Paolo Bonzini <pbonzini@redhat.com>, Rob Herring <robh@kernel.org>, Xiao Guangrong <xiaoguangrong.eric@gmail.com>, Eduardo Habkost <ehabkost@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Andrzej Zaborowski <balrogg@gmail.com>, Leif Lindholm <leif.lindholm@linaro.org>, Igor Mammedov <imammedo@redhat.com>, Andrew Jeffery <andrew@aj.id.au>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Alistair Francis <alistair@alistair23.me>, Thomas Huth <thuth@redhat.com>, Richard Henderson <rth@twiddle.net>, David Gibson <david@gibson.dropbear.id.au>, Jean-Christophe Dubois <jcd@tribudubois.net>, Peter Chubb <peter.chubb@nicta.com.au>, Markus Armbruster <armbru@redhat.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Andrew Baumann <Andrew.Baumann@microsoft.com>, Joel Stanley <joel@jms.id.au>, Radoslaw Biernacki <radoslaw.biernacki@linaro.org>, Igor Mitsyanko <i.mitsyanko@gmail.com>, Andrey Smirnov <andrew.smirnov@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, "Cédric Le Goater" <clg@kaod.org>, Eric Blake <eblake@redhat.com>, Shannon Zhao <shannon.zhaosl@gmail.com>
There is a newer version of this series
exec.c                              |   5 +-
hw/acpi/Kconfig                     |   5 +
hw/acpi/Makefile.objs               |   1 +
hw/acpi/acpi-stub.c                 |   7 +
hw/acpi/aml-build.c                 |   9 +-
hw/acpi/hmat.c                      | 552 ++++++++++++++++++++++++++++
hw/acpi/hmat.h                      | 172 +++++++++
hw/acpi/nvdimm.c                    |  49 ++-
hw/arm/aspeed.c                     |   5 +-
hw/arm/boot.c                       |  20 +-
hw/arm/collie.c                     |   8 +-
hw/arm/cubieboard.c                 |   5 +-
hw/arm/exynos4_boards.c             |   7 +-
hw/arm/highbank.c                   |   8 +-
hw/arm/imx25_pdk.c                  |   5 +-
hw/arm/integratorcp.c               |   8 +-
hw/arm/kzm.c                        |   5 +-
hw/arm/mainstone.c                  |   5 +-
hw/arm/mcimx6ul-evk.c               |   5 +-
hw/arm/mcimx7d-sabre.c              |   5 +-
hw/arm/musicpal.c                   |   8 +-
hw/arm/nseries.c                    |   5 +-
hw/arm/omap_sx1.c                   |   5 +-
hw/arm/palm.c                       |  10 +-
hw/arm/raspi.c                      |   6 +-
hw/arm/realview.c                   |   5 +-
hw/arm/sabrelite.c                  |   5 +-
hw/arm/sbsa-ref.c                   |  12 +-
hw/arm/spitz.c                      |   5 +-
hw/arm/tosa.c                       |   8 +-
hw/arm/versatilepb.c                |   5 +-
hw/arm/vexpress.c                   |   5 +-
hw/arm/virt-acpi-build.c            |  19 +-
hw/arm/virt.c                       |  17 +-
hw/arm/xilinx_zynq.c                |   8 +-
hw/arm/xlnx-versal-virt.c           |   7 +-
hw/arm/xlnx-zcu102.c                |   5 +-
hw/arm/z2.c                         |   8 +-
hw/core/machine-hmp-cmds.c          |  12 +-
hw/core/machine-qmp-cmds.c          |  39 ++
hw/core/machine.c                   |  42 ++-
hw/core/numa.c                      | 300 +++++++++++++--
hw/i386/acpi-build.c                |  11 +-
hw/i386/pc.c                        |  13 +-
hw/i386/pc_piix.c                   |   6 +
hw/i386/pc_q35.c                    |   6 +
hw/mem/pc-dimm.c                    |   2 +
hw/pci-bridge/pci_expander_bridge.c |   3 +-
hw/ppc/spapr.c                      |  33 +-
hw/ppc/spapr_pci.c                  |   4 +-
include/hw/acpi/aml-build.h         |   2 +-
include/hw/arm/boot.h               |   4 +-
include/hw/boards.h                 |   1 +
include/hw/mem/nvdimm.h             |   6 +
include/qemu/typedefs.h             |   2 +
include/sysemu/numa.h               |  35 +-
include/sysemu/sysemu.h             |  24 ++
qapi/machine.json                   | 235 +++++++++++-
qemu-options.hx                     |  84 ++++-
tests/bios-tables-test.c            |  43 +++
60 files changed, 1672 insertions(+), 264 deletions(-)
create mode 100644 hw/acpi/hmat.c
create mode 100644 hw/acpi/hmat.h
[Qemu-devel] [PATCH RESEND v6 00/14] Build ACPI Heterogeneous Memory Attribute Table (HMAT)
Posted by Tao Xu 4 years, 8 months ago
This series of patches will build Heterogeneous Memory Attribute Table (HMAT)
according to the command line. The ACPI HMAT describes the memory attributes,
such as memory side cache attributes and bandwidth and latency details,
related to the Memory Proximity Domain.
The software is expected to use HMAT information as hint for optimization.

In the linux kernel, the codes in drivers/acpi/hmat/hmat.c parse and report
the platform's HMAT tables.

The V5 patches link:
https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg03138.html

Changelog:
v6:
    - Rebase to upstream, move numa globals in arm/sbsa-ref
    - When used once or twice in the function, use
      ms->numa_state->num_nodes(numa_info) directly (Igor)
    - Correct some mistakes
    - Use once monitor_printf in hmp_info_numa (Igor)
    - Add new patch to extend CLI of "-numa node" option to indicate the
      initiator numa node-id (Dan)
    - Update to ACPI 6.3 (Jonathan)
    - Add QMP interface to update HMAT at runtime (Igor)
    - Add test cases for ACPI HMAT

v5:
    - spilt the 1-6/11 and 8/11 from patch v4 to build Memory Subsystem
    Address Range Structure(s) and System Locality Latency and Bandwidth
    Information Structure(s) firstly.
    - add 1/8 of patch v5 to simplify arm_load_dtb() (Igor)
    - drop the helper machine_num_numa_nodes() and use
    machine->numa_state->num_nodes (and numa_state->nodes) directly (Igor)
    - Add more descriptions from ACPI spec (Igor)
    - Add the reason of using stub (Igor)
    - Use GArray for NUMA memory ranges data (Igor)
    - Separate hmat_build_lb() (Igor)
    - Drop all global variables and use local variables instead (Igor)
    - Add error message when base unit < 10
    - Update the hmat-lb option example by using '-numa cpu'
    and '-numa memdev' (Igor)

v4:
    - send the patch of "move numa global variables into MachineState"
    together with HMAT patches.
    https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg03662.html
    - spilt the 1/8 of v3 patch into two patches, 4/11 introduces
    build_mem_ranges() and 5/11 builds HMAT (Igor)
    - use build_append_int_noprefix() to build parts of ACPI table in
    all patches (Igor)
    - Split 8/8 of patch v3 into two parts, 10/11 introduces NFIT
    generalizations (build_acpi_aml_common), and use it in 11/11 to
    simplify hmat_build_aml (Igor)
    - use MachineState instead of PCMachineState to build HMAT more
    generalic (Igor)
    - move the 7/8 v3 patch into the former patches
    - update the version tag from 4.0 to 4.1
v3:
    - rebase the fixing patch into the jingqi's patches (Eric)
    - update the version tag from 3.10 to 4.0 (Eric)
v2:
  Per Igor and Eric's comments, fix some coding style and small issues:
    - update the version number in qapi/misc.json
    - including the expansion of the acronym HMAT in qapi/misc.json
    - correct spell mistakes in qapi/misc.json and qemu-options.hx
    - fix the comment syle in hw/i386/acpi-build.c
    and hw/acpi/hmat.h
   - remove some unnecessary head files in hw/acpi/hmat.c 
   - use hardcoded numbers from spec to generate
   Memory Subsystem Address Range Structure in hw/acpi/hmat.c
   - drop the struct AcpiHmat and AcpiHmatSpaRange
    in hw/acpi/hmat.h
   - rewrite NFIT code to build _HMA method

Liu Jingqi (6):
  hmat acpi: Build Memory Proximity Domain Attributes Structure(s)
  hmat acpi: Build System Locality Latency and Bandwidth Information
    Structure(s)
  hmat acpi: Build Memory Side Cache Information Structure(s)
  numa: Extend the CLI to provide memory latency and bandwidth
    information
  numa: Extend the CLI to provide memory side cache information
  hmat acpi: Implement _HMA method to update HMAT at runtime

Tao Xu (8):
  hw/arm: simplify arm_load_dtb
  numa: move numa global variable nb_numa_nodes into MachineState
  numa: move numa global variable have_numa_distance into MachineState
  numa: move numa global variable numa_info into MachineState
  numa: Extend CLI to provide initiator information for numa nodes
  acpi: introduce aml_build_runtime_buf for NFIT generalizations
  QMP: Add QMP interface to update HMAT at runtime
  tests/bios-tables-test: add test cases for ACPI HMAT

 exec.c                              |   5 +-
 hw/acpi/Kconfig                     |   5 +
 hw/acpi/Makefile.objs               |   1 +
 hw/acpi/acpi-stub.c                 |   7 +
 hw/acpi/aml-build.c                 |   9 +-
 hw/acpi/hmat.c                      | 552 ++++++++++++++++++++++++++++
 hw/acpi/hmat.h                      | 172 +++++++++
 hw/acpi/nvdimm.c                    |  49 ++-
 hw/arm/aspeed.c                     |   5 +-
 hw/arm/boot.c                       |  20 +-
 hw/arm/collie.c                     |   8 +-
 hw/arm/cubieboard.c                 |   5 +-
 hw/arm/exynos4_boards.c             |   7 +-
 hw/arm/highbank.c                   |   8 +-
 hw/arm/imx25_pdk.c                  |   5 +-
 hw/arm/integratorcp.c               |   8 +-
 hw/arm/kzm.c                        |   5 +-
 hw/arm/mainstone.c                  |   5 +-
 hw/arm/mcimx6ul-evk.c               |   5 +-
 hw/arm/mcimx7d-sabre.c              |   5 +-
 hw/arm/musicpal.c                   |   8 +-
 hw/arm/nseries.c                    |   5 +-
 hw/arm/omap_sx1.c                   |   5 +-
 hw/arm/palm.c                       |  10 +-
 hw/arm/raspi.c                      |   6 +-
 hw/arm/realview.c                   |   5 +-
 hw/arm/sabrelite.c                  |   5 +-
 hw/arm/sbsa-ref.c                   |  12 +-
 hw/arm/spitz.c                      |   5 +-
 hw/arm/tosa.c                       |   8 +-
 hw/arm/versatilepb.c                |   5 +-
 hw/arm/vexpress.c                   |   5 +-
 hw/arm/virt-acpi-build.c            |  19 +-
 hw/arm/virt.c                       |  17 +-
 hw/arm/xilinx_zynq.c                |   8 +-
 hw/arm/xlnx-versal-virt.c           |   7 +-
 hw/arm/xlnx-zcu102.c                |   5 +-
 hw/arm/z2.c                         |   8 +-
 hw/core/machine-hmp-cmds.c          |  12 +-
 hw/core/machine-qmp-cmds.c          |  39 ++
 hw/core/machine.c                   |  42 ++-
 hw/core/numa.c                      | 300 +++++++++++++--
 hw/i386/acpi-build.c                |  11 +-
 hw/i386/pc.c                        |  13 +-
 hw/i386/pc_piix.c                   |   6 +
 hw/i386/pc_q35.c                    |   6 +
 hw/mem/pc-dimm.c                    |   2 +
 hw/pci-bridge/pci_expander_bridge.c |   3 +-
 hw/ppc/spapr.c                      |  33 +-
 hw/ppc/spapr_pci.c                  |   4 +-
 include/hw/acpi/aml-build.h         |   2 +-
 include/hw/arm/boot.h               |   4 +-
 include/hw/boards.h                 |   1 +
 include/hw/mem/nvdimm.h             |   6 +
 include/qemu/typedefs.h             |   2 +
 include/sysemu/numa.h               |  35 +-
 include/sysemu/sysemu.h             |  24 ++
 qapi/machine.json                   | 235 +++++++++++-
 qemu-options.hx                     |  84 ++++-
 tests/bios-tables-test.c            |  43 +++
 60 files changed, 1672 insertions(+), 264 deletions(-)
 create mode 100644 hw/acpi/hmat.c
 create mode 100644 hw/acpi/hmat.h

-- 
2.20.1


Re: [Qemu-devel] [PATCH RESEND v6 00/14] Build ACPI Heterogeneous Memory Attribute Table (HMAT)
Posted by no-reply@patchew.org 4 years, 8 months ago
Patchew URL: https://patchew.org/QEMU/20190709071520.8745-1-tao3.xu@intel.com/



Hi,

This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      hw/audio/ac97.o
  CC      hw/audio/fmopl.o
  CC      hw/audio/adlib.o
/tmp/qemu-test/src/hw/acpi/hmat.c:261:23: error: taking address of packed member 'offset' of class or structure 'HmatHmamIn' may result in an unaligned pointer value [-Werror,-Waddress-of-packed-member]
        le32_to_cpus(&in->offset);
                      ^~~~~~~~~~
1 error generated.


The full log is available at
http://patchew.org/logs/20190709071520.8745-1-tao3.xu@intel.com/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH RESEND v6 00/14] Build ACPI Heterogeneous Memory Attribute Table (HMAT)
Posted by no-reply@patchew.org 4 years, 8 months ago
Patchew URL: https://patchew.org/QEMU/20190709071520.8745-1-tao3.xu@intel.com/



Hi,

This series failed build test on s390x host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
set -e

echo
echo "=== ENV ==="
env

echo
echo "=== PACKAGES ==="
rpm -qa

echo
echo "=== UNAME ==="
uname -a

CC=$HOME/bin/cc
INSTALL=$PWD/install
BUILD=$PWD/build
mkdir -p $BUILD $INSTALL
SRC=$PWD
cd $BUILD
$SRC/configure --cc=$CC --prefix=$INSTALL
make -j4
# XXX: we need reliable clean up
# make check -j4 V=1
make install
=== TEST SCRIPT END ===

  GEN     util/trace.c
  GEN     config-all-devices.mak
Cloning into '/var/tmp/patchew-tester-tmp-ehkqzjm7/src/dtc'...
error: RPC failed; curl 18 transfer closed with outstanding read data remaining
fatal: the remote end hung up unexpectedly
fatal: protocol error: bad pack header
fatal: clone of 'https://git.qemu.org/git/dtc.git' into submodule path '/var/tmp/patchew-tester-tmp-ehkqzjm7/src/dtc' failed
Failed to clone 'dtc'. Retry scheduled
Cloning into '/var/tmp/patchew-tester-tmp-ehkqzjm7/src/slirp'...
---
Cloning into '/var/tmp/patchew-tester-tmp-ehkqzjm7/src/tests/fp/berkeley-testfloat-3'...
Cloning into '/var/tmp/patchew-tester-tmp-ehkqzjm7/src/ui/keycodemapdb'...
Cloning into '/var/tmp/patchew-tester-tmp-ehkqzjm7/src/dtc'...
error: RPC failed; curl 18 transfer closed with outstanding read data remaining
fatal: the remote end hung up unexpectedly
fatal: protocol error: bad pack header
fatal: clone of 'https://git.qemu.org/git/dtc.git' into submodule path '/var/tmp/patchew-tester-tmp-ehkqzjm7/src/dtc' failed
Failed to clone 'dtc' a second time, aborting
./scripts/git-submodule.sh: failed to update modules


The full log is available at
http://patchew.org/logs/20190709071520.8745-1-tao3.xu@intel.com/testing.s390x/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com