From nobody Sun Apr 28 00:03:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1562343217; cv=none; d=zoho.com; s=zohoarc; b=TfCFEuKuuldRvSHqbsTuzPKGr9WtqWBkeRfo26ToNWfklo2Aq5sO2KO4kOgUdf2ZwO5djgvgspGE9aSL1JyhAWmZlT3puGL90f9OHLLYif0vJkVqcGPyXj4JcUoP9xIDfspOkDyN0lsD+2O4ACQqKVOQvg+jqTCbe3scs/360H4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562343217; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=mM1Kb6A1N3/Dz5Nk0cJ9QkDDg49iumbs9t4kZbIKPkI=; b=Zb1jbcyVepjGTWbgZju2MXmq/N/PLEBPW6T2zDyXU0JI0b7c8ZY20LtM8/R3W2aaJxkz2S7YikInM9phnwyZ9LN4053dX8kGy9oZ8OJPk7dji8surGlSrsDbYFohUN+Rimt7jVI4poj9+/NDX3HW3OFBUjIhuFGXmGvaAZmPUAk= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562343217044875.9510588076645; Fri, 5 Jul 2019 09:13:37 -0700 (PDT) Received: from localhost ([::1]:54634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjQq1-00040I-9E for importer@patchew.org; Fri, 05 Jul 2019 12:13:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40371) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjQhf-0002yf-Jy for qemu-devel@nongnu.org; Fri, 05 Jul 2019 12:04:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjQhc-0001ze-K2 for qemu-devel@nongnu.org; Fri, 05 Jul 2019 12:04:50 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:36541) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjQhb-0000Mx-Ch for qemu-devel@nongnu.org; Fri, 05 Jul 2019 12:04:48 -0400 Received: by mail-wm1-x32e.google.com with SMTP id g67so3973719wme.1 for ; Fri, 05 Jul 2019 09:04:23 -0700 (PDT) Received: from zen.linaroharston ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id d9sm13335593wrb.71.2019.07.05.09.04.21 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Jul 2019 09:04:22 -0700 (PDT) Received: from zen.linaroharston. (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 8C7421FF8C; Fri, 5 Jul 2019 17:04:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mM1Kb6A1N3/Dz5Nk0cJ9QkDDg49iumbs9t4kZbIKPkI=; b=B+tqP9I2K5+Tn0q1xTHuNqxtvalMjBwgpRBufaF3SfhdXrnTb/pgmhQfNXP9lh8WML gzqDf3amfLMEWDOVNb5FvaTjtUIrXZQ3n8dBzn0xeHzjZywuHImPLALClJckQ2+YE+bq LBC9f8G4Cj2Uq22ODM/ZuH3ZeT2S2bql1id06uLDZjbS3G8BsGcDZiPjiZjULUJHyxL5 /HczLHViXPhnCv5gHEfNNhNW0v8H6sn8FjVA48ad0fLtq/MsYh5hsTe53RvKEPmkzPTR JVGKPCcWW79QVCNqO4nkkJWZfXkYUHTDJ3RJ7i3wgwSnP5Bpq7eYdHrHleiBkIvbCish a8Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mM1Kb6A1N3/Dz5Nk0cJ9QkDDg49iumbs9t4kZbIKPkI=; b=h9dPruawaiaT9kIvyd5tSRC+5y+fhyjEkMLWvHKy3LFLx44xCLIlxp0uGY62/uzN6Z SqUS551QkhAG1oxLiXBfwWRZkd9GBhkHE9F7Hd+u78do1CJBxwt8ON7DO+qz+hlrr4r/ MS8+hTnMGlX7enNy+4n8VnC2p/FkSpRYY3x8HjrY0kU9HhE+DkqOhKPPN82PYbaUbxTZ MoVnxyFCloJOSTVxfbEAq8mVA4RKuibcRZIFWdM6L9BlZRIkFQXlJb4Ls5A382gLcda0 GqA5MXY025MCGhPmasf7Ot/mp9b6i5Q9MqZj6kvVWrUQF2s9iyMpEjdobThFUTQnD1PV SC+Q== X-Gm-Message-State: APjAAAUpQv3Q/ciWL7CQrTEC2Mb4VHNWcz9FDNCqUS83fwHyeB70sg7E YCrT7xWtahyJPi2uziGYNmqSww== X-Google-Smtp-Source: APXvYqx524yNaBBH5LNxbXNG8rKJ8ddDXHkfXVGbTXyapq5k1Y1aZ2LJ7ugdobxufcA070obXpbbQA== X-Received: by 2002:a7b:c195:: with SMTP id y21mr407119wmi.16.1562342662844; Fri, 05 Jul 2019 09:04:22 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Fri, 5 Jul 2019 17:04:17 +0100 Message-Id: <20190705160421.19015-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190705160421.19015-1-alex.bennee@linaro.org> References: <20190705160421.19015-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32e Subject: [Qemu-devel] [PATCH v1 1/5] target/arm/vfp_helper: Call set_fpscr_to_host before updating FPSCR reg X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Desnogues , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Philippe Mathieu-Daud=C3=A9 In commit e9d652824b0 we extracted the vfp_set_fpscr_to_host() function but failed at calling it in the correct place, we call it after xregs[ARM_VFP_FPSCR] is modified. Fix by calling this function before we update FPSCR. Reported-by: Laurent Desnogues Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Desnogues Tested-by: Laurent Desnogues Message-Id: <20190705124318.1075-1-philmd@redhat.com> Signed-off-by: Alex Benn=C3=A9e --- target/arm/vfp_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/vfp_helper.c b/target/arm/vfp_helper.c index 46041e3294..9710ef1c3e 100644 --- a/target/arm/vfp_helper.c +++ b/target/arm/vfp_helper.c @@ -197,6 +197,8 @@ void HELPER(vfp_set_fpscr)(CPUARMState *env, uint32_t v= al) val &=3D 0xf7c0009f; } =20 + vfp_set_fpscr_to_host(env, val); + /* * We don't implement trapped exception handling, so the * trap enable bits, IDE|IXE|UFE|OFE|DZE|IOE are all RAZ/WI (not RES0!) @@ -217,8 +219,6 @@ void HELPER(vfp_set_fpscr)(CPUARMState *env, uint32_t v= al) env->vfp.qc[1] =3D 0; env->vfp.qc[2] =3D 0; env->vfp.qc[3] =3D 0; - - vfp_set_fpscr_to_host(env, val); } =20 void vfp_set_fpscr(CPUARMState *env, uint32_t val) --=20 2.20.1 From nobody Sun Apr 28 00:03:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1562343221; cv=none; d=zoho.com; s=zohoarc; b=nlgFwUNhKmj6+K+S7O8ajVVi8EX402zKVdmh4SoKJBa8dfLm4UrXvplX3Eht+SluI19iuylXkXuGR+As/Ftc96Hi4t2fHK4mybpWt1YsH82iFh2UmNcCiTX+A6oR+YW4l2KhGtQjVfwJazYbs1lcv9MJptH8VYw+m5YuWC4OuAk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562343221; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=pnvxSKN5dF6BFileI9vCwcNPxM0MUq6YBqg0MnEs6Us=; b=mIXYDxFDZPgII7Tjy3JUhHaBQA3N66+1oGOk5Rempy3M7vEXA3NxJ8NrgzDlYeI2e5M176LhKpwV5sR2ZbRt5ryL5zVqTxMUWGSjAkCKQkOoOi56ajkpG7eXlRnmEOrEPVPEksNP7asv8ogy/zfCu4aLlR6+7z4u1f+SinQLp1U= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562343221746109.64590989722763; Fri, 5 Jul 2019 09:13:41 -0700 (PDT) Received: from localhost ([::1]:54638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjQq7-0004L5-MM for importer@patchew.org; Fri, 05 Jul 2019 12:13:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40430) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjQhi-00034A-35 for qemu-devel@nongnu.org; Fri, 05 Jul 2019 12:04:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjQhg-0002Im-Rr for qemu-devel@nongnu.org; Fri, 05 Jul 2019 12:04:53 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:44550) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjQhg-0000Qk-Ii for qemu-devel@nongnu.org; Fri, 05 Jul 2019 12:04:52 -0400 Received: by mail-wr1-x442.google.com with SMTP id b2so9214066wrx.11 for ; Fri, 05 Jul 2019 09:04:24 -0700 (PDT) Received: from zen.linaroharston ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id j189sm8758466wmb.48.2019.07.05.09.04.21 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Jul 2019 09:04:22 -0700 (PDT) Received: from zen.linaroharston. (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id A10841FF8F; Fri, 5 Jul 2019 17:04:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pnvxSKN5dF6BFileI9vCwcNPxM0MUq6YBqg0MnEs6Us=; b=wxvvzLI3pUyLFfRu4W8fnfvua8x4klS/NKHe8jRWR31kuqfg2IJeaGiC8S54hKVZZB hadE+mlk9PaZIrRtjrtIYqf8c8xHylMDOSmrf28HMNKhKrbVVG5b8tpQ/S0mXGJwq36m NyyiyenTL6o0BL8poTqxi0dWeOXnoY03k0Sw5KDlpwGBCb4AKPLaKlaSggbk+jo9HDmo 6WNH26IPsT8gP9I1V7QWHZ4ihuFP3xwHwsFx0nu1klugcYiSuocHdzbj4OLB6AI3EbxS 8QV+BBXs6hsQXo6mxlUncumhCu2dsSX2MywhUB3FSMkW9B9uZYjvOfWaaTKkFt4eo8BI lQWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pnvxSKN5dF6BFileI9vCwcNPxM0MUq6YBqg0MnEs6Us=; b=AriaxK6u4dBRMEbi7WEvrrJxutZgB6qJNwP2exo+t1XuzhQBPfk67crVp9sOKtZ27S 2XJFoFF8RfFaSy2Y9YbGlNlq3xM+kQ4QTy6m9R5AbCI2G22m31booqYUJoE4m9fIur61 OvDQqiIKvOvX2QCRFdDokHmaW5a1lPOphe43A7NlydkL0YHE04F3UuMtDpdTlcOetaoK TEK7SwNUG7UcYCC8PYzAYr4U9pCNjfebT+HLvIkZ8idy0DY/MgmMoELvlSvjDEMq6kvG 00QGgjFpDVpEBnOUjcidK0ouSrYx1AxF+zKwCYrmvGzFbsTa3aFzhvZMAZDxwiEUv0uI J5JA== X-Gm-Message-State: APjAAAUxBH7yxGTzfi1FW0woAmmwMLPeEfaO1QmRad0zqDx1lq8GfxLX zJlq+SVemzLLQI4z+SZXGGm3PQ== X-Google-Smtp-Source: APXvYqyFv8HmS1JRFskvuOTk1R5Kaq6SR+WCg7p2oMhWUWWCf7Oexv80lnbKwptXaT3GFHp5gi4Rgg== X-Received: by 2002:a5d:6089:: with SMTP id w9mr4796366wrt.166.1562342663656; Fri, 05 Jul 2019 09:04:23 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Fri, 5 Jul 2019 17:04:18 +0100 Message-Id: <20190705160421.19015-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190705160421.19015-1-alex.bennee@linaro.org> References: <20190705160421.19015-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH v1 2/5] tests/tcg: fix up test-i386-fprem.ref generation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , qemu-arm@nongnu.org, Jan Bobek , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) We never shipped the reference data in the source tree because it was quite big (64M). As a result the only option is to generate it locally. Although we have a rule to generate the reference file we missed the dependency and location changes, probably because it is only run for SLOW test runs. The test still fails with mostly incorrect flags and different than expected NaNs. I'll leave that for the x86 experts to look at. Signed-off-by: Alex Benn=C3=A9e Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Jan Bobek Reviewed-by: Richard Henderson --- tests/tcg/i386/Makefile.target | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/tcg/i386/Makefile.target b/tests/tcg/i386/Makefile.target index b4033ba3d1..d0eb7023e5 100644 --- a/tests/tcg/i386/Makefile.target +++ b/tests/tcg/i386/Makefile.target @@ -35,9 +35,9 @@ test-i386-fprem.ref: test-i386-fprem $(call quiet-command, ./$< > $@,"GENREF","generating $@") =20 run-test-i386-fprem: TIMEOUT=3D60 -run-test-i386-fprem: test-i386-fprem +run-test-i386-fprem: test-i386-fprem test-i386-fprem.ref $(call run-test,test-i386-fprem, $(QEMU) $<,"$< on $(TARGET_NAME)") - $(call diff-out,test-i386-fprem, $(I386_SRC)/$<.ref) + $(call diff-out,test-i386-fprem, test-i386-fprem.ref) else run-test-i386-fprem: test-i386-fprem $(call skip-test, $<, "SLOW") --=20 2.20.1 From nobody Sun Apr 28 00:03:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1562343311; cv=none; d=zoho.com; s=zohoarc; b=Qe0rl8dmGMJ/YUbvVx604GH0xJwyGAtTV8MZf4VC9Lc1O4FGuiXx0DmMaX1g6JDAUZXCtgWgeV50TfQgvBZvbvj5+bMYScjcMB5dXp92XmVFmj7EhlwgW5281JvIXMWZVTurxLuDnAupsAUUC4tWZ7yRwyKbTRj+RMDyL6qJk74= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562343311; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=rcuPIsMvIORKeTdOPCcArgmZ5EQEGenIxSqtwUik0XE=; b=hqtIe1xlaQhkYgGjiFkQNQ64h6vULxsE66BAxkd7L0nQhhUn0iGA/xT5Voxs10vUSRxD4oLdyIUEQoYiA9tlKLgWgbAgWjiEUb9ah/1pxiNSz9O6UitDgmbK2dNsl7dab5QhWF6rzrTcASKEizy4oapfXbbrIvNg5pwMZXAAE/4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 156234331120422.587952503566612; Fri, 5 Jul 2019 09:15:11 -0700 (PDT) Received: from localhost ([::1]:54682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjQrd-0005ho-Uq for importer@patchew.org; Fri, 05 Jul 2019 12:15:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40286) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjQhc-0002v9-J4 for qemu-devel@nongnu.org; Fri, 05 Jul 2019 12:04:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjQha-0001op-9K for qemu-devel@nongnu.org; Fri, 05 Jul 2019 12:04:48 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:33405) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjQhX-0000Ue-Eh for qemu-devel@nongnu.org; Fri, 05 Jul 2019 12:04:44 -0400 Received: by mail-wr1-x444.google.com with SMTP id n9so10475431wru.0 for ; Fri, 05 Jul 2019 09:04:25 -0700 (PDT) Received: from zen.linaroharston ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id 91sm1900253wrp.3.2019.07.05.09.04.21 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Jul 2019 09:04:22 -0700 (PDT) Received: from zen.linaroharston. (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id B65081FF90; Fri, 5 Jul 2019 17:04:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rcuPIsMvIORKeTdOPCcArgmZ5EQEGenIxSqtwUik0XE=; b=jW3QtI5c8Zulhdo28F5UE+/Zatu6U5f4ri7hwx76IrIzPTUZjqR+pGLiUWBWeVNJuy x++NA1t0ukYLSNmQzgy+9MX7rpOleDxIzEOul2339Hu++lMumqcagWJDJ5YHmgfVGNl3 /KrpLHG8ywA3HJvQE2R5NjpS2W+Z916vi6J5IQRVbdwjKYXVhHHJIgNJFsEYHRVdgf5L ceD1awHUq47TKANxJQW05wlaL1lQnNCO98CZ0g/NoSHPpeHHYcpqoHUB830ehs17H855 hRpW0dsCgsMrwCoTlvWcFZUvJWo6xn94651YCGA4hvEktiA0F4EGLIUYaRR+jL6JeBd6 yelQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rcuPIsMvIORKeTdOPCcArgmZ5EQEGenIxSqtwUik0XE=; b=snthMem2eCMYeP7Y0c7Z6TLb6rgAcpmhAGNRjN6aropo5ijasvccxZvkTDxDghWDpI TKBbk2grlbQjsO7JsxRS3BBsrebYJjGL1v1ayIBtv75SG7trfzFd4dQRm8fwM/1aLutB 7VK+tFmxM6SNLpGoP7vGehdEht2c6771MUYGnXRWl2i9oUSb8/QlwZqXHD9Ukn7gzh7A IICi6VIeQ362/r5lPzqZf0o6kwLLP6TB/+GP6Cchnl881CWfJnfsxSMdhClAzvZz6rOD o9R1Bm1xCLLt2mDfF0ReAcG4VPY2A2J8JEVz9OGgl6doPKtRkqL5Lj7/aUETeWNKvKpZ Rc3w== X-Gm-Message-State: APjAAAXqcD6wRu/bLECdhb0KFKH7oMtZhf5KjzlbFr4+m+k9jVWOIj07 W9M4CYJlpt6+0LAIyiZkIOmulw== X-Google-Smtp-Source: APXvYqw/4QnXqhib/bI/fFHCde7xC+xSE83VQjWl9M9szQiovNXVoA1dnMUUv8JMQ5shBeOiy4Nx+A== X-Received: by 2002:adf:d4cc:: with SMTP id w12mr4835967wrk.121.1562342664880; Fri, 05 Jul 2019 09:04:24 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Fri, 5 Jul 2019 17:04:19 +0100 Message-Id: <20190705160421.19015-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190705160421.19015-1-alex.bennee@linaro.org> References: <20190705160421.19015-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH v1 3/5] tests/tcg: fix diff-out pass to properly report failure X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) A side effect of piping the output to head is squash the exit status of the diff command. Fix this by only doing the pipe if the diff failed and then ensuring the status is non-zero. Signed-off-by: Alex Benn=C3=A9e --- tests/tcg/Makefile | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/tcg/Makefile b/tests/tcg/Makefile index 6fa63cc8d5..7973cd1ba2 100644 --- a/tests/tcg/Makefile +++ b/tests/tcg/Makefile @@ -45,7 +45,11 @@ run-test =3D $(call quiet-command, timeout $(TIMEOUT) $2= ,"TEST",$3) endif =20 # $1 =3D test name, $2 =3D reference -diff-out =3D $(call quiet-command, diff -u $1.out $2 | head -n 10,"DIFF","= $1.out with $2") +# to work around the pipe squashing the status we only pipe the result if +# we know it failed and then force failure at the end. +diff-out =3D $(call quiet-command, diff -q $1.out $2 || \ + (diff -u $1.out $2 | head -n 10 && false), \ + "DIFF","$1.out with $2") =20 # $1 =3D test name, $2 =3D reason skip-test =3D @printf " SKIPPED %s on $(TARGET_NAME) because %s\n" $1 $2 --=20 2.20.1 From nobody Sun Apr 28 00:03:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1562343426; cv=none; d=zoho.com; s=zohoarc; b=I74aIqCQehB00St9dHJnBc9/Hyrc3U8J/0Mn3GcItaAnQ4+wEOgpgUAPcCWyr53lCInx29n1TqNmzNmPl5gsaAs1ppqBA3gfyR6FXQxpgKKUeKA+IqzlSM1KIhbYGoPm2WLGThB92CcPC/RxvDxGXSZbHtzhIedwOMteR8E/R4U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562343426; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=XnuvMB0J1monHDTSCE4AjSSICHHhGGwURpGxrTZnkKs=; b=P0JBEYlD5G6ocB4WtPFi8js/zlTBYhSLvedwEflP+CAlTD8KrQ7i/RgcZgUo0DgsQlQgf/t67GH0lc8VXoUg+pt5APqtx3t8YgXnGKFQU6qnFmsK8w4f2CZwDrGTE8dBFFNoJUT+KFciSRUlBQ+q2ZCbNLO4IME5ExYD9oPW1fM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562343426759555.4325658895477; Fri, 5 Jul 2019 09:17:06 -0700 (PDT) Received: from localhost ([::1]:54700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjQtT-0007DB-Ll for importer@patchew.org; Fri, 05 Jul 2019 12:17:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40384) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjQhg-00030E-7h for qemu-devel@nongnu.org; Fri, 05 Jul 2019 12:04:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjQhe-00028E-Ji for qemu-devel@nongnu.org; Fri, 05 Jul 2019 12:04:52 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:40903) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjQhc-0000S2-MH for qemu-devel@nongnu.org; Fri, 05 Jul 2019 12:04:50 -0400 Received: by mail-wr1-x441.google.com with SMTP id r1so4119640wrl.7 for ; Fri, 05 Jul 2019 09:04:25 -0700 (PDT) Received: from zen.linaroharston ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id z25sm10457578wmf.38.2019.07.05.09.04.22 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Jul 2019 09:04:22 -0700 (PDT) Received: from zen.linaroharston. (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id CA8AA1FF91; Fri, 5 Jul 2019 17:04:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XnuvMB0J1monHDTSCE4AjSSICHHhGGwURpGxrTZnkKs=; b=in9QCrzOgJPCZLxoXL0YJFNU5Q9LDQGhLXn7xLZOmffqHnLi8S2dRRvfPPsDwaSCMS Fv48sKlgedip9fAGFX2DDl69IzOGkBE+0IpBTlWk/FnSgSA4yxELeng52SNj55yaCbtP DGmkIxGz0NOQbU51YOmanm4AtIyhNVvRA9Tc7xUc2BWJM2BQidJQOKmrqGMWZvcwtZB9 jt88V2o5iQqOX6n5g5y3zQoE5RxTHxlrSvYk8NmMD8nECbTvYAwKezNqO8usQq6eO2HV n2Up3qNUVCjQig+RvJ89IeS4XwjSdinWYpD+fapCc2m5LVA+U8lZRvodO0jwJaSGCtTy vIrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XnuvMB0J1monHDTSCE4AjSSICHHhGGwURpGxrTZnkKs=; b=R2g6uGaj3HgF11ACSXyIpVEWGl9ZZ7i9zQ0DUHC99aDbBUVSjrnbgmneMozZY+iA/w sTboxq75T67aiaqjKxcRRNY+YruqmKfY0FFJKmUT1V1XVqeQoUnUv7rlo7pksDmG5Vgd /NT3p9tGnRcdFe2oLIhehdGUxEecrjd8D7pypIjfyZN1CcpPC4xFJk96W7zBEgxFDe4g XCIKlcUezf6YSp038em0Fu/HKgfNiAwWjeYauvCVQ8pLk7+PaaX03b3VSMYXxuhpwRst JRZdKAoMOoPsyPZHfmm4BZRuy8LqhASIqA7FKMtFfoX6S9CLdLdoQpSMIYSXr1bGAxb8 dn5w== X-Gm-Message-State: APjAAAWW9vnVZEqx1/9dVpghGLB+I39YmWTYT72Y7kqz1CBQv5W7MyUQ V5MYm9HXiGFcnHuYSW2wF+nEnQ== X-Google-Smtp-Source: APXvYqwp7KEVxlhwiM9ZGm1lc1F/MVDJ/gQVOydkraAU6tU6cBXgCYWQTt+uFAfLDqrmrKXcDOa2qg== X-Received: by 2002:adf:a514:: with SMTP id i20mr4892081wrb.281.1562342664134; Fri, 05 Jul 2019 09:04:24 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Fri, 5 Jul 2019 17:04:20 +0100 Message-Id: <20190705160421.19015-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190705160421.19015-1-alex.bennee@linaro.org> References: <20190705160421.19015-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH v1 4/5] gdbstub: add some notes to the header comment X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Add a link to the remote protocol spec and an SPDX tag. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 --- gdbstub.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 8618e34311..ea3349d1aa 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1,6 +1,10 @@ /* * gdb server stub * + * This implements a subset of the remote protocol as described in: + * + * https://sourceware.org/gdb/onlinedocs/gdb/Remote-Protocol.html + * * Copyright (c) 2003-2005 Fabrice Bellard * * This library is free software; you can redistribute it and/or @@ -15,6 +19,8 @@ * * You should have received a copy of the GNU Lesser General Public * License along with this library; if not, see . + * + * SPDX-License-Identifier: GPL-2.0-or-later */ =20 #include "qemu/osdep.h" --=20 2.20.1 From nobody Sun Apr 28 00:03:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1562343039; cv=none; d=zoho.com; s=zohoarc; b=cLqTVX6P0YGE6maWEoiRtXm4VbNRUJ5FC/HvN70Uv7fCtHNJdS47cxcjg1cvOaO7k2pFS4cnSlTu/cZQb5KzIS95lE8v4yqDexe3eGLPf2mO79A/I43cbsGE067N4rfqRpbl2f2ID5T+RJSkJqQRG7sC7oJUOreaycYYfEr9t/Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562343039; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=qOB93lgrL4R9/I6qfgAIZn9QujVBWBIWVU/5cvf+96Y=; b=UdZ4ByrXJ53AH8qIpJupNHnJ36DS7Ln3k3KRb0XpzxxIvNNXk09QGOoexBkjyYXtT/pTjrQQ3i/7dtk3rruiH2o7RrD/FOIYQXDHVA3oSk2zbrXhJcjzyuWxyY1ZFayGvmiPYmNPAcXD1UYFoh3vhAzxuArddFTf9tkAgRtNV0w= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562343039697835.4714788971874; Fri, 5 Jul 2019 09:10:39 -0700 (PDT) Received: from localhost ([::1]:54528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjQnF-0000Cw-KX for importer@patchew.org; Fri, 05 Jul 2019 12:10:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40288) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjQhc-0002vB-JY for qemu-devel@nongnu.org; Fri, 05 Jul 2019 12:04:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjQha-0001qR-D5 for qemu-devel@nongnu.org; Fri, 05 Jul 2019 12:04:48 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:33290) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjQha-0000XK-4C for qemu-devel@nongnu.org; Fri, 05 Jul 2019 12:04:46 -0400 Received: by mail-wm1-x342.google.com with SMTP id h19so7885306wme.0 for ; Fri, 05 Jul 2019 09:04:26 -0700 (PDT) Received: from zen.linaroharston ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id t15sm9442318wrx.84.2019.07.05.09.04.22 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Jul 2019 09:04:24 -0700 (PDT) Received: from zen.linaroharston. (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id DDC011FF92; Fri, 5 Jul 2019 17:04:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qOB93lgrL4R9/I6qfgAIZn9QujVBWBIWVU/5cvf+96Y=; b=yHISs/FMVOK0HYzPaloOwliLqK1L8EbywhZiD2dTaa3syaAx/DPfSJEQErohzcjhA+ fg+urcQHJcWn/tJF9hTAVXjaPJfxQskfNA6vlzpgC+qWP/e8zsmWvCwIDiLBhHSmW1F3 4ADA3/qEe2aTD7a4nD6bkKmMSo9b/YkVLN3nsAQl9WPdNd5ShUxfS/M6tobWe1s0QkDu EfyF2/IeKo3dr7JqxNKdq6lI0srD+WctTrKt7iCBenTHUnSh/Ju0q34qweMj5W2R4M2S q5htEUZZXPfIXEadiUxDtcBC1oUNF8UMDwJYbPxLYsezj4Ktnl8tWPcBQ4EmvjQ7rywV HT8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qOB93lgrL4R9/I6qfgAIZn9QujVBWBIWVU/5cvf+96Y=; b=EUwH/6gAGP5VckRw5aPzN9vJbxAYcFFeLa1gfy9VVWyjZTOlUR+CUFpIi96l22dLLF Xa134y6ZRLwPn4VYnmjjvDTkVg1YemXtBTUtX27VJIPAD6mAXmq/bl9nszstXj+lB2Wv 5+lPaE7FmNgIBXf8IsznI3KpaZgDfCkz+YzGEV0vIadARHUPjB+FWXeBEUmJZr+Ss0QF HN2oBonW3+VUMBfYoEcAp2RR8mSeADqupMZcbYE+yJYFTZdyo9X73Ky+woipO+72wWT3 LC5UjQvWXN8/lbDvMLMCa6vfM7RxnJnJYmP1e3MV1ASzUBe7H+uCgc+JJCQjp+LsvaCC XPPg== X-Gm-Message-State: APjAAAWb2T0G7XKrsB1ABcyWThDQIP5wMHAExPmKi1ub1ykOFFzcxfVK JxYQuaeDDjxEIdBSvyi0prwJQw== X-Google-Smtp-Source: APXvYqzOtHMYbzrFtdfxlQL9ebz/J5izClGAj2H46rkP6+qxtkGpHEiKPuwcDAjfxgN0zsdVgjfrKw== X-Received: by 2002:a7b:cc97:: with SMTP id p23mr4185121wma.120.1562342665585; Fri, 05 Jul 2019 09:04:25 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Fri, 5 Jul 2019 17:04:21 +0100 Message-Id: <20190705160421.19015-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190705160421.19015-1-alex.bennee@linaro.org> References: <20190705160421.19015-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 Subject: [Qemu-devel] [PATCH v1 5/5] gdbstub: revert to previous set_reg behaviour X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mark Cave-Ayland , qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Jon Doron Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The refactoring of handle_set_reg missed the fact we previously had responded with an empty packet when we were not using XML based protocols. This broke the fallback behaviour for architectures that don't have registers defined in QEMU's gdb-xml directory. Revert to the previous behaviour and clean up the commentary for what is going on. Fixes: 62b3320bddd Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Cc: Jon Doron Cc: Mark Cave-Ayland Reviewed-by: Richard Henderson --- gdbstub.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index ea3349d1aa..b6df7ee25a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1669,12 +1669,23 @@ static void handle_remove_bp(GdbCmdContext *gdb_ctx= , void *user_ctx) put_packet(gdb_ctx->s, "E22"); } =20 +/* + * handle_set/get_reg + * + * Older gdb are really dumb, and don't use 'G/g' if 'P/p' is available. + * This works, but can be very slow. Anything new enough to understand + * XML also knows how to use this properly. However to use this we + * need to define a local XML file as well as be talking to a + * reasonably modern gdb. Responding with an empty packet will cause + * the remote gdb to fallback to older methods. + */ + static void handle_set_reg(GdbCmdContext *gdb_ctx, void *user_ctx) { int reg_size; =20 if (!gdb_has_xml) { - put_packet(gdb_ctx->s, "E00"); + put_packet(gdb_ctx->s, ""); return; } =20 @@ -1694,11 +1705,6 @@ static void handle_get_reg(GdbCmdContext *gdb_ctx, v= oid *user_ctx) { int reg_size; =20 - /* - * Older gdb are really dumb, and don't use 'g' if 'p' is avaialable. - * This works, but can be very slow. Anything new enough to - * understand XML also knows how to use this properly. - */ if (!gdb_has_xml) { put_packet(gdb_ctx->s, ""); return; --=20 2.20.1