From nobody Sun May 19 05:00:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562137079; cv=none; d=zoho.com; s=zohoarc; b=ExxVUQV4cP16w6BvZ4n1xqI0rjKzVpz3op/4tbfOqLAUqJZUHM+hf82fSd0ClCR34BmJXhKeZYWu5voqZnOhSW9os6EiemfDp1x0fc7RH9l0Rutz21Z46MowY0wnn/3RPHaPzIwh72sfS1X3Yja/r1y+W0HgZxJchjwYKtbIg90= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562137079; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=PZPybzmZ1l9AV0NuJzXSTVUexxsq/1R/PxBGIFC4q/w=; b=IzQ1zh8oncK5p/gG4fwAb0Yvc7RrEhKQtGejhhBdB+FSxgYMjMGokwv+N6HO2lp0Cq5ONvfcXtcpaGFfhlgaX/bT1LUnPRI1beN0nNwkKOucumj+OnwNziEC19B7OdYvFnbOYjNHjNYVQ8fuuBZmvb+/9hOwB/6XQTjbJugv9j8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562137079657264.0560508296601; Tue, 2 Jul 2019 23:57:59 -0700 (PDT) Received: from localhost ([::1]:33198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiZDB-0005Jn-DD for importer@patchew.org; Wed, 03 Jul 2019 02:57:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54989) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiZBo-0003vB-D8 for qemu-devel@nongnu.org; Wed, 03 Jul 2019 02:56:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiZBn-0007Lr-DK for qemu-devel@nongnu.org; Wed, 03 Jul 2019 02:56:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52658) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hiZBn-0007LH-85 for qemu-devel@nongnu.org; Wed, 03 Jul 2019 02:56:23 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7022D58E42; Wed, 3 Jul 2019 06:56:10 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-96.ams2.redhat.com [10.36.116.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9EBF1473DB; Wed, 3 Jul 2019 06:56:07 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 3017F17444; Wed, 3 Jul 2019 08:56:00 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Wed, 3 Jul 2019 08:56:00 +0200 Message-Id: <20190703065600.13535-2-kraxel@redhat.com> In-Reply-To: <20190703065600.13535-1-kraxel@redhat.com> References: <20190703065600.13535-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 03 Jul 2019 06:56:15 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 1/1] fix microphone lag with PA X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Martin Schrodt , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Martin Schrodt Several people have reported to have bag microphone lag with the PA backend. While I cannot reproduce the problem here, it seems that their PA somehow decides to buffer the microphone input for way too long, causing this delay. This patch sets an upper limit to the amount of data PA should hold. This fixes the problem reliably on their side, while having no adverse effects on mine. Signed-off-by: Martin Schrodt Message-id: 20190615153852.99040-1-martin@schrodt.org Signed-off-by: Gerd Hoffmann --- audio/paaudio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index fa9dd9efd4cc..5fc886bb33cd 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -618,7 +618,7 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsetting= s *as, void *drv_opaque) ss.rate =3D as->freq; =20 ba.fragsize =3D pa_usec_to_bytes(ppdo->latency, &ss); - ba.maxlength =3D -1; + ba.maxlength =3D pa_usec_to_bytes(ppdo->latency * 2, &ss); ba.minreq =3D -1; ba.prebuf =3D -1; =20 --=20 2.18.1