From nobody Fri Sep 20 22:16:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1562100386; cv=none; d=zoho.com; s=zohoarc; b=IQmqW6tng53nSZdVmu5upkKjOqtzRJ4+k2W0jz4KKlFXGf09tCcOzd/qYyb66wBgMk4i0N4tEr0aEsmt2n54dfH+AwMzEHEpdU9fL5ZN0lqX5dW0soiHsbb+IBUcjN6DmQSRC9boKZ6KmBuUQ52bL3BkguSsJuNeflmj6qcF8KE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562100386; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=Ipv4omeKIX3tet08PT48VroACEDK0YOfJcCL2ggrZpk=; b=HaVOAGCZogMhZ1e5/2/BS3u0OPARa/T7Nmp4Y5t1s45XRGmep8U//dUtWa4Lq+JbN6W368n7XBOZygHaGpN9Br555Ir1ffwRDphx3jVejBsYpmJYGzMDfzv/8Dx2ugELZGF19WUsAMQnm4xjATysAM0Hoxy0Y+65nss2BuifvU0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562100386448688.2380803152922; Tue, 2 Jul 2019 13:46:26 -0700 (PDT) Received: from localhost ([::1]:57462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiPfV-0000I1-6y for importer@patchew.org; Tue, 02 Jul 2019 16:46:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44296) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiO2f-0006gT-KA for qemu-devel@nongnu.org; Tue, 02 Jul 2019 15:02:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiO2c-0006CG-ER for qemu-devel@nongnu.org; Tue, 02 Jul 2019 15:02:11 -0400 Received: from mga06.intel.com ([134.134.136.31]:4377) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hiO2b-0005cm-Nl for qemu-devel@nongnu.org; Tue, 02 Jul 2019 15:02:10 -0400 Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jul 2019 12:01:38 -0700 Received: from juliomon-mobl1.zpn.intel.com (HELO fedora.zpn.intel.com.) ([10.219.4.39]) by fmsmga008.fm.intel.com with ESMTP; 02 Jul 2019 12:01:37 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,444,1557212400"; d="scan'208";a="164115588" From: Julio Montes To: qemu-devel@nongnu.org Date: Tue, 2 Jul 2019 19:01:31 +0000 Message-Id: <20190702190131.5780-1-julio.montes@intel.com> X-Mailer: git-send-email 2.17.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.31 X-Mailman-Approved-At: Tue, 02 Jul 2019 16:29:23 -0400 Subject: [Qemu-devel] [PATCH] monitor: vnc: Fix compilation error if CONFIG_VNC is disable X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julio Montes , dgilbert@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" How to reproduce it? =3D=3D=3D ``` $ ./configure --disable-spice --disable-vte --disable-vnc \ --disable-vnc-jpeg --disable-vnc-png --disable-vnc-sasl $ make ... monitor/hmp-cmds.c: In function =E2=80=98hmp_change=E2=80=99: monitor/hmp-cmds.c:1985:17: error: unused variable =E2=80=98hmp_mon=E2=80= =99 [-Werror=3Dunused-variable] MonitorHMP *hmp_mon =3D container_of(mon, MonitorHMP, common); ``` Fix =3D=3D=3D Move `hmp_mon` variable within the `CONFIG_VNC` block Signed-off-by: Julio Montes --- monitor/hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 9de35387c3..5ed564683e 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -1982,7 +1982,6 @@ static void hmp_change_read_arg(void *opaque, const c= har *password, =20 void hmp_change(Monitor *mon, const QDict *qdict) { - MonitorHMP *hmp_mon =3D container_of(mon, MonitorHMP, common); const char *device =3D qdict_get_str(qdict, "device"); const char *target =3D qdict_get_str(qdict, "target"); const char *arg =3D qdict_get_try_str(qdict, "arg"); @@ -1991,6 +1990,7 @@ void hmp_change(Monitor *mon, const QDict *qdict) Error *err =3D NULL; =20 #ifdef CONFIG_VNC + MonitorHMP *hmp_mon =3D container_of(mon, MonitorHMP, common); if (strcmp(device, "vnc") =3D=3D 0) { if (read_only) { monitor_printf(mon, --=20 2.17.2