From nobody Sun May 19 08:26:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562092485; cv=none; d=zoho.com; s=zohoarc; b=nmzxw5e9wDV+sMAO2j44tuoOUHTNipj0JiSlhi8BzQNguDffcc8s94C5r34VjRmIio2voLyfzkj8ZNlX3Ny/YwIaBoHoNsfN2zhgRSpA7nGfZuh/UBy2CrnKN8LQiNtDcCXo63qUBK9McbDON7J/LG7fEwO/47VTOdXdXJDxdj4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562092485; h=Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=SueI7JkUCX7HWvANEFvGOrdzvOBL+SlIoaax6LVguVw=; b=DcfoDxkT0rulyKaz1bA9LW6+hBUtYdJNIYkjXSToA3XzFUTHrkHNDCgN8rae2tKvhPqU4LRNbp/kQJ1eB0Djc+URV1NH/J88jfMZMcEH7d8YRKixl4Vp+9FXUHGPEIkkmXlPMim65IO/k0KfANxvSJsx67vE7dgMCmEF/yYhLMo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562092485698907.0922234662536; Tue, 2 Jul 2019 11:34:45 -0700 (PDT) Received: from localhost ([::1]:56196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiNc1-0004YR-Jr for importer@patchew.org; Tue, 02 Jul 2019 14:34:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59629) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiMQK-0008Fg-Np for qemu-devel@nongnu.org; Tue, 02 Jul 2019 13:18:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiMQG-0003Qi-Ps for qemu-devel@nongnu.org; Tue, 02 Jul 2019 13:18:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50446) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hiMQG-0003OJ-6A for qemu-devel@nongnu.org; Tue, 02 Jul 2019 13:18:28 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C0E30308FC20; Tue, 2 Jul 2019 17:18:25 +0000 (UTC) Received: from laptop.redhat.com (ovpn-116-95.ams2.redhat.com [10.36.116.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 116511001B01; Tue, 2 Jul 2019 17:18:19 +0000 (UTC) From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, alex.williamson@redhat.com, peter.maydell@linaro.org Date: Tue, 2 Jul 2019 19:18:16 +0200 Message-Id: <20190702171816.11939-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Tue, 02 Jul 2019 17:18:25 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] vfio/pci: Trace vfio_set_irq_signaling() failure in vfio_msix_vector_release() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Report an error in case we fail to set a trigger action on any VFIO_PCI_MSIX_IRQ_INDEX subindex. This might be useful in debugging a device that is not working properly. Signed-off-by: Eric Auger Reviewed-by: Cornelia Huck --- hw/vfio/pci.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index ce3fe96efe..d7a4e1875c 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -551,9 +551,12 @@ static void vfio_msix_vector_release(PCIDevice *pdev, = unsigned int nr) */ if (vector->virq >=3D 0) { int32_t fd =3D event_notifier_get_fd(&vector->interrupt); + Error *err =3D NULL; =20 - vfio_set_irq_signaling(&vdev->vbasedev, VFIO_PCI_MSIX_IRQ_INDEX, n= r, - VFIO_IRQ_SET_ACTION_TRIGGER, fd, NULL); + if (vfio_set_irq_signaling(&vdev->vbasedev, VFIO_PCI_MSIX_IRQ_INDE= X, nr, + VFIO_IRQ_SET_ACTION_TRIGGER, fd, &err))= { + error_reportf_err(err, VFIO_MSG_PREFIX, vdev->vbasedev.name); + } } } =20 --=20 2.20.1