From nobody Sun May 19 10:38:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1562071399; cv=none; d=zoho.com; s=zohoarc; b=BWxz0ftOU+oorplll8RWQo+a6Fyp8k8KvyryWi+uX5Kkv+hqk3ctdAXZXdvT657MLbM+EHqoZbbI8eOZ+clc8RJsUbQNp/fsV5msvmK5oMxC31JGQ0Jy4l0JN504pafLZT3LfkkhfTivUgkG7rCa4GdZ1SM8QECDq1MA9tZraHo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562071399; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=pz+6WdBBZSOlSC/c8uiWDuWWcfRJ7RzjmzmKTbAHTr8=; b=lpAiI43UauSL9yGqUM7Fm5nhcM1NoxCH/6YVWJZ5MJ5tr8l9hkHdE/UdNDnqoO2CkF35ID4nvn3YtY3pj08FP7q3G+W1Iw2yFwkn1UtFpEFH1k1CucaN5Rf/+oSWG19cDP3FW1bi/tF0l7oJC08j7l+opK9Qt5W1ofyCgxFeNZY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562071399466120.19230487201696; Tue, 2 Jul 2019 05:43:19 -0700 (PDT) Received: from localhost ([::1]:53226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiI7w-0001Gn-SK for importer@patchew.org; Tue, 02 Jul 2019 08:43:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48748) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiI2H-0003yV-FD for qemu-devel@nongnu.org; Tue, 02 Jul 2019 08:37:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiI2E-0000dz-RD for qemu-devel@nongnu.org; Tue, 02 Jul 2019 08:37:25 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:42739) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiI2C-0000XI-CC; Tue, 02 Jul 2019 08:37:20 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N95mR-1idsBW2Q2Z-016AqN; Tue, 02 Jul 2019 14:37:17 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Tue, 2 Jul 2019 14:37:11 +0200 Message-Id: <20190702123713.14396-2-laurent@vivier.eu> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190702123713.14396-1-laurent@vivier.eu> References: <20190702123713.14396-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:MpVnjE9ILMkipRn4MKez3x505bdBBbNHNpT4QgWdLUuT25Bmqcz 8o0hcFfpRpjTJVFA/q8MlwlzJ03BZopcx4tsLhBhOFfds31VF3rrF9h/ktu/hczqiYV9JfB wFC9D7rxMB67waIEDZ18YqrSxp4a6GLfqcOXDzxKDv2dRXGEuBuSE4ebOaxxC2UN/tAC/07 nU5OcByicxxvBmlRTvmaw== X-UI-Out-Filterresults: notjunk:1;V03:K0:t2dAFxFol/E=:H8zjlW6jT2n6hR5wCwK1Bv VVoZ9XSpXwBL5uXHAsd/BTMVddGv3yRH+NoxeRW1vIRBmPp/ZN3rO8CnH6h/1bvGxBTj19flf cgVHaIk/bVrS1LhNuEr5UmBSHTELzBbAfZfd+eHpNzm9RtLJ4WxuoN1NrBwEyRbUoHgLy9i29 jTAjmCNRcjoXO/Y82d3Ui2GZ16vh4l0zxx5rNPHdM8bafjMlilRqUukg88VrqgUoW7WqbzQ+O UvzB0WaTNxBrSZtxXYgRPEB8szMjKSAkmaFpD3yPx89K3ukAeKQ71A1HEApmEAkE/X+OhVjla QCyBp5ntDoyXhucCE8CsA6XvfibE3/n88PqyBMkyx7qvnXxAYko9iIUPBkepKppDSrrtco/DX CpCP3qnexDW4rul+IIQOKDf4UBC+kajeXXU9W60yeTzmbhqe2zRhlUaT3s1bqAUDmkAHfhPF2 1DT2vlLLyJpUy3RC5qT7Ixn3E+VunqFbp7PydsIIj6zl9SaapREKPm4eFlDVEiw0Z1RW7aoF/ ChLVbBAeSg5o54qWjItactAhFYRAN7WstovCcnXu359vvWA/pIh+Oe59ZoZK1DYPLo1AZGlLq MMG821E4EEYmWbg5rnG+ukddTI8xF+W0ap7sV0gCYGyDB8hHjGPxxotq0cS9/v7DsYP/KbmD+ 5UhlpByXFI0Lw5Ux/z0bvwfyLy/ujOBqghw3WZkKiwcZnjuly7YuFwFA5+pAwfyJJfxXuulX4 ktF18A/Rowo1n9p6wpqtgP2u7h24HjFznwW6vQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.133 Subject: [Qemu-devel] [PULL 1/3] Fix cacheline detection on FreeBSD/powerpc. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Justin Hibbits , Amit Shah Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Justin Hibbits machdep.cacheline_size is an integer, not a long. Since PowerPC is big-endian this causes sysctlbyname() to fill in the upper bits of the argument, rather than the correct 'lower bits' of the word. Specify the correct type to fix this. Fixes: b255b2c8a548 ("util: add cacheinfo") Signed-off-by: Justin Hibbits Reviewed-by: Laurent Vivier Message-Id: <20190607135653.6ece685d@titan.knownspace> Signed-off-by: Laurent Vivier --- util/cacheinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/cacheinfo.c b/util/cacheinfo.c index eebe1ce9c5d2..516f837748a3 100644 --- a/util/cacheinfo.c +++ b/util/cacheinfo.c @@ -77,7 +77,7 @@ static void sys_cache_info(int *isize, int *dsize) static void sys_cache_info(int *isize, int *dsize) { /* There's only a single sysctl for both I/D cache line sizes. */ - long size; + int size; size_t len =3D sizeof(size); if (!sysctlbyname(SYSCTL_CACHELINE_NAME, &size, &len, NULL, 0)) { *isize =3D *dsize =3D size; --=20 2.21.0 From nobody Sun May 19 10:38:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1562071546; cv=none; d=zoho.com; s=zohoarc; b=jZG4Va0FVr+5YrWS4mjbyIf/GhCyNWAS/iPntWJV6G1jt6BD+ZqI2WisvIWeG4xpXBAdNG0G/WEfCZ7t9qr4TQtvX3LZMQ4io23DwlmggGtHAzkVExipCV1dr1zw+tZlVB6HVb0G6Onm2beobTumZ7EjQ//SX10ekQVvu0PKIpQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562071546; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=iwFAPZ2l1R+58yR25FJ4SJAYFQJcDeqMlXXMpucEHHs=; b=TRLOtBrlzk3gE+HJWAeSoBZYqx+5pNZgRVaW+tlU8R6IHOWnxRrAUUtpHoL+7XTVhcAIJ9HUzH0NGDuosrwpoEbaiccI/+339PhUUJO/bG7ucsG8wbbBkWUoXj4fVGVW5/9OFrp2NJIX1bWt1mCufnBofO+eipL3uwdmD/Smmrw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562071546429854.5898200987094; Tue, 2 Jul 2019 05:45:46 -0700 (PDT) Received: from localhost ([::1]:53254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiIAL-0003xG-Be for importer@patchew.org; Tue, 02 Jul 2019 08:45:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49001) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiI31-0004lQ-A0 for qemu-devel@nongnu.org; Tue, 02 Jul 2019 08:38:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiI2z-0001bK-C5 for qemu-devel@nongnu.org; Tue, 02 Jul 2019 08:38:11 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:48663) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiI2x-0001XU-I6; Tue, 02 Jul 2019 08:38:09 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N3sZs-1ihzKA1p8i-00zriC; Tue, 02 Jul 2019 14:37:18 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Tue, 2 Jul 2019 14:37:12 +0200 Message-Id: <20190702123713.14396-3-laurent@vivier.eu> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190702123713.14396-1-laurent@vivier.eu> References: <20190702123713.14396-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:1fJWR8t1SpO4AXdBUiKTVkC1hTdcQ/ZgZ8ezmEUn/fuXp9VRann G9VGhGu1va2qXoL4Nv12IsyUZFrrophVaVJYYoQvTUI4WfE+/sEQBgfApnw4iufH3qWcBQI U0tluDr99IP3KXMuXi4QS3VIGEGztov0fo8mp0BrTFSYKxSnnGJFq650xha7rNOONbboyFx /u2/esoDiYdDEBD7alYCg== X-UI-Out-Filterresults: notjunk:1;V03:K0:V465oCSTkvE=:JJuAnpaG8iTh7p5d12IYZB q57K/yWlEUZCnWTvn5PSWP+BvS+bJ/BA6rwqxdWzPQJZYMumNgYJHBlCnfRRlnM0UKAles480 LfUttKtSIcZ2Bo/rPnvKFD8Ian7RG5bRynsemCKiCj01E+9dEstF0gRoXmeEupSnc5SB/Lm1z 66WSlZ+R6LkPPxOvLjvTC1CHJsyuJsLt0YjgPgtVWnN6WCX7YaohznLDclvLwzD9KS/Kf+w2Y JP1hCyjr2l6k+uNDTMksxxcQ7ff1kAirz0lxg728HaxhrsP32hpSNrlW32ZpjdPQrcbeln4Vg 3WH2Uvl6iIWGhzobKRZrS+TOljApDc8LAmoer01kKFttlNrPNOM86vt/7w/eKi2Fmcrhz/TZr pGqNhRl6rcUsUZ0/iWHZVscEsulaWEGg7IMQtcp3MFWlC1hveiiYnz+3Rpcz0rldHAB/WBJqk El54HYqJDzdh+20MIRT+WUdWA1YvGQH8pEoJo8yn3aQSDVr6DsZj27/0MVaZ/vqYlyQ/4sWKQ DiIwsK8B8BQaRPNDPSGRW10nbnqqvoSS/oVphod3WjDm6Qr7CNOj2AZyMS8HYs9B8AkZuaR2C UBdbUP8a/gp0wq4XIHUVzpyBWr6X+AR1zRW+VXoySN6Unl2GxjXn8VI+xq2vElSL79jo0rhVl ADDsny6r6bFljjVuEzxIMSxfHfYv2jasTXYPDVNHCwi36MzASqmTBt0KVEXfhaxCz0eFnomIE LRTjCPAYNmfDQ3Tgt0HHD1xiEWOJTIjwbCXc3/4UqGtz1/OCKodjsYrMGvo= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.133 Subject: [Qemu-devel] [PULL 2/3] VirtIO-RNG: Update default entropy source to `/dev/urandom` X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Kashyap Chamarthy , qemu-trivial@nongnu.org, Amit Shah , Michael Tokarev , Laurent Vivier , Markus Armbruster , Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Kashyap Chamarthy When QEMU exposes a VirtIO-RNG device to the guest, that device needs a source of entropy, and that source needs to be "non-blocking", like `/dev/urandom`. However, currently QEMU defaults to the problematic `/dev/random`, which on Linux is "blocking" (as in, it waits until sufficient entropy is available). Why prefer `/dev/urandom` over `/dev/random`? Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Markus Armbruster Reviewed-by: Stefan Hajnoczi --------------------------------------------- The man pages of urandom(4) and random(4) state: "The /dev/random device is a legacy interface which dates back to a time where the cryptographic primitives used in the implementation of /dev/urandom were not widely trusted. It will return random bytes only within the estimated number of bits of fresh noise in the entropy pool, blocking if necessary. /dev/random is suitable for applications that need high quality randomness, and can afford indeterminate delays." Further, the "Usage" section of the said man pages state: "The /dev/random interface is considered a legacy interface, and /dev/urandom is preferred and sufficient in all use cases, with the exception of applications which require randomness during early boot time; for these applications, getrandom(2) must be used instead, because it will block until the entropy pool is initialized. "If a seed file is saved across reboots as recommended below (all major Linux distributions have done this since 2000 at least), the output is cryptographically secure against attackers without local root access as soon as it is reloaded in the boot sequence, and perfectly adequate for network encryption session keys. Since reads from /dev/random may block, users will usually want to open it in nonblocking mode (or perform a read with timeout), and provide some sort of user notification if the desired entropy is not immediately available." And refer to random(7) for a comparison of `/dev/random` and `/dev/urandom`. What about other OSes? ---------------------- `/dev/urandom` exists and works on OS-X, FreeBSD, DragonFlyBSD, NetBSD and OpenBSD, which cover all the non-Linux platforms we explicitly support, aside from Windows. On Windows `/dev/random` doesn't work either so we don't regress. This is actually another argument in favour of using the newly proposed 'rng-builtin' backend by default, as that will work on Windows. - - - Given the above, change the entropy source for VirtIO-RNG device to `/dev/urandom`. Related discussion in these[1][2] past threads. [1] https://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg08335.html -- "RNG: Any reason QEMU doesn't default to `/dev/urandom`?" [2] https://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg02724.html -- "[RFC] Virtio RNG: Consider changing the default entropy source to /dev/urandom" Signed-off-by: Kashyap Chamarthy Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Laurent Vivier Message-Id: <20190529143106.11789-2-lvivier@redhat.com> Signed-off-by: Laurent Vivier --- backends/rng-random.c | 2 +- qemu-options.hx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/backends/rng-random.c b/backends/rng-random.c index aa5b9285f04d..a81058139330 100644 --- a/backends/rng-random.c +++ b/backends/rng-random.c @@ -113,7 +113,7 @@ static void rng_random_init(Object *obj) rng_random_set_filename, NULL); =20 - s->filename =3D g_strdup("/dev/random"); + s->filename =3D g_strdup("/dev/urandom"); s->fd =3D -1; } =20 diff --git a/qemu-options.hx b/qemu-options.hx index 0d8beb4afdef..2aae19b0f925 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -4328,7 +4328,7 @@ Creates a random number generator backend which obtai= ns entropy from a device on the host. The @option{id} parameter is a unique ID that will be used to reference this entropy backend from the @option{virtio-rng} device. The @option{filename} parameter specifies which file to obtain -entropy from and if omitted defaults to @option{/dev/random}. +entropy from and if omitted defaults to @option{/dev/urandom}. =20 @item -object rng-egd,id=3D@var{id},chardev=3D@var{chardevid} =20 --=20 2.21.0 From nobody Sun May 19 10:38:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1562071229; cv=none; d=zoho.com; s=zohoarc; b=XxC0sgI3AlWuwSlOYdMxrlr+jsgriALm9sgElKqv3qseQDFPacRAocN+coGRMKJAV/TyaKv3N6MzWb9VqQZyzUFGBwKZkQTsF9dF4L4ezh9w3floWVKLPNMJyphbzJThYUmplJ+EKYizP0l/4Z6TVfbK9OigSpgebMfpmxi6TJk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562071229; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=D+m7xVdBvDEoZ8mA/slyC1uvqhj26XZgJ5yG0pMBe3I=; b=mtwJQqWzJ0yxGnm3Auw6AKZABV38dVVqcR656jtrCD8fFsCVNFBov8LJ4eD4DpIj3RsHWIurOW+lOuM9f7euC+fFawhrZcdtIU9dRQasWvdE3rPNQKCn/ixmoKZuMmlWk3ChetvSN+Xi2Ht6seQBijnkHvs3K0h4O82MEYhFITU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562071229177327.96316117660126; Tue, 2 Jul 2019 05:40:29 -0700 (PDT) Received: from localhost ([::1]:53182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiI5E-0006Nd-8H for importer@patchew.org; Tue, 02 Jul 2019 08:40:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48837) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiI2d-0004NE-Vq for qemu-devel@nongnu.org; Tue, 02 Jul 2019 08:37:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiI2c-00019E-Vj for qemu-devel@nongnu.org; Tue, 02 Jul 2019 08:37:47 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:55995) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiI2c-00017Z-MV; Tue, 02 Jul 2019 08:37:46 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mk0FM-1iOFXz1Nt2-00kOCG; Tue, 02 Jul 2019 14:37:19 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Tue, 2 Jul 2019 14:37:13 +0200 Message-Id: <20190702123713.14396-4-laurent@vivier.eu> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190702123713.14396-1-laurent@vivier.eu> References: <20190702123713.14396-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:9PslG9qvap87WaFplIbd2STu9GAhpSP8ANYNJ4shBWiGv+wOd4O STm01u3/YmHoYBJwEDo1HqxVQVrAelxIaQTWuFpAdBfvdoG8WPFR69CPXZPRwo4xPPZRB3h 7QZwx4WarMFj0D18dsOPc/3LVc/lk/Yt1EWz/DqBgJpQe3knG5Sv5PJzq1RhKm8t+b1vUJx K3wmwi7U9j5puFtg7qAuQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:BePkrgQo824=:8Jy12W+JcWNeh1u4MElEGT cg4TY6KAWzJo2E7mNkrEkivBI/JDzPyiV9ClcAGL/iX9WygwGKuepG+cLDY9x0UxeqhMhZIMX cqgMmJfYzG0SWzLVk1XZMmUzx+iaF+ToNxaPcvc2oQY9PabHDYWzdoPUCq96SFk5yA8ebJh9i 3DCAEp6a54NoEuxFF2QqrQ1GaXM2vZa0e+/ftsqRKSBSrCnX4ztFEgDy2WV6h7S3C2di+K8Ub kItfgYcAgKd27FISGWAXUnTSsviyySHWr0KdsqtPSRx2dMRKXM+l1ovVncwbJ+L+QcSQh7SJR ljJWYNGpL3d7h/SP1LDPkeSIOmz1X/VXkVsU8+ImlQJpLSGmOoBPK/FfRwTt5axEcqK78CyuD LBiVbYs07WPiO/Y2mGW3QZJBJFaFud9Fkws3sBExGFF7lCA5R+jQ9MspuEljP5EO/Ry2dWCq1 5GlTrie3HqlSQ13MFuWNTam4KKo/nAg2bQce+SHnbfZeCLoi9naezdnPO2uX++xhkI+0Tj9+P 0RkMEUdlQVr6f52Q/1JBVsOZoLLhrD9Pa1HqqKqke4i/Uop/cwM6PUYqV5tGmi/PQyD3FrRkS SFx8Lg0b5x+CvzOv8j7YVCr0bGSno2qD5R96Z1fucbjcniO8yO1MzFFLo5lm1jbUqnM+a9nBU uXC9I0NJ2HxjEls0edDbeS7j2cB3NhDnRI5FStERm1jROsT8n2zS+0XkVuXxyPzfYoLJXQz8H gHdqg9m8DdP3LY+IP+UIO7ASoBjIbDSvuROhlJUMsHkbcavGNquuDc4HU+0= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.135 Subject: [Qemu-devel] [PULL 3/3] docs/devel/testing: Fix typo in dockerfile path X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , Amit Shah , qemu-trivial@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Liam Merwick Signed-off-by: Liam Merwick Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Li Qiang Message-Id: <1561727317-30655-1-git-send-email-liam.merwick@oracle.com> Signed-off-by: Laurent Vivier --- docs/devel/testing.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index da2d0fc9646f..3ef50a61db4d 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -327,7 +327,7 @@ Images ------ =20 Along with many other images, the ``min-glib`` image is defined in a Docke= rfile -in ``tests/docker/dockefiles/``, called ``min-glib.docker``. ``make docker= `` +in ``tests/docker/dockerfiles/``, called ``min-glib.docker``. ``make docke= r`` command will list all the available images. =20 To add a new image, simply create a new ``.docker`` file under the --=20 2.21.0