From nobody Sun May 19 10:57:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1562066361; cv=none; d=zoho.com; s=zohoarc; b=RIyUpd5ZZfyJbME9HJ8UXpiwwFXcSPnxMQnMHSmifuBWY3MPsQV26GWDU84+hZn+iLiWvSpBp6DNrnh7UQa8p2U0atWJ6vUpuLMQU5s8IT9Ur7GDR9shOaOWKGQUZyNe3xNqz/htkovI8awSPp/VGEH1go0dnLEbIDm8JbK8GoY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562066361; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=YeHRPGYbA8ZhQrAnDrwK7ooN6IkOvQIyHvP1gjf9j24=; b=CcxN7cDKjckzUlQrS/sTswGsi8BdxojI0wqdhhwWAjRcUy5L0AVpKXQDIlQ7oog/y+SxwllNyQwGgiY5+knIRUgDczrP1v64qX8l7IPO7Yal6H1av1J7bPmCa7a3UB+p4OVJvCuCKhiS55N6yE65cAfHL2EYqAlLKGoymdJ9nIU= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562066361675373.8809466543172; Tue, 2 Jul 2019 04:19:21 -0700 (PDT) Received: from localhost ([::1]:51758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiGoX-0001Os-EU for importer@patchew.org; Tue, 02 Jul 2019 07:19:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51625) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiGNj-0000op-3R for qemu-devel@nongnu.org; Tue, 02 Jul 2019 06:51:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiGNf-00057t-0M for qemu-devel@nongnu.org; Tue, 02 Jul 2019 06:51:25 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:35841) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiGNd-00050p-J3 for qemu-devel@nongnu.org; Tue, 02 Jul 2019 06:51:22 -0400 Received: by mail-wm1-x341.google.com with SMTP id u8so475524wmm.1 for ; Tue, 02 Jul 2019 03:51:17 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id y133sm3219710wmg.5.2019.07.02.03.51.16 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 02 Jul 2019 03:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YeHRPGYbA8ZhQrAnDrwK7ooN6IkOvQIyHvP1gjf9j24=; b=XGibDmxUDYjPiY8630ypUeh1Crjc7UzuBDzvEKoKarSVnT3IAtcUkUHxSd9Od+mgtB pgFAJTfbO5ZkErOkyp8CBKFk9FTjYVUSh//kvs1yfqH6Wa4X/plg2xI+s7TzC6AKtbKB 0+wn/h81QKma2XTRKwbHrKknQ6y2d+qnvGim+wwVKUp5NsjB0dX0ps6f1dkR24f2ypw/ +GB1N/2Xxf0xOZkonrgOxya4ZkInOULEq7hPQmmcg/rNd4WxZ++AQek1ygJqe16hdXeU Xu33olZV2/h84RQUz9oapdyWnbwcbMge+7OZcimc4IsOBYl5yOlVC7uSEufq/hmGonrC Ie0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YeHRPGYbA8ZhQrAnDrwK7ooN6IkOvQIyHvP1gjf9j24=; b=UQCP2PzSqhcg4tDHZX0zLITC74WCxqkCcPU8yMLmXzEGkU1QekcJqs7HfaOa5YLDN2 6AL8fMzLvPdTkm27aX0vs+nBkaoON3c7rP0XartCMOv7qakM+IE3Hk+s6oYUOQGBb+D+ 0/+D26djuq9fYo00qVlu0IKty3WjxpuOc2DdN1wZ5cz4VYGFDX4m9VNxW4QwzcYxUnyJ JKBj2umBF55nUf9hCiOzCiJM4Ywc/qeXPUf0uJsPz7oKEbBvNH0+2PvvNMfNtsGFf5JH Pl3EggNZd/9LSAUxR11CP3m48QpwLkMmZ0h7TB/0liUF9sPiALYjdWmojY4vabPR3rS5 AtLg== X-Gm-Message-State: APjAAAUWrTLtakUichyz5LyTHRQs1I65WUPwqaV6qe8HlwhcfpAZBk+a kk1cul8pel/deiKCCt7QIwUvzg== X-Google-Smtp-Source: APXvYqzpZ4Avo86PZIZjJLNygWa0F8atpP1UqT+Y3Ok2r5mWSpOQDIOL4sbSgtX8P2tJFFZfGF63fg== X-Received: by 2002:a1c:dc45:: with SMTP id t66mr3193545wmg.63.1562064677072; Tue, 02 Jul 2019 03:51:17 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Tue, 2 Jul 2019 11:51:15 +0100 Message-Id: <20190702105115.9465-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PATCH for-4.1] target/arm: Correct VMOV_imm_dp handling of short vectors X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Coverity points out (CID 1402195) that the loop in trans_VMOV_imm_dp() that iterates over the destination registers in a short-vector VMOV accidentally throws away the returned updated register number from vfp_advance_dreg(). Add the missing assignment. (We got this correct in trans_VMOV_imm_sp().) Fixes: 18cf951af9a27ae573a Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/translate-vfp.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/translate-vfp.inc.c b/target/arm/translate-vfp.inc.c index deaddb04421..092eb5ec53d 100644 --- a/target/arm/translate-vfp.inc.c +++ b/target/arm/translate-vfp.inc.c @@ -1971,7 +1971,7 @@ static bool trans_VMOV_imm_dp(DisasContext *s, arg_VM= OV_imm_dp *a) =20 /* Set up the operands for the next iteration */ veclen--; - vfp_advance_dreg(vd, delta_d); + vd =3D vfp_advance_dreg(vd, delta_d); } =20 tcg_temp_free_i64(fd); --=20 2.20.1