From nobody Mon Feb 9 18:45:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1562048245; cv=none; d=zoho.com; s=zohoarc; b=GZjX0up5X5ogHbt+vtHHyF2DWFVvKBeZaUYmQuvV6dm/38DjVd0+af/pXvIK9XqauKvtI2FA0A1ctMVS4X1vfUbNRrKZTaeLLxS4qyO41NS2MftVcCHkg+iElGStya/NVUqZUd2/o9diux2JQyasrKhd4k26HpvRdCyMKaRAb0I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562048245; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=kZVs4TmEJvtxR1Id/HQLL7CT9VBkAonbe5dDjj8sqos=; b=Tv7SfJ32bTe2ssC4Imev2uG6E6qETdqweAmS7hcRuyoAWV2nzxfv8e12S26gGbN/YKyoh3dri7wcsOo4NBbJWzW6gRIBMjd/P+Rlc+eXw/0udHukaZd/uUPDR3DEO0S8GACcU5Gs5V5ltPMheK4D47bpvkcPvuEJXG1Cy0nzsZg= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562048232407906.1900499628789; Mon, 1 Jul 2019 23:17:12 -0700 (PDT) Received: from localhost ([::1]:49396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiC6H-00020V-JL for importer@patchew.org; Tue, 02 Jul 2019 02:17:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58177) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiByd-0004iT-IX for qemu-devel@nongnu.org; Tue, 02 Jul 2019 02:09:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiByc-0002o3-7q for qemu-devel@nongnu.org; Tue, 02 Jul 2019 02:09:15 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:44041 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hiByb-0002k0-Ij; Tue, 02 Jul 2019 02:09:14 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 45dDMg2sxjz9sPG; Tue, 2 Jul 2019 16:09:03 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1562047743; bh=S50G9zcN5W0terqyxreSlcCaApbINZ0R7OPFquHstlU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=frpIoVu9cU8nsU7gcsWmWS4s+f0H5xJPO1pswLvB989eRvUffnQcWsvcUu1oIJrHQ tCrA2WtB+MdBReqoalzrIvNslHjgDOc8mnh3jXW5gaDcjJ/qoXllpj0evgXa8v6aDQ EGOx5OTrdYvmGwCYC7ntbEoSJHW5/Zr9LQkB2qxg= From: David Gibson To: peter.maydell@linaro.org Date: Tue, 2 Jul 2019 16:08:12 +1000 Message-Id: <20190702060857.3926-5-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190702060857.3926-1-david@gibson.dropbear.id.au> References: <20190702060857.3926-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 04/49] ppc/pnv: fix XSCOM MMIO base address for P9 machines with multiple chips X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson , rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: C=C3=A9dric Le Goater The PNV_XSCOM_BASE and PNV_XSCOM_SIZE macros are specific to POWER8 and they are used when the device tree is populated and the MMIO region created, even for POWER9 chips. This is not too much of a problem today because we don't have important devices on the second chip, but we might have oneday (PHBs). Fix by using the appropriate macros in case of P9. Signed-off-by: C=C3=A9dric Le Goater Message-Id: <20190612174345.9799-2-clg@kaod.org> Signed-off-by: David Gibson --- hw/ppc/pnv.c | 24 ++++++++++++++++-------- hw/ppc/pnv_xscom.c | 17 ++++++++++++----- include/hw/ppc/pnv.h | 3 +++ include/hw/ppc/pnv_xscom.h | 2 +- 4 files changed, 32 insertions(+), 14 deletions(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 9db43916ac..0d98a281f6 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -860,6 +860,14 @@ static void pnv_chip_power8_realize(DeviceState *dev, = Error **errp) Pnv8Psi *psi8 =3D &chip8->psi; Error *local_err =3D NULL; =20 + /* XSCOM bridge is first */ + pnv_xscom_realize(chip, PNV_XSCOM_SIZE, &local_err); + if (local_err) { + error_propagate(errp, local_err); + return; + } + sysbus_mmio_map(SYS_BUS_DEVICE(chip), 0, PNV_XSCOM_BASE(chip)); + pcc->parent_realize(dev, &local_err); if (local_err) { error_propagate(errp, local_err); @@ -1024,6 +1032,14 @@ static void pnv_chip_power9_realize(DeviceState *dev= , Error **errp) Pnv9Psi *psi9 =3D &chip9->psi; Error *local_err =3D NULL; =20 + /* XSCOM bridge is first */ + pnv_xscom_realize(chip, PNV9_XSCOM_SIZE, &local_err); + if (local_err) { + error_propagate(errp, local_err); + return; + } + sysbus_mmio_map(SYS_BUS_DEVICE(chip), 0, PNV9_XSCOM_BASE(chip)); + pcc->parent_realize(dev, &local_err); if (local_err) { error_propagate(errp, local_err); @@ -1206,14 +1222,6 @@ static void pnv_chip_realize(DeviceState *dev, Error= **errp) PnvChip *chip =3D PNV_CHIP(dev); Error *error =3D NULL; =20 - /* XSCOM bridge */ - pnv_xscom_realize(chip, &error); - if (error) { - error_propagate(errp, error); - return; - } - sysbus_mmio_map(SYS_BUS_DEVICE(chip), 0, PNV_XSCOM_BASE(chip)); - /* Cores */ pnv_chip_core_realize(chip, &error); if (error) { diff --git a/hw/ppc/pnv_xscom.c b/hw/ppc/pnv_xscom.c index 4e52885c9e..2b81c75f56 100644 --- a/hw/ppc/pnv_xscom.c +++ b/hw/ppc/pnv_xscom.c @@ -213,17 +213,17 @@ const MemoryRegionOps pnv_xscom_ops =3D { .endianness =3D DEVICE_BIG_ENDIAN, }; =20 -void pnv_xscom_realize(PnvChip *chip, Error **errp) +void pnv_xscom_realize(PnvChip *chip, uint64_t size, Error **errp) { SysBusDevice *sbd =3D SYS_BUS_DEVICE(chip); char *name; =20 name =3D g_strdup_printf("xscom-%x", chip->chip_id); memory_region_init_io(&chip->xscom_mmio, OBJECT(chip), &pnv_xscom_ops, - chip, name, PNV_XSCOM_SIZE); + chip, name, size); sysbus_init_mmio(sbd, &chip->xscom_mmio); =20 - memory_region_init(&chip->xscom, OBJECT(chip), name, PNV_XSCOM_SIZE); + memory_region_init(&chip->xscom, OBJECT(chip), name, size); address_space_init(&chip->xscom_as, &chip->xscom, name); g_free(name); } @@ -265,12 +265,19 @@ static const char compat_p9[] =3D "ibm,power9-xscom\0= ibm,xscom"; =20 int pnv_dt_xscom(PnvChip *chip, void *fdt, int root_offset) { - uint64_t reg[] =3D { cpu_to_be64(PNV_XSCOM_BASE(chip)), - cpu_to_be64(PNV_XSCOM_SIZE) }; + uint64_t reg[2]; int xscom_offset; ForeachPopulateArgs args; char *name; =20 + if (pnv_chip_is_power9(chip)) { + reg[0] =3D cpu_to_be64(PNV9_XSCOM_BASE(chip)); + reg[1] =3D cpu_to_be64(PNV9_XSCOM_SIZE); + } else { + reg[0] =3D cpu_to_be64(PNV_XSCOM_BASE(chip)); + reg[1] =3D cpu_to_be64(PNV_XSCOM_SIZE); + } + name =3D g_strdup_printf("xscom@%" PRIx64, be64_to_cpu(reg[0])); xscom_offset =3D fdt_add_subnode(fdt, root_offset, name); _FDT(xscom_offset); diff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h index fc4678f757..01ac9e7996 100644 --- a/include/hw/ppc/pnv.h +++ b/include/hw/ppc/pnv.h @@ -256,4 +256,7 @@ void pnv_bmc_powerdown(IPMIBmc *bmc); #define PNV9_PSIHB_ESB_SIZE 0x0000000000010000ull #define PNV9_PSIHB_ESB_BASE(chip) PNV9_CHIP_BASE(chip, 0x00060302031c00= 00ull) =20 +#define PNV9_XSCOM_SIZE 0x0000000400000000ull +#define PNV9_XSCOM_BASE(chip) PNV9_CHIP_BASE(chip, 0x00603fc0000000= 0ull) + #endif /* PPC_PNV_H */ diff --git a/include/hw/ppc/pnv_xscom.h b/include/hw/ppc/pnv_xscom.h index c842d950d2..67641ed278 100644 --- a/include/hw/ppc/pnv_xscom.h +++ b/include/hw/ppc/pnv_xscom.h @@ -87,7 +87,7 @@ typedef struct PnvXScomInterfaceClass { #define PNV9_XSCOM_XIVE_BASE 0x5013000 #define PNV9_XSCOM_XIVE_SIZE 0x300 =20 -extern void pnv_xscom_realize(PnvChip *chip, Error **errp); +extern void pnv_xscom_realize(PnvChip *chip, uint64_t size, Error **errp); extern int pnv_dt_xscom(PnvChip *chip, void *fdt, int offset); =20 extern void pnv_xscom_add_subregion(PnvChip *chip, hwaddr offset, --=20 2.21.0