From nobody Mon Feb 9 20:13:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1562047949; cv=none; d=zoho.com; s=zohoarc; b=MDpYljHNGHpvsr+kKYi+rC94XHFdNroiN1EAEochxzICcbNNkPzyyzm00L2v23HSSKUwMHf8GKwosq+GYxuCGjJ3LkyD06Fzwv3B68W72+vvNOpWp0+ftWFXfMJ+r3K94+YSC0f7Yp//FpI7nQ4WS6LwRUJNb+mP9tneixuY/nQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562047949; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=RMHCkI/PywcQkIo8JJvi+ogN6paaJn5cc73ObhldJf8=; b=gzuwIG4jbXxY5aUnwaWJD2hEOApKBpP9EOhC7kzVB5by/S1L6HXXHBscxezZ2IW5qCQTuI8wzSTCCP7TQsygCoGZ8S2RSuFymyXvd3K6jM5Pnzfwi4BRjjza4240QvAtipJHoQfMwRMQ9v/727G34+tROoc8J2rotgma8Ea85k8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562047935880668.9268456207303; Mon, 1 Jul 2019 23:12:15 -0700 (PDT) Received: from localhost ([::1]:49372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiC1Q-00075R-LG for importer@patchew.org; Tue, 02 Jul 2019 02:12:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58228) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiByf-0004lQ-AS for qemu-devel@nongnu.org; Tue, 02 Jul 2019 02:09:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiBye-0002pF-8O for qemu-devel@nongnu.org; Tue, 02 Jul 2019 02:09:17 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:50719 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hiByd-0002nQ-Rp; Tue, 02 Jul 2019 02:09:16 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 45dDMg3j0kz9sPF; Tue, 2 Jul 2019 16:09:03 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1562047743; bh=b9zd/dpZ/t8tuh+qwvM4HZcNs6C7W3R28XR9WEYPM+Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pxGQlCjf+dPLye5IymXssP231KDkmOBH7JOFyG8JGL+cQ0rWa2D7tE4PBtIaVYXte WdsxOngO2FYYtbh73eU28+QNgu9iqdBavSjYTQJge/8ZmMHFgZbp7ynVSIFggxO5ah rxShILQJ4QMwOxFp02dOUFMWFmJXuaV1NJgPu3Oc= From: David Gibson To: peter.maydell@linaro.org Date: Tue, 2 Jul 2019 16:08:11 +1000 Message-Id: <20190702060857.3926-4-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190702060857.3926-1-david@gibson.dropbear.id.au> References: <20190702060857.3926-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 03/49] ppc/pnv: fix StoreEOI activation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson , rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: C=C3=A9dric Le Goater The firmware (skiboot) of the PowerNV machines can configure the XIVE interrupt controller to activate StoreEOI on the ESB pages of the interrupts. This feature lets software do an EOI with a store instead of a load. It is not activated today on P9 for rare race condition issues but it should be on future processors. Nevertheless, QEMU has a model for StoreEOI which can be used today by experimental firmwares. But, the use of object_property_set_int() in the PnvXive model is incorrect and crashes QEMU. Replace it with a direct access to the ESB flags of the XiveSource object modeling the internal sources of the interrupt controller. Signed-off-by: C=C3=A9dric Le Goater Message-Id: <20190612162357.29566-1-clg@kaod.org> Signed-off-by: David Gibson --- hw/intc/pnv_xive.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/intc/pnv_xive.c b/hw/intc/pnv_xive.c index a55c2bbc88..9ab77feee9 100644 --- a/hw/intc/pnv_xive.c +++ b/hw/intc/pnv_xive.c @@ -781,8 +781,7 @@ static void pnv_xive_ic_reg_write(void *opaque, hwaddr = offset, * support recently though) */ if (val & (VC_SBC_CONF_CPLX_CIST | VC_SBC_CONF_CIST_BOTH)) { - object_property_set_int(OBJECT(&xive->ipi_source), - XIVE_SRC_STORE_EOI, "flags", &error_fa= tal); + xive->ipi_source.esb_flags |=3D XIVE_SRC_STORE_EOI; } break; =20 --=20 2.21.0