From nobody Tue Feb 10 04:07:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1562048476; cv=none; d=zoho.com; s=zohoarc; b=cu/KA5hy4ZiiMzS4RVP2tT9lsu/HClT+BJbjyeS2degTRb6STRzNqafRXODCrjULJ9A+fNHp48O25FyW4NLmVRL+4v+P49C5EY9qJ9cD79yCuZNFWKTtMx8FhM2Qk/Ge4B8gTVJe8FosYlcmxIxaOHAI9i0vQRb/tmrf7NIx4SU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562048476; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=5wO/hf6KoG3UtNS5/+qyn7xikaMq+Gx2rdSBq1lWyjY=; b=WFa1hUrabInkJ7zbqjUzSbyCk9ntCZCTyH+TwVXyvKUPU/4x2pV+aO8IqSbO3Lm7Y5E3h0OxmSPPzG775L2RpSI5aeZwsf9OpsrZk/o2dVOcIAuS0oHuIhN6rN8VeC/TWVQMnFId0xiT3PZ2U0yV1dcPkKXz+e3WPKAcWBEbsmY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562048460295761.2837869464845; Mon, 1 Jul 2019 23:21:00 -0700 (PDT) Received: from localhost ([::1]:49426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiC9u-0005aE-Rd for importer@patchew.org; Tue, 02 Jul 2019 02:20:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58383) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiByj-0004w1-MR for qemu-devel@nongnu.org; Tue, 02 Jul 2019 02:09:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiByi-0002uF-As for qemu-devel@nongnu.org; Tue, 02 Jul 2019 02:09:21 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:51465 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hiByh-0002pT-Js; Tue, 02 Jul 2019 02:09:20 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 45dDMh6Mv9z9sPZ; Tue, 2 Jul 2019 16:09:03 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1562047744; bh=GxG5T4mAzmDQk9JNvDaF99IBjK7p6c67pWLzMujSZMw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oB2v3oqtRK2X5T+RwGJ6e2VOB2p6owaKm7v3HVAGGWgYLrL4odFjtHP/H216ocgyk Vkrb1jO4Ee/uMnXnqkr6R4m3Q8ZxORYOjpIQj8BBO4L82clVKXjwKTmDoFXLEHXwRd cpEo+QMCawZ5NIe0Ykn8JHR4UgwZMy+s/Rw+Akx4= From: David Gibson To: peter.maydell@linaro.org Date: Tue, 2 Jul 2019 16:08:21 +1000 Message-Id: <20190702060857.3926-14-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190702060857.3926-1-david@gibson.dropbear.id.au> References: <20190702060857.3926-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 13/49] target/ppc: remove getVSR()/putVSR() from mem_helper.c X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, aik@ozlabs.ru, Richard Henderson , Mark Cave-Ayland , qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson , rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Mark Cave-Ayland Since commit 8a14d31b00 "target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order" functions getVSR() and putVSR() which u= sed to convert the VSR registers into host endian order are no longer required. Signed-off-by: Mark Cave-Ayland Message-Id: <20190616123751.781-3-mark.cave-ayland@ilande.co.uk> Reviewed-by: Richard Henderson Signed-off-by: David Gibson --- target/ppc/mem_helper.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c index 5b0f9ee50d..87632ccf53 100644 --- a/target/ppc/mem_helper.c +++ b/target/ppc/mem_helper.c @@ -417,26 +417,27 @@ STVE(stvewx, cpu_stl_data_ra, bswap32, u32) void helper_##name(CPUPPCState *env, target_ulong addr, \ target_ulong xt_num, target_ulong rb) \ { \ - int i; \ - ppc_vsr_t xt; \ + ppc_vsr_t *xt =3D &env->vsr[xt_num]; \ + ppc_vsr_t t; \ uint64_t nb =3D GET_NB(rb); \ + int i; \ \ - xt.s128 =3D int128_zero(); \ + t.s128 =3D int128_zero(); \ if (nb) { \ nb =3D (nb >=3D 16) ? 16 : nb; = \ if (msr_le && !lj) { \ for (i =3D 16; i > 16 - nb; i--) { \ - xt.VsrB(i - 1) =3D cpu_ldub_data_ra(env, addr, GETPC()); \ + t.VsrB(i - 1) =3D cpu_ldub_data_ra(env, addr, GETPC()); \ addr =3D addr_add(env, addr, 1); \ } \ } else { \ for (i =3D 0; i < nb; i++) { \ - xt.VsrB(i) =3D cpu_ldub_data_ra(env, addr, GETPC()); \ + t.VsrB(i) =3D cpu_ldub_data_ra(env, addr, GETPC()); \ addr =3D addr_add(env, addr, 1); \ } \ } \ } \ - putVSR(xt_num, &xt, env); \ + *xt =3D t; \ } =20 VSX_LXVL(lxvl, 0) @@ -447,23 +448,23 @@ VSX_LXVL(lxvll, 1) void helper_##name(CPUPPCState *env, target_ulong addr, \ target_ulong xt_num, target_ulong rb) \ { \ - int i; \ - ppc_vsr_t xt; \ + ppc_vsr_t *xt =3D &env->vsr[xt_num]; \ target_ulong nb =3D GET_NB(rb); \ + int i; \ \ if (!nb) { \ return; \ } \ - getVSR(xt_num, &xt, env); \ + \ nb =3D (nb >=3D 16) ? 16 : nb; \ if (msr_le && !lj) { \ for (i =3D 16; i > 16 - nb; i--) { \ - cpu_stb_data_ra(env, addr, xt.VsrB(i - 1), GETPC()); \ + cpu_stb_data_ra(env, addr, xt->VsrB(i - 1), GETPC()); \ addr =3D addr_add(env, addr, 1); \ } \ } else { \ for (i =3D 0; i < nb; i++) { \ - cpu_stb_data_ra(env, addr, xt.VsrB(i), GETPC()); \ + cpu_stb_data_ra(env, addr, xt->VsrB(i), GETPC()); \ addr =3D addr_add(env, addr, 1); \ } \ } \ --=20 2.21.0