From nobody Mon Feb 9 07:56:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562038461; cv=none; d=zoho.com; s=zohoarc; b=mafogdlaiH6GI+IKz2H5KpvRZ+fpw45FHQhdYaOLcWZBhBEowe+7tFOImeyvu/1rT2Yu9f9dvIautlaKuY5SfBGzuvzy+ISensVD6g9j36Gn7hDxBbbxUgpuaukzuJdsYT4gdfj9Q52wlkjAZxhvMiDrdChHsqhlXDIrqsKwiws= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562038461; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=jYVppR1z2jUA6d1+CUnQlo0laX4Sps9mA0AdOvNC+yA=; b=Or2wTEE8PRfg25ZKK0YovmZDjOxC8lXZzP3TuEpod96Dy8apcxsH+g9ih8AywtVDYDf6g5WbapwrGdpO6uGyXT3GKIwJNKl9Cnxsp8KGWxbv8JAQ+Al7KshpvyUfdDfn9+uRc0wjkuTE1QWyIowbRNWYFAuJvvPqYSfyiDH3qeA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562038461873841.3505854463721; Mon, 1 Jul 2019 20:34:21 -0700 (PDT) Received: from localhost ([::1]:48066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hi9Yi-0005ZB-Nd for importer@patchew.org; Mon, 01 Jul 2019 23:34:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35483) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hi7DK-0003cI-Mk for qemu-devel@nongnu.org; Mon, 01 Jul 2019 21:04:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hi7DI-00046E-22 for qemu-devel@nongnu.org; Mon, 01 Jul 2019 21:04:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33208) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hi7D2-0002Bj-0t; Mon, 01 Jul 2019 21:03:49 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DE73B308C395; Tue, 2 Jul 2019 01:01:49 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-21.brq.redhat.com [10.40.204.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 218531001B2D; Tue, 2 Jul 2019 01:01:45 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Date: Mon, 1 Jul 2019 21:59:12 -0300 Message-Id: <20190702005912.15905-28-philmd@redhat.com> In-Reply-To: <20190702005912.15905-1-philmd@redhat.com> References: <20190702005912.15905-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Tue, 02 Jul 2019 01:01:49 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 27/27] hw/block/pflash_cfi02: Reduce I/O accesses to 16-bit X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Laurent Vivier , Thomas Huth , Stephen Checkoway , qemu-block@nongnu.org, Max Reitz , Alistair Francis , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Parallel NOR flashes are limited to 16-bit bus accesses. Remove the 32-bit dead code. Reviewed-by: Alistair Francis Message-Id: <20190627202719.17739-29-philmd@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/block/pflash_cfi02.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c index 83084b9d72..5392290c72 100644 --- a/hw/block/pflash_cfi02.c +++ b/hw/block/pflash_cfi02.c @@ -317,8 +317,6 @@ static uint64_t pflash_read(void *opaque, hwaddr offset= , unsigned int width) boff =3D offset & 0xFF; if (pfl->width =3D=3D 2) { boff =3D boff >> 1; - } else if (pfl->width =3D=3D 4) { - boff =3D boff >> 2; } switch (pfl->cmd) { default: @@ -449,8 +447,6 @@ static void pflash_write(void *opaque, hwaddr offset, u= int64_t value, boff =3D offset; if (pfl->width =3D=3D 2) { boff =3D boff >> 1; - } else if (pfl->width =3D=3D 4) { - boff =3D boff >> 2; } /* Only the least-significant 11 bits are used in most cases. */ boff &=3D 0x7FF; @@ -710,6 +706,7 @@ static void pflash_write(void *opaque, hwaddr offset, u= int64_t value, static const MemoryRegionOps pflash_cfi02_ops =3D { .read =3D pflash_read, .write =3D pflash_write, + .impl.max_access_size =3D 2, .valid.min_access_size =3D 1, .valid.max_access_size =3D 4, .endianness =3D DEVICE_NATIVE_ENDIAN, --=20 2.20.1