From nobody Tue Nov 11 04:56:29 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561973958; cv=none; d=zoho.com; s=zohoarc; b=X5leYkXVkovRI+a3YVnuZUuDTJ8nOv8eMsWDgfXDbHpK3caYcJg5PPpytg1BY6hFB34BvUIsB1Se25sMNLGCuAT/hACzUsavZUFCHZyYtGdl4YZvXQkahvGw/kuLQ10kahqzIK8UZB6T8nn9hLWBy9aIrYYFSLzaBooLKnH2sFg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561973958; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=19SIfXORG8YqIOH0n+CjUrcRgKw9ikRCvTr7pih/Br8=; b=S5M+HrTjrpVu4kysmXTZWdFsgelSzswa0/yWXQyEhY7lzjQ39B8U8WsiIV4bf+mN/n9/P10nK1cJnSLyLjn6TCYgLzaeuHj2WJiFHaZs4Jwo/SZM3yfnArsA4nTIdPc4hvzFGDERbjTRFscVGv6UCYkbbZyF1w8VuBJYQegj9OA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561973958581406.2319638636051; Mon, 1 Jul 2019 02:39:18 -0700 (PDT) Received: from localhost ([::1]:56494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhsmL-0008Qx-Kq for importer@patchew.org; Mon, 01 Jul 2019 05:39:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50352) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhsiI-0003ah-B9 for qemu-devel@nongnu.org; Mon, 01 Jul 2019 05:35:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhsiD-0003T8-Am for qemu-devel@nongnu.org; Mon, 01 Jul 2019 05:35:04 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:37003) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hhsiD-0003SD-5Q for qemu-devel@nongnu.org; Mon, 01 Jul 2019 05:35:01 -0400 Received: by mail-qt1-f193.google.com with SMTP id y57so13899313qtk.4 for ; Mon, 01 Jul 2019 02:35:00 -0700 (PDT) Received: from redhat.com ([37.26.146.159]) by smtp.gmail.com with ESMTPSA id j22sm4512839qtp.0.2019.07.01.02.34.57 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 01 Jul 2019 02:34:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:in-reply-to; bh=19SIfXORG8YqIOH0n+CjUrcRgKw9ikRCvTr7pih/Br8=; b=sFu+eY1d75cMl0CR8jdaZrQ1ngkKkpl1jxMbxvc6V//hik8jZMfCOcw8nG2z+MHCP6 YmM4dmzXdlx5gfCVYuWuxQpXgzHD9VkqobrBmEQtfbgB+glGRltASGmN9dAHch5fswv7 mxc8ZHmkJ29tZy9Kvhkt+cNytoJdgc3R47DKyaMcr1D9QKrq9IWFGB+vBJ3SRCpP4egk Yfy/aLbHYHEmRO4nJkFm0t/mBpgUCTx5RZWd2On9ixYcK7L5el+ZtmrrE4zEcMTfvQX6 dYVMdnZt9zCDijR27IG/VAqdCyXO7/Hyv362C2CA+gUiLSI1wRK4C75P9Vg/eX9oL6Lt RX/w== X-Gm-Message-State: APjAAAXB2uWmuVv6N7e2hLlBUGOp+IOUTHdqZ08e7suBM54Jw3tQ9qEp Hg7M6iATafwg/2nB0oBqfTPuy14vDkMkWw== X-Google-Smtp-Source: APXvYqzO5Gh9d6TZ5b5CxDDD/WOERZmv7mJr0B77y1BfvKTusRRWppLmJJIFYymdwBqVQpEEHIq/Fw== X-Received: by 2002:aed:3a24:: with SMTP id n33mr19094772qte.361.1561973700050; Mon, 01 Jul 2019 02:35:00 -0700 (PDT) Date: Mon, 1 Jul 2019 05:34:54 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Message-ID: <20190701093232.28575-1-mst@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190621064615.20099-1-mst@redhat.com> X-Mailer: git-send-email 2.17.1.1206.gb667731e2e.dirty X-Mutt-Fcc: =sent X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.160.193 Subject: [Qemu-devel] [PATCH 4/3] pcie: minor cleanups for slot control/status X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mammedov Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename function arguments to make intent clearer. Better documentation for slot control logic. Suggested-by: Igor Mammedov Signed-off-by: Michael S. Tsirkin Reviewed-by: Christophe de Dinechin Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/pci/pcie.h | 3 ++- hw/pci/pcie.c | 17 +++++++++++------ 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/include/hw/pci/pcie.h b/include/hw/pci/pcie.h index 8d90c0e193..34f277735c 100644 --- a/include/hw/pci/pcie.h +++ b/include/hw/pci/pcie.h @@ -108,7 +108,8 @@ void pcie_cap_lnkctl_reset(PCIDevice *dev); void pcie_cap_slot_init(PCIDevice *dev, uint16_t slot); void pcie_cap_slot_reset(PCIDevice *dev); void pcie_cap_slot_get(PCIDevice *dev, uint16_t *slot_ctl, uint16_t *slt_s= ta); -void pcie_cap_slot_write_config(PCIDevice *dev, uint16_t slot_ctl, uint16_= t slt_sta, +void pcie_cap_slot_write_config(PCIDevice *dev, + uint16_t old_slot_ctl, uint16_t old_slt_st= a, uint32_t addr, uint32_t val, int len); int pcie_cap_slot_post_load(void *opaque, int version_id); void pcie_cap_slot_push_attention_button(PCIDevice *dev); diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index c605d32dd4..a6beb567bd 100644 --- a/hw/pci/pcie.c +++ b/hw/pci/pcie.c @@ -602,7 +602,8 @@ void pcie_cap_slot_get(PCIDevice *dev, uint16_t *slt_ct= l, uint16_t *slt_sta) *slt_sta =3D pci_get_word(exp_cap + PCI_EXP_SLTSTA); } =20 -void pcie_cap_slot_write_config(PCIDevice *dev, uint16_t slt_ctl, uint16_t= slt_sta, +void pcie_cap_slot_write_config(PCIDevice *dev, + uint16_t old_slt_ctl, uint16_t old_slt_sta, uint32_t addr, uint32_t val, int len) { uint32_t pos =3D dev->exp.exp_cap; @@ -625,8 +626,8 @@ void pcie_cap_slot_write_config(PCIDevice *dev, uint16_= t slt_ctl, uint16_t slt_s PCI_EXP_SLTSTA_MRLSC | PCI_EXP_SLTSTA_PDC | \ PCI_EXP_SLTSTA_CC) =20 - if (val & ~slt_sta & PCIE_SLOT_EVENTS) { - sltsta =3D (sltsta & ~PCIE_SLOT_EVENTS) | (slt_sta & PCIE_SLOT= _EVENTS); + if (val & ~old_slt_sta & PCIE_SLOT_EVENTS) { + sltsta =3D (sltsta & ~PCIE_SLOT_EVENTS) | (old_slt_sta & PCIE_= SLOT_EVENTS); pci_set_word(exp_cap + PCI_EXP_SLTSTA, sltsta); } hotplug_event_clear(dev); @@ -646,13 +647,17 @@ void pcie_cap_slot_write_config(PCIDevice *dev, uint1= 6_t slt_ctl, uint16_t slt_s } =20 /* - * If the slot is polulated, power indicator is off and power + * If the slot is populated, power indicator is off and power * controller is off, it is safe to detach the devices. + * + * Note: don't detach if condition was already true: + * this is a work around for guests that overwrite + * control of powered off slots before powering them on. */ if ((sltsta & PCI_EXP_SLTSTA_PDS) && (val & PCI_EXP_SLTCTL_PCC) && (val & PCI_EXP_SLTCTL_PIC_OFF) =3D=3D PCI_EXP_SLTCTL_PIC_OFF && - (!(slt_ctl & PCI_EXP_SLTCTL_PCC) || - (slt_ctl & PCI_EXP_SLTCTL_PIC_OFF) !=3D PCI_EXP_SLTCTL_PIC_OFF)) { + (!(old_slt_ctl & PCI_EXP_SLTCTL_PCC) || + (old_slt_ctl & PCI_EXP_SLTCTL_PIC_OFF) !=3D PCI_EXP_SLTCTL_PIC_OFF= )) { PCIBus *sec_bus =3D pci_bridge_get_sec_bus(PCI_BRIDGE(dev)); pci_for_each_device(sec_bus, pci_bus_num(sec_bus), pcie_unplug_device, NULL); --=20 MST