From nobody Tue Nov 11 04:57:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561715550; cv=none; d=zoho.com; s=zohoarc; b=GVDLhAv15hUM4ikMrjDgS4fc3Tb0npoPnsBsapZ5M5ANcZeuFdxdI/XTvEIywX8Dm1FiVIE7mo/xA+cCt/d8R+O2Z0KuQ9x+Pt4zt4CoEw2FKEYEYsk++PfmDtvGsnOnU0Eh+kuZo4/Mmv8MNJmdcw921lyHbQEW9V75hV+MFLw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561715550; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=SsvcEAW0t06WVQPcu4sx2zeBn18rO3BeXC43jvzi7SA=; b=FdkLrE2hPPsVO7+ZjXbDJEFmuo8qVDZFBTyOnvczLPvtY5HWsfjmTkP4lKVgIqxAVo4TjNevzIFXQkCn+E/DC5sIep0Kf7I1vhemeoYbQPi35mVhoVbCld8e3Z7Gnr6mnKZ1ELgf10WMKHWWSn0o3CS2J0RRhh4xyrO10rtAjtg= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 156171555047639.62861313381359; Fri, 28 Jun 2019 02:52:30 -0700 (PDT) Received: from localhost ([::1]:58346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgnYO-00047J-KA for importer@patchew.org; Fri, 28 Jun 2019 05:52:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50645) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgnXU-0003OQ-5p for qemu-devel@nongnu.org; Fri, 28 Jun 2019 05:51:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgnXT-0000BW-0D for qemu-devel@nongnu.org; Fri, 28 Jun 2019 05:51:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9136) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hgnXS-00009S-Je for qemu-devel@nongnu.org; Fri, 28 Jun 2019 05:51:26 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9FE712F8BEC; Fri, 28 Jun 2019 09:51:24 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-191.sin2.redhat.com [10.67.116.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 598E05B693; Fri, 28 Jun 2019 09:51:18 +0000 (UTC) From: P J P To: Qemu Developers Date: Fri, 28 Jun 2019 15:19:01 +0530 Message-Id: <20190628094901.13347-1-ppandit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 28 Jun 2019 09:51:24 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] qemu-bridge-helper: restrict bridge name to IFNAMSIZ X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Riccardo Schirone , "Daniel P . Berrange" , Prasad J Pandit Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Prasad J Pandit The interface names in qemu-bridge-helper are defined to be of size IFNAMSIZ(=3D16), including the terminating null('\0') byte. The same is applied to interface names read from 'bridge.conf' file to form ACLs rules. If user supplied '--br=3Dbridge' name is not restricted to the same length, it could lead to ACL bypass issue. Restrict bridge name to IFNAMSIZ, including null byte. Reported-by: Riccardo Schirone Signed-off-by: Prasad J Pandit --- qemu-bridge-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c index f9940deefd..2eca8c5cc4 100644 --- a/qemu-bridge-helper.c +++ b/qemu-bridge-helper.c @@ -246,7 +246,7 @@ int main(int argc, char **argv) if (strcmp(argv[index], "--use-vnet") =3D=3D 0) { use_vnet =3D 1; } else if (strncmp(argv[index], "--br=3D", 5) =3D=3D 0) { - bridge =3D &argv[index][5]; + bridge =3D strndup(&argv[index][5], IFNAMSIZ - 1); } else if (strncmp(argv[index], "--fd=3D", 5) =3D=3D 0) { unixfd =3D atoi(&argv[index][5]); } else { --=20 2.21.0