From nobody Sat Feb 7 08:45:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561681883; cv=none; d=zoho.com; s=zohoarc; b=Wp3f4u21JZ4OojjrB4J76oefsc6zF4XQiC5nOpXXnSsVLG6SKF3BBj+a413hw+jY6WuTu4LXcmC/iDsT+EkuMv3vstYKQjt0+23II9HgaWj4k8CdDBwM/cSwrZu3k3UtYsc3qLH0bw7+Y2m+5wHGHjJ5Vyl7O97hv4mZwO2H3ps= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561681883; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=cgkVZSWfECNRzqtYQcX/AfkT7CLjZRXysQNt/W3LYKU=; b=ZxVaI2CJ1cK0Ro5HAnmJKsVToG3iDjAkJgqGaydue+tG6i0JMhkRMlG7QLaAZgxWpYBiKwsOWNAIYqykmDatX8jhqrmpJiIv6uBqRNos3JPF2HihkkHLMjR9D3aPCpPmo+NuNXj7EZhoO2RYQPF/yk2MjErCeykFYGYj1GuoGuc= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561681883707874.0155069440833; Thu, 27 Jun 2019 17:31:23 -0700 (PDT) Received: from localhost ([::1]:55402 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgen7-0002C0-Ft for importer@patchew.org; Thu, 27 Jun 2019 20:31:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36225) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgel5-0008Q3-OA for qemu-devel@nongnu.org; Thu, 27 Jun 2019 20:28:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgel4-0006nl-SF for qemu-devel@nongnu.org; Thu, 27 Jun 2019 20:28:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40442) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hgel4-0006nI-Mu for qemu-devel@nongnu.org; Thu, 27 Jun 2019 20:28:54 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DFFA43DE0D for ; Fri, 28 Jun 2019 00:28:53 +0000 (UTC) Received: from localhost (ovpn-116-7.gru2.redhat.com [10.97.116.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 60F255D71D; Fri, 28 Jun 2019 00:28:53 +0000 (UTC) From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Thu, 27 Jun 2019 21:28:38 -0300 Message-Id: <20190628002844.24894-4-ehabkost@redhat.com> In-Reply-To: <20190628002844.24894-1-ehabkost@redhat.com> References: <20190628002844.24894-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 28 Jun 2019 00:28:54 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 3/9] i386: Get model-id from CPU object on "-cpu help" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mammedov , Jiri Denemark , "Daniel P. Berrange" , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When introducing versioned CPU models, the string at X86CPUDefinition::model_id might not be the model-id we'll really use. Instantiate a CPU object and check the model-id property on "-cpu help" Signed-off-by: Eduardo Habkost Reviewed-by: Daniel P. Berrang=C3=A9 --- (New patch, added to series in v2) --- target/i386/cpu.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 1bdb906e9f..49bf92d3f9 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -3766,18 +3766,28 @@ static GSList *get_sorted_cpu_model_list(void) return list; } =20 +static char *x86_cpu_class_get_model_id(X86CPUClass *xc) +{ + Object *obj =3D object_new(object_class_get_name(OBJECT_CLASS(xc))); + char *r =3D object_property_get_str(obj, "model-id", &error_abort); + object_unref(obj); + return r; +} + static void x86_cpu_list_entry(gpointer data, gpointer user_data) { ObjectClass *oc =3D data; X86CPUClass *cc =3D X86_CPU_CLASS(oc); char *name =3D x86_cpu_class_get_model_name(cc); - const char *desc =3D cc->model_description; - if (!desc && cc->cpu_def) { - desc =3D cc->cpu_def->model_id; + char *desc =3D g_strdup(cc->model_description); + + if (!desc) { + desc =3D x86_cpu_class_get_model_id(cc); } =20 qemu_printf("x86 %-20s %-48s\n", name, desc); g_free(name); + g_free(desc); } =20 /* list available CPU models and flags */ --=20 2.18.0.rc1.1.g3f1ff2140