From nobody Fri May 3 03:01:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561586068; cv=none; d=zoho.com; s=zohoarc; b=ZhrtIwDoUHIoLC/SmyiZmuBwnyCMkarR+icqy7bpe/fVpYcIdhyerPxmzVo5S06uXbueOs64PUU23aEI040I07ePpkJTOwXYa7OGnFhkoyKKYQU5XmushO3YQmkd6iCiKO/NCf2kuilaZKhZG6HxhjXR8/vTqggV2ijO/xy84ZI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561586068; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=noXiWd35TVCCjD8/A9QTlIbyV2RyWLwkl8Tt0lbwUzs=; b=HHXxrwjYfCPO6LanAR/S44OJh5ekVYWXCL2hlglYGhcvp2fLAZmjgo9GUA1MR8QqpsxFjmBMZWt4e4Qwk2kb1P9bVkjV7+zffbGo51Rg01hWu2TNjYEG7QyHi0C77AdEnJIzNTyjkxmwLGYejd8AADbdjKwCGJwDnUiSRoRD3gw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561586068986410.3724848394826; Wed, 26 Jun 2019 14:54:28 -0700 (PDT) Received: from localhost ([::1]:45088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgFs0-0003ua-07 for importer@patchew.org; Wed, 26 Jun 2019 17:54:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33627) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgFqn-0002wX-0L for qemu-devel@nongnu.org; Wed, 26 Jun 2019 17:53:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgFqm-00055Z-0M for qemu-devel@nongnu.org; Wed, 26 Jun 2019 17:53:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50964) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hgFqj-00052x-PZ; Wed, 26 Jun 2019 17:53:05 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B86F98553B; Wed, 26 Jun 2019 21:53:04 +0000 (UTC) Received: from probe.bos.redhat.com (dhcp-17-47.bos.redhat.com [10.18.17.47]) by smtp.corp.redhat.com (Postfix) with ESMTP id C6F601001E63; Wed, 26 Jun 2019 21:53:01 +0000 (UTC) From: John Snow To: qemu-block@nongnu.org, qemu-devel@nongnu.org Date: Wed, 26 Jun 2019 17:53:01 -0400 Message-Id: <20190626215301.30733-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 26 Jun 2019 21:53:04 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] block/qcow: Improve error when opening qcow2 files as qcow X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Qemu-Trivial , Kevin Wolf , radmehrsaeed7@gmail.com, John Snow , Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Reported-by: radmehrsaeed7@gmail.com Fixes: https://bugs.launchpad.net/bugs/1832914 Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Maxim Levitsky --- block/qcow.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/block/qcow.c b/block/qcow.c index 6dee5bb792..a9cb6ae0bd 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -156,7 +156,12 @@ static int qcow_open(BlockDriverState *bs, QDict *opti= ons, int flags, goto fail; } if (header.version !=3D QCOW_VERSION) { - error_setg(errp, "Unsupported qcow version %" PRIu32, header.versi= on); + error_setg(errp, "qcow (v%d) does not support qcow version %" PRIu= 32, + QCOW_VERSION, header.version); + if (header.version =3D=3D 2 || header.version =3D=3D 3) { + error_append_hint(errp, "Try the 'qcow2' driver instead."); + } + ret =3D -ENOTSUP; goto fail; } --=20 2.21.0