From nobody Sun May 5 00:50:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1561579536; cv=none; d=zoho.com; s=zohoarc; b=SveCBSWBEqMyyQOZ6PzPIWyh96UhucRdaGl0D4rnp+QNfu3o7Pj+I+sGc8r2WcB2Iz+eimL+PlRjbL/Gy3HRaHqb2l0qkzElZgCIm+SdnHcwk59Hv2FRPGIvTEG4v8O38hmrCADrHGGXJEYZYz1r7Cw/fsrVFf1mhDtG89RKnaY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561579536; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=YkrpaKEkx1UqPRMIkDiG7+8OUxgYe4GtWqwtLe+FFEk=; b=C+0K/UfLb3DUBptCmU5EcBT5mUgchdWYndPgxIzXikb8givJQ5iNgwBBDm/kVi3pt1KuDnKiRhH0G6dbG96MTL2yOVibifBwEg+Sbws4mjzx6Arv2SRPrz/gO86NtSDVZItrIer0h5bc24nKYyylmWKOba3h9OhxZJbTqUcGNac= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561579535845703.2794889533492; Wed, 26 Jun 2019 13:05:35 -0700 (PDT) Received: from localhost ([::1]:44678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgEAd-0000jX-FP for importer@patchew.org; Wed, 26 Jun 2019 16:05:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34994) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgE8e-0007n6-GP for qemu-devel@nongnu.org; Wed, 26 Jun 2019 16:03:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgE8d-0000z3-BV for qemu-devel@nongnu.org; Wed, 26 Jun 2019 16:03:28 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:38095) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgE8d-0000yS-2T; Wed, 26 Jun 2019 16:03:27 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MStKq-1i9KEJ1Vvi-00UM6S; Wed, 26 Jun 2019 22:02:57 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Wed, 26 Jun 2019 22:02:49 +0200 Message-Id: <20190626200252.30220-2-laurent@vivier.eu> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190626200252.30220-1-laurent@vivier.eu> References: <20190626200252.30220-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:VjQsvc3d06qk9A6m95K7upSTC3nFZciaQBjZZHSxsd0tChHc7DE oJNZCMn7zyS+gmIwOYnMjvpFnb8FdxY1/FmDVxmqE/kXPEEoZBc/lDkhBzpkTCdzPPVqSWL QV5l7Ck5eTblDtEXAH+E9tN61aZT1VmxQStVq/86GsvlJTu4dRt/Tczq+K2nzIQIAtOrF8a T1zgFrzMoU/ucERCixpYA== X-UI-Out-Filterresults: notjunk:1;V03:K0:6hxK8KwUclA=:Jy4o4P0WB88lpsBLkqddS5 59+OVsrcy2ea0ODCcoaSQvsLz+6KFbgKL3EH/GcX9dk1tjYaSwQMYCwYsyH0MmdjEsswoR/Wt eFEBPbp27XtBhhmrvmAIDabW0f4DY9TiFWyQUgKPt+xoRrgEZsRhkZUn26O6W3P7coD9g4yD2 zihb1Xt6i3XGK9jTud0hp0wAiChKJJU3/4jkHy9ouGQlE9uUSZqH9CME/pxaOvpU9riR3Ngjl +WFAHy77DA7KNpFUWNdgXncttTFiJUkzAAK+IcAUWKDIXWDjpq/O8IuI/7qXhcBzcsonovnb6 JQg0gCTzMuzionTqNo8DVRWP570RuzJJyShdvRawSg0oabWlAHO3Qg5nLUckokCuOBUSE61rW uFVyVi/I3sXI48s+0JbB4Q7IIvPHfFHV78CFSYmE4N+o+M6h+Xsq5TCQKC3p28OA4ANONKBkn 06EeofKpPKaoRQPmSGGCzlwt+N16dW7G8h2yPoZJqO7U7OxP8WF1VB8TFHU+e9yfLAkm77bsW t/ag3oe56Ydw9gsFMiv0I1CZHxSE3dFFNy4ZcJifIEnxiCwciXX2QRdXI20ZSJ5A1UWCtETvi mvIb+xnm9gdd5X5IzX0L2PBApMukUclyblHvosE/Z8t9vmBxuD7xFqMoA582BloHjmEIV+RG5 6d0AcqgHB7yXNpBNALfbvN81DVqD631IPMz0izHWIEB/9UzW9Hk+zo6SmUkV/gzauMcbGKcM9 zDJ6AGBKv88+CY5rxQwrYnqWqaZlGNmQi2eeew== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.24 Subject: [Qemu-devel] [PULL 1/4] configure: set source_path only once and make its definition more robust X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Antonio Ospite , Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Antonio Ospite Since commit 79d77bcd36 (configure: Remove --source-path option, 2019-04-29) source_path cannot be overridden anymore, move it out of the "default parameters" block since the word "default" may suggest that the value can change, while in fact it does not. While at it, only set source_path once and separate the positional argument of basename with "--" to more robustly cover the case of path names starting with a dash. Reviewed-by: Eric Blake Signed-off-by: Antonio Ospite Message-Id: <20190526144747.30019-2-ao2@ao2.it> Signed-off-by: Laurent Vivier --- configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index b091b82cb371..b6962d1381a5 100755 --- a/configure +++ b/configure @@ -276,10 +276,10 @@ ld_has() { $ld --help 2>/dev/null | grep ".$1" >/dev/null 2>&1 } =20 -# default parameters -source_path=3D$(dirname "$0") # make source path absolute -source_path=3D$(cd "$source_path"; pwd) +source_path=3D$(cd "$(dirname -- "$0")"; pwd) + +# default parameters cpu=3D"" iasl=3D"iasl" interp_prefix=3D"/usr/gnemul/qemu-%M" --=20 2.21.0 From nobody Sun May 5 00:50:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1561579693; cv=none; d=zoho.com; s=zohoarc; b=XZ8Q/6Ttpb210xmyqHzBT7+KlL05b6dlVsogwzWg9ImAPnenICPftfEiCyFJxJolYnBFbICVFm8uG3dqq7PLclBu+brmBL1R8Bv57kOBerW1dACzUdmqXiXExjq6WLhzKSVp+4A7ZTy2U3MJh6CwcuA4wNs4B/B9ZqlW9YWNWAE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561579693; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=6kDml/1qXZsREzVEzmwIlFjR5x5YIjABCux6pocyigk=; b=RgUkkT2m7w2EOuQy6qQ8AZUk3oUOVpITCcp/0tijIsivMQWGdWkuJrb9arJmhc4Qz0COyju8UdLPU6LrdIcATaZhhSggKTwakpR4ZZCpczCQKwWoI4vjDUS2JWGM3oi7dp79jHSBHLAjRVRe1Qcyr8FvF3QhCVb6FhVBTFsOM+I= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561579693129273.6853078191933; Wed, 26 Jun 2019 13:08:13 -0700 (PDT) Received: from localhost ([::1]:44700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgEDA-0003lF-W6 for importer@patchew.org; Wed, 26 Jun 2019 16:08:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35095) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgE8u-0007s5-Hw for qemu-devel@nongnu.org; Wed, 26 Jun 2019 16:03:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgE8t-00018f-9S for qemu-devel@nongnu.org; Wed, 26 Jun 2019 16:03:44 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:37915) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgE8r-000155-9p; Wed, 26 Jun 2019 16:03:43 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MTAJl-1i93784A5n-00UdDd; Wed, 26 Jun 2019 22:02:58 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Wed, 26 Jun 2019 22:02:50 +0200 Message-Id: <20190626200252.30220-3-laurent@vivier.eu> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190626200252.30220-1-laurent@vivier.eu> References: <20190626200252.30220-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:SDsrwGvhBVkJ1fQwnm9ExkGPbQNuyGaBfWIh6K97u5SFy6/iUwr 94CiJlMZk2roPrD9Zbmqnj9or6zVrBAgRX4XX24yvxM1W8ne5tesrQ93Sq+gOooixZGA9xg PbTjBFoouLcCFg015N6Iou2k6YKmnK18ESsgsuJsddlSQVMDsUidL3nZhYTtAfViE/qhe2f XAbpoj/jSJK6icLFJMAIg== X-UI-Out-Filterresults: notjunk:1;V03:K0:ktFOV5d8Jyg=:YxQAZ5bbj5BXviSveKSRrQ YxS/xcm955RkJztqm6GpN1DxR3x/+/SL+Fu8AGbpysdSxm4fn9mChqNdjMeDwoTd/ljncWCu/ WHqs6AxLtgayStqlMt7iVxBsf4m7M8WqmphdiTWHGq7RCsPyL0Vn6b9Z4b7GuQhTbwe4HlSFb VSNtWpfjr9Sc5Oq2aekTxWjeleBJNnlQLSTiVRn79v6K49f2SYkJ13skk5kwsRTvMZpUHiNkf vEqFYQLXXI8+vShpLzENNnVgTBAOaJpRaTFeWac7ArWXh4gWHsSrPCT+KfhZ3rU6l5CpwDgcu ZUgFdst0bw8QqDu0/nK60NEZNSM8CSfOBy/+eWiZmQH+uqkY12R6BMH8XC7yfXobS49D4j10x hpB8TmgkuCh7hRu8jxJ744TDGENa+GfTs+Qln14Gf31oGUksn0ZLLO91O13wvSnmM/SN+wWVv YEyG3t2cvUCf7PnxZUy6dmWL7pQoSnmq8ENgeqLHQUwNqS1witNtpStfFEN/wp9mylCkuo7dJ jjjmG0/rSHBMysBBEsiyi5VMXZ+hsWdzIYlKqsYsK1cyCm6Et1OmH42FDzyjjORmKq82g0uR+ 5M1uFbwZFQbHENbkVWRseRbGku9rhHp5dkdxkQ9HH0GTTp8ES14JZNVIQSmKQit+B1NANZtRd f/AWpomKYUe9v37+CL7yXSVhEg2xPA2yyq0PxeWHDJ5TK9V+N8EKngkZHqWqd7ERwYYX2V6Zv xNXSP6Jt2bEoSttAmTrahUrUqpzgIzpHoXrG6w== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.72.192.74 Subject: [Qemu-devel] [PULL 2/4] configure: disallow spaces and colons in source path and build path X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Antonio Ospite , Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Antonio Ospite The configure script breaks when the qemu source directory is in a path containing white spaces, in particular the list of targets is not correctly generated when calling "./configure --help" because of how the default_target_list variable is built. In addition to that, *building* qemu from a directory with spaces breaks some assumptions in the Makefiles, even if the original source path does not contain spaces like in the case of an out-of-tree build, or when symlinks are involved. To avoid these issues, refuse to run the configure script and the Makefile if there are spaces or colons in the source path or the build path, taking as inspiration what the kbuild system in linux does. Buglink: https://bugs.launchpad.net/qemu/+bug/1817345 Reviewed-by: Eric Blake Signed-off-by: Antonio Ospite Message-Id: <20190526144747.30019-3-ao2@ao2.it> Signed-off-by: Laurent Vivier --- Makefile | 4 ++++ configure | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/Makefile b/Makefile index cfb18f152544..c62594445d5f 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,9 @@ # Makefile for QEMU. =20 +ifneq ($(words $(subst :, ,$(CURDIR))), 1) + $(error main directory cannot contain spaces nor colons) +endif + # Always point to the root of the build tree (needs GNU make). BUILD_DIR=3D$(CURDIR) =20 diff --git a/configure b/configure index b6962d1381a5..cf3d9d30bfce 100755 --- a/configure +++ b/configure @@ -279,6 +279,11 @@ ld_has() { # make source path absolute source_path=3D$(cd "$(dirname -- "$0")"; pwd) =20 +if printf %s\\n "$source_path" "$PWD" | grep -q "[[:space:]:]"; +then + error_exit "main directory cannot contain spaces nor colons" +fi + # default parameters cpu=3D"" iasl=3D"iasl" --=20 2.21.0 From nobody Sun May 5 00:50:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1561579541; cv=none; d=zoho.com; s=zohoarc; b=Kep6xkw9/gmKyWvL+pPdrQGDHoklclNiPn9a6+mo4V84uZaKdvsCnKnaz+GzJMVlyrwPH43Daoe3T5hBp1wRNXe1soOTGNQF9GXynvuqsGlJv5JOWz43KNSAhFg3UtkHNGpZ6gtepsFyJSueEmWh3C4+HUhYFedqjE4LGYX48kc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561579541; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=kVHX/LfcCULttPSZAxonJT5qj+L1y6LOm+mxjtYglP4=; b=nk0zibNrL8fnsWfsOJK2NicQMee2tnAoIq57cQHN/+x4z0/rVfiirbVQqzdyuXf+PRwlX+PxIZO+0q2Cpazni9cR1c4y7/MKIUhdEY5UZGrQz8IOXsi7f+PtGBn+FCdrwf5F6xNtgH+rHMRa3Ee0hRVSIPPW3GSESNQJcJvLjmw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561579541207373.58235187151456; Wed, 26 Jun 2019 13:05:41 -0700 (PDT) Received: from localhost ([::1]:44680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgEAg-0000oa-3H for importer@patchew.org; Wed, 26 Jun 2019 16:05:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35077) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgE8t-0007ra-7H for qemu-devel@nongnu.org; Wed, 26 Jun 2019 16:03:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgE8l-00014N-P9 for qemu-devel@nongnu.org; Wed, 26 Jun 2019 16:03:41 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:47723) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgE8f-000101-Vw; Wed, 26 Jun 2019 16:03:31 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N2E9Y-1iiNzw2I74-013gr2; Wed, 26 Jun 2019 22:02:58 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Wed, 26 Jun 2019 22:02:51 +0200 Message-Id: <20190626200252.30220-4-laurent@vivier.eu> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190626200252.30220-1-laurent@vivier.eu> References: <20190626200252.30220-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:6Eu+HSQFiVFuj5n34n9byGYW1DCaRx0C6Pl2ex5KQhZc9CYgSTe 0diqwb6b7oHg+N/+QACDCwfGV1+stUC/IC+SLrgY8ICBDvo7hAw3qLqqm+ovvis7PpS/CaQ qYv/YFQo9SIhdYa1wtYUyU6HW+eSZXQENYYtQlCIvtVBdIC7HN98gu7ZqMoR718xzohyBn+ xcY/rbbv+lLxMdlXNfkWg== X-UI-Out-Filterresults: notjunk:1;V03:K0:hloth9wYqoM=:pPPx9cKo2Yenaqt0777Vpq UWJj3lSlH0jaJJf7fDFuHtAYAWe6dPH1iA8A5k2iZhvPJcI1NOVrcEg3HpbSuGncikAoZ8pkg 5cD4F1sGOvVCW4FkbR1Ujlk1lUNIs17VEbFB3tWoTNyC16E/KIBkySJTVUk50Gxs5WLnHJeew lOrvtV0kXZf5w08iKWBQeRPrtpDY7QpceFlOBX/TQvx0CCbsbK1U6de1YqSVH6HMhae/cjcSh XOwfze/juSUQBRzrXcLndtxlJ5apAuW2OwDmdDxPb696YXStEOWKG2d73/kQ2gayKuspbkKMt pbKFOdZvbfrBNvkxUzkTqdom88z0DkW8jBRIqy511hNt+C84WVl8lKQ6Yn/d0LWZqAw8e3lPn 8dhulLdem/VSFAQSUQEWbZkuuG7tLo8VIxxGg146CpzQWev/vBa9apFKbLsAPzO6G0Lmd8GHB 1TapaTsCM83R+aRc1ytKmY10Va8eE74hNoC1MxMhzp4Su8rlD3jRJQbNODmgpME26LP0OPvuH dsiHZTt9laimVKjnvUSTUbw1bZKuJB6XMJkI1U9ZIkG4aGoyR05Euiht/XeyxOADUba2jajvL FunGXnksfpOKd9yvvhhJRNWDBphSSiMqrxFOl+jHF+wdEDlWB3lu1UNbjTM54gahQ6xtgzwWl liM4WrvkJfJjhmu2qT1NEYw3g9ikltOk7XvrbMDtAuPfcDNRS9qtTpCcHzJ/p6b/fLtQLFrNl J8ZiC6fglB1RxaTAVAzXeoqKzxqpB2bUPOha0HDui+gnWalmPGfB82DTcmY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.72.192.73 Subject: [Qemu-devel] [PULL 3/4] configure: use valid args testing sem_timedwait X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Daniel P. Berrang=C3=A9 The sem_timedwait function has been annotated as requiring non-null args in latest header files from GCC snapshot representing the future 2.30 release. This causes configure to fail when -Werror is used: config-temp/qemu-conf.c: In function =E2=80=98main=E2=80=99: config-temp/qemu-conf.c:2:25: error: null argument where non-null required = (argument 1) [-Werror=3Dnonnull] 2 | int main(void) { return sem_timedwait(0, 0); } | ^~~~~~~~~~~~~ config-temp/qemu-conf.c:2:25: error: null argument where non-null required = (argument 2) [-Werror=3Dnonnull] Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Laurent Vivier Message-Id: <20190617114114.24897-1-berrange@redhat.com> Signed-off-by: Laurent Vivier --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index cf3d9d30bfce..f94633101094 100755 --- a/configure +++ b/configure @@ -5144,7 +5144,7 @@ fi sem_timedwait=3Dno cat > $TMPC << EOF #include -int main(void) { return sem_timedwait(0, 0); } +int main(void) { sem_t s; struct timespec t =3D {0}; return sem_timedwait(= &s, &t); } EOF if compile_prog "" "" ; then sem_timedwait=3Dyes --=20 2.21.0 From nobody Sun May 5 00:50:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1561579557; cv=none; d=zoho.com; s=zohoarc; b=MEK6nlmi76/5KTG3DULEiadBBhvvCE5fltR62Q4XzTx5clgd7nhV8Yml5fRyqB3IKXz4p2PrOP1cO9Ui+QLy2b1u9ETqhTc+70SgF5p/2g69eZV5WCvIuGZZsqyUhlM9E6a6YexAbUEeaPqq0V/dnrJDIYuiWM+BR6LmFY0Aw8Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561579557; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=hABe0qmY8ovg7EoRigrQhsEOTX7nFdVUf0XLDmRHDxU=; b=jerl+SE7BzT0fJwIbCYT37jVWnMBIrUonObVGhCRh6yXzhBifXxssnFMXe1/BPnFIUAJ+xTvOJGk57U0vOGcl5Rr179cyMv/mKF6ZXOKgKgASY7N6heZH/Qh1AbXGIqKIGTaawk6yhTrWhQeyN/uE76VS2GfxxnDG27bOdZrMK0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561579557469479.71828138862486; Wed, 26 Jun 2019 13:05:57 -0700 (PDT) Received: from localhost ([::1]:44682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgEAx-0001XR-N0 for importer@patchew.org; Wed, 26 Jun 2019 16:05:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35052) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgE8l-0007py-ON for qemu-devel@nongnu.org; Wed, 26 Jun 2019 16:03:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgE8j-00012z-QK for qemu-devel@nongnu.org; Wed, 26 Jun 2019 16:03:35 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:39059) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgE8h-00010g-Q1; Wed, 26 Jun 2019 16:03:32 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MUXlG-1i6afb2Boe-00QVok; Wed, 26 Jun 2019 22:02:59 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Wed, 26 Jun 2019 22:02:52 +0200 Message-Id: <20190626200252.30220-5-laurent@vivier.eu> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190626200252.30220-1-laurent@vivier.eu> References: <20190626200252.30220-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:cQo9I9915l39aZW5pN7DwI9aoDDmMMA4BAwJgMd9BUnEdo9A8ei ciZplMaFL5CA6vtmh0i/yOijbrPPPgBnkUO93gx/XH/47IWYLyJQLsfqTLXY0D29VE6avvr +AOS3sYPye/At0RQQQle1AfuOxj8aBeRFPlViRJMj4jkYDrhdIRK03nj3YRES4fNlxLfp+w IQFtatYWUFqnjw6Nv+W0A== X-UI-Out-Filterresults: notjunk:1;V03:K0:q2iA9gR+3js=:tMArK/VrQ5+N2hkljgr5sl ACoSz2Y4Dy2oMx7MzjhiYadF9QpO39PbstIkys6uSDih1nxLCDws7XE8X9WNGEOdCwdm/cp+o k3fZtQjuk0GTXgjBj40HrRgb1HcTcNpd9JsSjaI8KjeH9euVma2+zC/DTY6m+ctKRFiNFIezT UOxBIEKz8Sru1wROvSnRx8Mu+OZkPn1da1wHulvrTBJHyqgDq3tDAnp2B9ATlot/j5VJvocg2 6FDR4JiCrcavZAWoJPeCkBklgArIjjb9xl12PLT/P416osh78mhjvprpDm1T+Q6LHHYqecwwP HFwgQClWB3xBhCVRj+jwyGADMf1Jlr2EsWfaHjxHftO65OuUIY00bRXP097/D5500dll9EmGH ZqBAH68kSjmzy/+cpR+OkUlE8pWsmzsl+Vs+0rS3LUvIO+Np3803znF/9p0Tf8BlVp7vaV4ju 4D2qlA55HV6PC3Ttjafmc6reoiTdIDsW8N5igmxNioScIg/y88qYBdkshZTqDdgZIVZoazhtp 38LmoAu5QnHZZsz7uFFEmxY5wXQ6hYSCAt4YSa0Q6FZlJSpozyFysK3W2tdEi6BpWyAYZ+2EB 5Wi3LG63oWgY7fp6QB4d5sBN7jNyo/mJ0wcDQqAhSwUiCbeoZ2iOID6XCKX2rkhbm7EBVjFEX XeHEXivyMHturRK3Du/9JlSgqnpKbHuYs22ZU6+ewF8W/QxFg0Be4smXU6MX8v8KaL+CpA8DI zIi6DF+9+NJFrmADzxI8q7JP126rxBHxS62eskZvylIIHeYpTQuctQpICRM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.13 Subject: [Qemu-devel] [PULL 4/4] MAINTAINERS: Change maintership of Xen code under hw/9pfs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Greg Kurz , Paul Durrant , Anthony PERARD , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Greg Kurz Xen folks are the actual maintainers for this. Signed-off-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Anthony PERARD Acked-by: Paul Durrant Acked-by: Stefano Stabellini Message-Id: <155912548463.2019004.3515830305299809902.stgit@bahia.lan> Signed-off-by: Laurent Vivier --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index cad58b948791..8206fc51dbbc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -408,7 +408,7 @@ M: Paul Durrant L: xen-devel@lists.xenproject.org S: Supported F: */xen* -F: hw/9pfs/xen-9p-backend.c +F: hw/9pfs/xen-9p* F: hw/char/xen_console.c F: hw/display/xenfb.c F: hw/net/xen_nic.c @@ -1498,6 +1498,7 @@ virtio-9p M: Greg Kurz S: Supported F: hw/9pfs/ +X: hw/9pfs/xen-9p* F: fsdev/ F: tests/virtio-9p-test.c T: git https://github.com/gkurz/qemu.git 9p-next --=20 2.21.0