[Qemu-devel] [PATCH v4 0/5] virtio: fix some issues of "started" and "start_on_kick" flag

elohimes@gmail.com posted 5 patches 4 years, 9 months ago
Test checkpatch passed
Test s390x passed
Test asan passed
Test docker-mingw@fedora passed
Test FreeBSD passed
Test docker-clang@ubuntu passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190626023130.31315-1-xieyongji@baidu.com
Maintainers: Max Reitz <mreitz@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Kevin Wolf <kwolf@redhat.com>
hw/block/vhost-user-blk.c  |  4 +--
hw/core/machine.c          |  1 +
hw/virtio/virtio.c         | 53 ++++++++++++++++++++++----------------
include/hw/virtio/virtio.h | 23 ++++++++++++++++-
4 files changed, 56 insertions(+), 25 deletions(-)
[Qemu-devel] [PATCH v4 0/5] virtio: fix some issues of "started" and "start_on_kick" flag
Posted by elohimes@gmail.com 4 years, 9 months ago
From: Xie Yongji <xieyongji@baidu.com>

We introduced two flags "started" and "start_on_kick" to indicate virtio
device's state before. But there still are some problems with them. So
we try to fixup them in this patchset.

The patch 1 introduces a "use-started" property to avoid a migration
issue under Greg Kurz's suggestion [1].

The patch 2 set "start_on_kick" flag for legacy devices.

The patch 3 fixes a regression bug that old guest is not able to boot with
vhost-user-blk device.

The patch 4,5 fix some problems with "started" and "start_on_kick" flag.

[1] https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg06247.html

v4:
- Patch 1 is rebased on commit 8e8cbed09ad9d5 ("hw: Nuke hw_compat_4_0_1 and
  pc_compat_4_0_1")

v3:
- change the order of patches
- Also disable "use-started" property by hw_compat_4_0

v2:
- Recalculate "start_on_kick" flag after migration instead of migrating
  it
- Set "start_on_kick" flag for legacy devices
- Avoid setting "started" flag when "use_started" property is true
- Set "use_started" to false by hw_compat_4_0_1 instead of hw_compat_4_0

Xie Yongji (5):
  virtio: add "use-started" property
  virtio: Set "start_on_kick" for legacy devices
  virtio: Set "start_on_kick" on virtio_set_features()
  virtio: Make sure we get correct state of device on
    handle_aio_output()
  virtio: Don't change "started" flag on virtio_vmstate_change()

 hw/block/vhost-user-blk.c  |  4 +--
 hw/core/machine.c          |  1 +
 hw/virtio/virtio.c         | 53 ++++++++++++++++++++++----------------
 include/hw/virtio/virtio.h | 23 ++++++++++++++++-
 4 files changed, 56 insertions(+), 25 deletions(-)

-- 
2.17.1


Re: [Qemu-devel] [PATCH v4 0/5] virtio: fix some issues of "started" and "start_on_kick" flag
Posted by Laurent Vivier 4 years, 9 months ago
On 26/06/2019 04:31, elohimes@gmail.com wrote:
> From: Xie Yongji <xieyongji@baidu.com>

Could you use the same address to send the series?
Or may be you need to add a Signed-off-by with your name and this address?

I don't know what is the rule when someone send a patch with a different
address than the author one but he is the same person (it's not obvious
in this case).

Thanks,
Laurent

> 
> We introduced two flags "started" and "start_on_kick" to indicate virtio
> device's state before. But there still are some problems with them. So
> we try to fixup them in this patchset.
> 
> The patch 1 introduces a "use-started" property to avoid a migration
> issue under Greg Kurz's suggestion [1].
> 
> The patch 2 set "start_on_kick" flag for legacy devices.
> 
> The patch 3 fixes a regression bug that old guest is not able to boot with
> vhost-user-blk device.
> 
> The patch 4,5 fix some problems with "started" and "start_on_kick" flag.
> 
> [1] https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg06247.html
> 
> v4:
> - Patch 1 is rebased on commit 8e8cbed09ad9d5 ("hw: Nuke hw_compat_4_0_1 and
>   pc_compat_4_0_1")
> 
> v3:
> - change the order of patches
> - Also disable "use-started" property by hw_compat_4_0
> 
> v2:
> - Recalculate "start_on_kick" flag after migration instead of migrating
>   it
> - Set "start_on_kick" flag for legacy devices
> - Avoid setting "started" flag when "use_started" property is true
> - Set "use_started" to false by hw_compat_4_0_1 instead of hw_compat_4_0
> 
> Xie Yongji (5):
>   virtio: add "use-started" property
>   virtio: Set "start_on_kick" for legacy devices
>   virtio: Set "start_on_kick" on virtio_set_features()
>   virtio: Make sure we get correct state of device on
>     handle_aio_output()
>   virtio: Don't change "started" flag on virtio_vmstate_change()
> 
>  hw/block/vhost-user-blk.c  |  4 +--
>  hw/core/machine.c          |  1 +
>  hw/virtio/virtio.c         | 53 ++++++++++++++++++++++----------------
>  include/hw/virtio/virtio.h | 23 ++++++++++++++++-
>  4 files changed, 56 insertions(+), 25 deletions(-)
> 


Re: [Qemu-devel] [PATCH v4 0/5] virtio: fix some issues of "started" and "start_on_kick" flag
Posted by Yongji Xie 4 years, 9 months ago
On Wed, 26 Jun 2019 at 18:43, Laurent Vivier <lvivier@redhat.com> wrote:
>
> On 26/06/2019 04:31, elohimes@gmail.com wrote:
> > From: Xie Yongji <xieyongji@baidu.com>
>
> Could you use the same address to send the series?
> Or may be you need to add a Signed-off-by with your name and this address?
>
> I don't know what is the rule when someone send a patch with a different
> address than the author one but he is the same person (it's not obvious
> in this case).
>

Sorry for that, this two emails are both mine. The gmail is my
personal email, and I usually use it for the community works.

Thanks,
Yongji