From nobody Fri May 3 10:11:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561466918; cv=none; d=zoho.com; s=zohoarc; b=Z3/2Aji3DqQkRFa1ydn0tveUMmohO1U+5vm7H9JHGqm1lxqG2pf9MPFnjKeHqEYhuU58BEpaH4Z7Hlcp/Fw/WpC4z83d4OhjA/rLu5lkrPKb18X+v+aqLck666YcwTF/+e7oG4ngQ52pJrZ30QmdO9V00vxWu270HunbdfLYJa4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561466918; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=yK27eakzheCZDE9nOMOg/zR5FHMyLMDSZclm+gk3A3M=; b=cX9r5YoMyochq4MwCooCqQjsKx87xb1gak7XJfF41nnnnNSO0BwfVb8Lwr6fZFGilGQ6QWZulY9nsSEGqUaomoficyscCnT9IQSJaEfXopkAViCkhGMM3MPCho24euVMTf7Jxpl3hytUEgB9WFufp63s2L77+IDpZg/zTt2/Y3A= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561466918339182.95093409592903; Tue, 25 Jun 2019 05:48:38 -0700 (PDT) Received: from localhost ([::1]:59866 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfksE-0005Z4-62 for importer@patchew.org; Tue, 25 Jun 2019 08:48:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43777) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfkjA-0006IA-Be for qemu-devel@nongnu.org; Tue, 25 Jun 2019 08:39:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfkj9-0001gA-Al for qemu-devel@nongnu.org; Tue, 25 Jun 2019 08:39:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37104) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfkj9-0001fH-5K for qemu-devel@nongnu.org; Tue, 25 Jun 2019 08:39:11 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 331BAC049E23 for ; Tue, 25 Jun 2019 12:39:10 +0000 (UTC) Received: from turbo.com (unknown [10.36.118.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3A7595C22F; Tue, 25 Jun 2019 12:39:08 +0000 (UTC) From: Christophe de Dinechin To: qemu-devel@nongnu.org Date: Tue, 25 Jun 2019 14:39:05 +0200 Message-Id: <20190625123905.25434-1-dinechin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 25 Jun 2019 12:39:10 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2] Fix build error when VNC is configured out X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" In hmp_change(), the variable hmp_mon is only used by code under #ifdef CONFIG_VNC. This results in a build error when VNC is configured out with the default of treating warnings as errors: monitor/hmp-cmds.c: In function =E2=80=98hmp_change=E2=80=99: monitor/hmp-cmds.c:1946:17: error: unused variable =E2=80=98hmp_mon=E2=80= =99 [-Werror=3Dunused-variable] 1946 | MonitorHMP *hmp_mon =3D container_of(mon, MonitorHMP, common); | ^~~~~~~ v2: Move variable down as suggested by Philippe Mathieu-Daud=C3=A9 Signed-off-by: Christophe de Dinechin Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Stefano Garzarella --- monitor/hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index c283dde0e9..2ae784b9b8 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -1943,7 +1943,6 @@ static void hmp_change_read_arg(void *opaque, const c= har *password, =20 void hmp_change(Monitor *mon, const QDict *qdict) { - MonitorHMP *hmp_mon =3D container_of(mon, MonitorHMP, common); const char *device =3D qdict_get_str(qdict, "device"); const char *target =3D qdict_get_str(qdict, "target"); const char *arg =3D qdict_get_try_str(qdict, "arg"); @@ -1961,6 +1960,7 @@ void hmp_change(Monitor *mon, const QDict *qdict) if (strcmp(target, "passwd") =3D=3D 0 || strcmp(target, "password") =3D=3D 0) { if (!arg) { + MonitorHMP *hmp_mon =3D container_of(mon, MonitorHMP, comm= on); monitor_read_password(hmp_mon, hmp_change_read_arg, NULL); return; } --=20 2.21.0