From nobody Mon Feb 9 09:22:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561368065; cv=none; d=zoho.com; s=zohoarc; b=KVG/HJIS+i0DHDRAxbxXcySAPH/3hQY5dnyHdQUPPydz0UXVmaG21g3JR8eBgUJ98mlKQMTKl2bAf7Yl0X3UBzZH7PB8xNoeuzgv3/LHD7prPj5ehgngxcrdzrPzH+MkgLSw1T8dSZmeBFxQVpc9aAGXhVNh80MmI5fnPAjGqJ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561368065; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Vg29Xwugh6rlTMJZbFL7wTKXmqcaIZpnaMvJwQtQtEs=; b=TBqb2U2r90VG92D50wd0uckto5M9War+XR7Xj6vMl6yc8hQxncR333pjZHNILANyK3pkpxxTTKVrSM5nFO0Dl7cntdzyFu4vBfrR99rLd8Cv+aGFt/c8SDJLRawhvspVY6s4hxVBOLley/LYLvgsf3vrdKfCw13Vpfkw0Q+cBSM= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561368065319833.0340420839747; Mon, 24 Jun 2019 02:21:05 -0700 (PDT) Received: from localhost ([::1]:49020 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfL9k-0000yI-5J for importer@patchew.org; Mon, 24 Jun 2019 05:20:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53428) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfL7W-0007uu-Qm for qemu-devel@nongnu.org; Mon, 24 Jun 2019 05:18:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfL7U-0003b3-AM for qemu-devel@nongnu.org; Mon, 24 Jun 2019 05:18:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46248) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfL7U-0003Qq-3n for qemu-devel@nongnu.org; Mon, 24 Jun 2019 05:18:36 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A7E1E308FC4D; Mon, 24 Jun 2019 09:18:29 +0000 (UTC) Received: from xz-x1.redhat.com (ovpn-12-60.pek2.redhat.com [10.72.12.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id B4A975C1B5; Mon, 24 Jun 2019 09:18:24 +0000 (UTC) From: Peter Xu To: qemu-devel@nongnu.org Date: Mon, 24 Jun 2019 17:18:10 +0800 Message-Id: <20190624091811.30412-2-peterx@redhat.com> In-Reply-To: <20190624091811.30412-1-peterx@redhat.com> References: <20190624091811.30412-1-peterx@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Mon, 24 Jun 2019 09:18:29 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 1/2] intel_iommu: Fix incorrect "end" for vtd_address_space_unmap X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Zhao , "Michael S . Tsirkin" , Jason Wang , peterx@redhat.com, Auger Eric , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Yan Zhao IOMMUNotifier is with inclusive ranges, so we should check against (VTD_ADDRESS_SIZE(s->aw_bits) - 1). Signed-off-by: Yan Zhao [peterx: split from another bigger patch] Reviewed-by: Eric Auger Signed-off-by: Peter Xu Acked-by: Jason Wang --- hw/i386/intel_iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 44b1231157..719ce19ab3 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -3379,12 +3379,12 @@ static void vtd_address_space_unmap(VTDAddressSpace= *as, IOMMUNotifier *n) * VT-d spec), otherwise we need to consider overflow of 64 bits. */ =20 - if (end > VTD_ADDRESS_SIZE(s->aw_bits)) { + if (end > VTD_ADDRESS_SIZE(s->aw_bits) - 1) { /* * Don't need to unmap regions that is bigger than the whole * VT-d supported address space size */ - end =3D VTD_ADDRESS_SIZE(s->aw_bits); + end =3D VTD_ADDRESS_SIZE(s->aw_bits) - 1; } =20 assert(start <=3D end); --=20 2.21.0