From nobody Mon May 13 22:25:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561368065; cv=none; d=zoho.com; s=zohoarc; b=KVG/HJIS+i0DHDRAxbxXcySAPH/3hQY5dnyHdQUPPydz0UXVmaG21g3JR8eBgUJ98mlKQMTKl2bAf7Yl0X3UBzZH7PB8xNoeuzgv3/LHD7prPj5ehgngxcrdzrPzH+MkgLSw1T8dSZmeBFxQVpc9aAGXhVNh80MmI5fnPAjGqJ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561368065; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Vg29Xwugh6rlTMJZbFL7wTKXmqcaIZpnaMvJwQtQtEs=; b=TBqb2U2r90VG92D50wd0uckto5M9War+XR7Xj6vMl6yc8hQxncR333pjZHNILANyK3pkpxxTTKVrSM5nFO0Dl7cntdzyFu4vBfrR99rLd8Cv+aGFt/c8SDJLRawhvspVY6s4hxVBOLley/LYLvgsf3vrdKfCw13Vpfkw0Q+cBSM= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561368065319833.0340420839747; Mon, 24 Jun 2019 02:21:05 -0700 (PDT) Received: from localhost ([::1]:49020 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfL9k-0000yI-5J for importer@patchew.org; Mon, 24 Jun 2019 05:20:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53428) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfL7W-0007uu-Qm for qemu-devel@nongnu.org; Mon, 24 Jun 2019 05:18:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfL7U-0003b3-AM for qemu-devel@nongnu.org; Mon, 24 Jun 2019 05:18:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46248) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfL7U-0003Qq-3n for qemu-devel@nongnu.org; Mon, 24 Jun 2019 05:18:36 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A7E1E308FC4D; Mon, 24 Jun 2019 09:18:29 +0000 (UTC) Received: from xz-x1.redhat.com (ovpn-12-60.pek2.redhat.com [10.72.12.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id B4A975C1B5; Mon, 24 Jun 2019 09:18:24 +0000 (UTC) From: Peter Xu To: qemu-devel@nongnu.org Date: Mon, 24 Jun 2019 17:18:10 +0800 Message-Id: <20190624091811.30412-2-peterx@redhat.com> In-Reply-To: <20190624091811.30412-1-peterx@redhat.com> References: <20190624091811.30412-1-peterx@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Mon, 24 Jun 2019 09:18:29 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 1/2] intel_iommu: Fix incorrect "end" for vtd_address_space_unmap X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Zhao , "Michael S . Tsirkin" , Jason Wang , peterx@redhat.com, Auger Eric , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Yan Zhao IOMMUNotifier is with inclusive ranges, so we should check against (VTD_ADDRESS_SIZE(s->aw_bits) - 1). Signed-off-by: Yan Zhao [peterx: split from another bigger patch] Reviewed-by: Eric Auger Signed-off-by: Peter Xu Acked-by: Jason Wang Reviewed-by: Michael S. Tsirkin --- hw/i386/intel_iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 44b1231157..719ce19ab3 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -3379,12 +3379,12 @@ static void vtd_address_space_unmap(VTDAddressSpace= *as, IOMMUNotifier *n) * VT-d spec), otherwise we need to consider overflow of 64 bits. */ =20 - if (end > VTD_ADDRESS_SIZE(s->aw_bits)) { + if (end > VTD_ADDRESS_SIZE(s->aw_bits) - 1) { /* * Don't need to unmap regions that is bigger than the whole * VT-d supported address space size */ - end =3D VTD_ADDRESS_SIZE(s->aw_bits); + end =3D VTD_ADDRESS_SIZE(s->aw_bits) - 1; } =20 assert(start <=3D end); --=20 2.21.0 From nobody Mon May 13 22:25:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561368059; cv=none; d=zoho.com; s=zohoarc; b=aU7ASQFgpSQwwUZAvqDQjiQLsPF2HMMlKpqUJg66MX0lOjq4MlglFkk1b4nKPPd8IFPeeEAHqtJLjOKzo6gkJlBHlizk7Lxhzdgl6TsrWfOHTECiGGwstYd0JN4K9pXCgbBUVzdFAl3ObwDU0Kc+Gdb0lKWyiWVVfj5jeSHXjbk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561368059; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=+XctHEndN3FvLEFMN51A9TUk+Q2fcCpmiyDDIK+xRRA=; b=NiP4DLW1KQEXX7k+QjnTXDt6eRjUGNApSOlGveq+ip/fNP97V3lbknmjn0VGt5cHNxGuTm9y5JRU/h9oWG6eWAsAYz48ue9Ygz6y8ZTcTgnDAPJ65tJDB7QcZQ0JLnFiaJZHYtSQJWhE9ofB7U7Zca8TV97MEPengMl9dltSR7Q= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561368059343667.2706714934243; Mon, 24 Jun 2019 02:20:59 -0700 (PDT) Received: from localhost ([::1]:49022 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfL9m-0000zX-AC for importer@patchew.org; Mon, 24 Jun 2019 05:20:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53429) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfL7W-0007uy-R7 for qemu-devel@nongnu.org; Mon, 24 Jun 2019 05:18:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfL7U-0003aw-9G for qemu-devel@nongnu.org; Mon, 24 Jun 2019 05:18:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47326) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfL7U-0003W7-0G for qemu-devel@nongnu.org; Mon, 24 Jun 2019 05:18:36 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0E81787628; Mon, 24 Jun 2019 09:18:33 +0000 (UTC) Received: from xz-x1.redhat.com (ovpn-12-60.pek2.redhat.com [10.72.12.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 420815C1B5; Mon, 24 Jun 2019 09:18:29 +0000 (UTC) From: Peter Xu To: qemu-devel@nongnu.org Date: Mon, 24 Jun 2019 17:18:11 +0800 Message-Id: <20190624091811.30412-3-peterx@redhat.com> In-Reply-To: <20190624091811.30412-1-peterx@redhat.com> References: <20190624091811.30412-1-peterx@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 24 Jun 2019 09:18:33 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Zhao , "Michael S . Tsirkin" , Jason Wang , peterx@redhat.com, Auger Eric , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This is an replacement work of Yan Zhao's patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html vtd_address_space_unmap() will do proper page mask alignment to make sure each IOTLB message will have correct masks for notification messages (2^N-1), but sometimes it can be expanded to even supercede the registered range. That could lead to unexpected UNMAP of already mapped regions in some other notifiers. Instead of doing mindless expension of the start address and address mask, we split the range into smaller ones and guarantee that each small range will have correct masks (2^N-1) and at the same time we should also try our best to generate as less IOTLB messages as possible. Reported-by: Yan Zhao Signed-off-by: Peter Xu Reviewed-by: Eric Auger Reviewed-by: Michael S. Tsirkin Tested-by: Yan Zhao --- hw/i386/intel_iommu.c | 67 ++++++++++++++++++++++++++----------------- 1 file changed, 41 insertions(+), 26 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 719ce19ab3..de86f53b4e 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -3363,11 +3363,28 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState *s= , PCIBus *bus, int devfn) return vtd_dev_as; } =20 +static uint64_t get_naturally_aligned_size(uint64_t start, + uint64_t size, int gaw) +{ + uint64_t max_mask =3D 1ULL << gaw; + uint64_t alignment =3D start ? start & -start : max_mask; + + alignment =3D MIN(alignment, max_mask); + size =3D MIN(size, max_mask); + + if (alignment <=3D size) { + /* Increase the alignment of start */ + return alignment; + } else { + /* Find the largest page mask from size */ + return 1ULL << (63 - clz64(size)); + } +} + /* Unmap the whole range in the notifier's scope. */ static void vtd_address_space_unmap(VTDAddressSpace *as, IOMMUNotifier *n) { - IOMMUTLBEntry entry; - hwaddr size; + hwaddr size, remain; hwaddr start =3D n->start; hwaddr end =3D n->end; IntelIOMMUState *s =3D as->iommu_state; @@ -3388,39 +3405,37 @@ static void vtd_address_space_unmap(VTDAddressSpace= *as, IOMMUNotifier *n) } =20 assert(start <=3D end); - size =3D end - start; + size =3D remain =3D end - start + 1; =20 - if (ctpop64(size) !=3D 1) { - /* - * This size cannot format a correct mask. Let's enlarge it to - * suite the minimum available mask. - */ - int n =3D 64 - clz64(size); - if (n > s->aw_bits) { - /* should not happen, but in case it happens, limit it */ - n =3D s->aw_bits; - } - size =3D 1ULL << n; + while (remain >=3D VTD_PAGE_SIZE) { + IOMMUTLBEntry entry; + uint64_t mask =3D get_naturally_aligned_size(start, remain, s->aw_= bits); + + assert(mask); + + entry.iova =3D start; + entry.addr_mask =3D mask - 1; + entry.target_as =3D &address_space_memory; + entry.perm =3D IOMMU_NONE; + /* This field is meaningless for unmap */ + entry.translated_addr =3D 0; + + memory_region_notify_one(n, &entry); + + start +=3D mask; + remain -=3D mask; } =20 - entry.target_as =3D &address_space_memory; - /* Adjust iova for the size */ - entry.iova =3D n->start & ~(size - 1); - /* This field is meaningless for unmap */ - entry.translated_addr =3D 0; - entry.perm =3D IOMMU_NONE; - entry.addr_mask =3D size - 1; + assert(!remain); =20 trace_vtd_as_unmap_whole(pci_bus_num(as->bus), VTD_PCI_SLOT(as->devfn), VTD_PCI_FUNC(as->devfn), - entry.iova, size); + n->start, size); =20 - map.iova =3D entry.iova; - map.size =3D entry.addr_mask; + map.iova =3D n->start; + map.size =3D size; iova_tree_remove(as->iova_tree, &map); - - memory_region_notify_one(n, &entry); } =20 static void vtd_address_space_unmap_all(IntelIOMMUState *s) --=20 2.21.0