From nobody Wed Dec 17 21:47:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561123555; cv=none; d=zoho.com; s=zohoarc; b=cxYAW/LAcRALuVka1L3g0VcOosdGtfqTx9HrMnAW3CRXIBhseVQZ4wMSc8RsN0MocnCq/cwox8yL8H+FahVroZaksWPlcypr2N8VJAWaP5+Nhm2QLph0k+X0WFFqWdyfq7RlegiDJeCwS05E1zj1nIjnmuCIUPVRLqEKG+X4gl0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561123555; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=qEyEN0NKr3khP3JxCHV/2z3wozzAH9ksfNCVIhkTzfA=; b=d/hMe882TgZGZGayDjZFPKtMhtP7lLXKrShHD6EJZw9XDFwG70xyaTiiMNcICvt+ymgeEAmCNI5WosOjw7AvzgRU8C9vw1bgIXJNZIFdDRVMj9aVCArjnqZDr6SM5HLNXomKl51PbcAwwGEp3zUH1Ee59y4XIQFeqTaOaPDQXDI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 156112355551619.24184786364708; Fri, 21 Jun 2019 06:25:55 -0700 (PDT) Received: from localhost ([::1]:34818 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1heJY5-0008RZ-2U for importer@patchew.org; Fri, 21 Jun 2019 09:25:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50388) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1heJW2-0006F2-E6 for qemu-devel@nongnu.org; Fri, 21 Jun 2019 09:23:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1heJVz-0004Q8-Ac for qemu-devel@nongnu.org; Fri, 21 Jun 2019 09:23:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44960) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1heJVs-0004H7-7n; Fri, 21 Jun 2019 09:23:32 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 25836308219E; Fri, 21 Jun 2019 13:23:30 +0000 (UTC) Received: from localhost (ovpn-204-30.brq.redhat.com [10.40.204.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B336A61101; Fri, 21 Jun 2019 13:23:29 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Date: Fri, 21 Jun 2019 15:23:17 +0200 Message-Id: <20190621132324.2165-2-mreitz@redhat.com> In-Reply-To: <20190621132324.2165-1-mreitz@redhat.com> References: <20190621132324.2165-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Fri, 21 Jun 2019 13:23:30 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 1/8] nvme: do not advertise support for unsupported arbitration mechanism X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Klaus Birkelund Jensen The device mistakenly reports that the Weighted Round Robin with Urgent Priority Class arbitration mechanism is supported. It is not. Signed-off-by: Klaus Birkelund Jensen Message-id: 20190606092530.14206-1-klaus@birkelund.eu Acked-by: Maxim Levitsky Signed-off-by: Max Reitz --- hw/block/nvme.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 107a719b95..36d6a8bb3a 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -1384,7 +1384,6 @@ static void nvme_realize(PCIDevice *pci_dev, Error **= errp) n->bar.cap =3D 0; NVME_CAP_SET_MQES(n->bar.cap, 0x7ff); NVME_CAP_SET_CQR(n->bar.cap, 1); - NVME_CAP_SET_AMS(n->bar.cap, 1); NVME_CAP_SET_TO(n->bar.cap, 0xf); NVME_CAP_SET_CSS(n->bar.cap, 1); NVME_CAP_SET_MPSMAX(n->bar.cap, 4); --=20 2.21.0