From nobody Sun Feb 8 10:59:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1561100590; cv=none; d=zoho.com; s=zohoarc; b=ejHNFAdIu1/33dkI0eZVYBgvzD/tvy8kPxxjK29C0VxWpYkcB5BNo85CaSLo674IyEmDGlAmoU6QOAu8fV8ew7i24f44QrRxkY+lUy5uN7DO4tXJiZ7rK6jGueAyr1k44jnzOgXlH6KosEzdsFTK7P8G+1rj+VTkQdrFaYKQ0ow= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561100590; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=rPPd0V/Z6AcAdBoeMxEle9jsqk+SF0qjA9KO6mmrcy4=; b=ZdFcODNpdQnKCkdca1GDesD+KEIYXUZHqzowEuyu+iTurY1M13x6gPEnqcCtvRDLGvlyvTNE3zKmmIREj5gczePjeKoe5C8NilsCzG20XYp6/Ofs8tEBdrc8wsQkjkSwiJFwiFdyWHfALkdq12GE3C2EBV+bhRh6gJzxRyX1GnQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561100590207878.7031454241537; Fri, 21 Jun 2019 00:03:10 -0700 (PDT) Received: from localhost ([::1]:55184 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1heDZd-0002Wb-5v for importer@patchew.org; Fri, 21 Jun 2019 03:03:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56628) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1heDLU-00087T-Me for qemu-devel@nongnu.org; Fri, 21 Jun 2019 02:48:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1heD75-0007zo-VZ for qemu-devel@nongnu.org; Fri, 21 Jun 2019 02:33:33 -0400 Received: from mga01.intel.com ([192.55.52.88]:19607) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1heD74-0007x3-CY; Fri, 21 Jun 2019 02:33:30 -0400 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2019 23:33:26 -0700 Received: from unknown (HELO localhost.localdomain) ([10.239.13.19]) by fmsmga005.fm.intel.com with ESMTP; 20 Jun 2019 23:33:25 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,399,1557212400"; d="scan'208";a="358780519" From: Zhang Chen To: Xie Changlong , Kevin Wolf , Max Reitz , qemu-block , qemu-dev Date: Fri, 21 Jun 2019 14:28:43 +0800 Message-Id: <20190621062843.1605-1-chen.zhang@intel.com> X-Mailer: git-send-email 2.17.GIT X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.88 Subject: [Qemu-devel] [PATCH V2 RESEND] block/replication.c: Fix crash issue after failover X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Zhang Chen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Zhang Chen If we try to close replication after failover, it will crash here. So we need check the block job on active disk before cancel the job. Signed-off-by: Zhang Chen --- block/replication.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/replication.c b/block/replication.c index b41bc507c0..a68bc7e986 100644 --- a/block/replication.c +++ b/block/replication.c @@ -149,7 +149,9 @@ static void replication_close(BlockDriverState *bs) replication_stop(s->rs, false, NULL); } if (s->stage =3D=3D BLOCK_REPLICATION_FAILOVER) { - job_cancel_sync(&s->commit_job->job); + if (s->commit_job) { + job_cancel_sync(&s->commit_job->job); + } } =20 if (s->mode =3D=3D REPLICATION_MODE_SECONDARY) { --=20 2.17.GIT