From nobody Tue Nov 11 03:19:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1561062532; cv=none; d=zoho.com; s=zohoarc; b=MRgLqkv4qfpo15wHQ0sh+QUYIunox1dbOyURpxlV8RIUxqvuwAwrsnnO9DEUnyog0LZl9zPBsJp6DEiz7juQwFyo0LZewoa07My+2Md/ooE9Oam+oxgIZ7mYldwLM8+LBTi4dz0Zt/yKcNw/xuaF4anRS+Rdtd8ANNdJriu33K4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561062532; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=6dPF7aNIYUGtn214v3aKYd09ChGd/ULnIgQPZvcIayE=; b=Dnz095pYQ8HM3cVDCPg2J0t3OHvnUG6QxcvMJ44FBDM1yqgI0is81Rt7d98XhWf6EN0c20+9fWc5Nt7WUKbENVlTFq1kYeHa92zgvoZzFPeNUKWSxXdgT0Uvhibxs5G7XuYTQJfHx9PWmrWiWvhho0j53eW6qqGEUsFNWiZQHyk= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561062532927740.2659948371452; Thu, 20 Jun 2019 13:28:52 -0700 (PDT) Received: from localhost ([::1]:52766 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1he3fv-0006Yz-Kp for importer@patchew.org; Thu, 20 Jun 2019 16:28:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45647) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1he36c-0007Lh-8V for qemu-devel@nongnu.org; Thu, 20 Jun 2019 15:52:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1he36b-0004jc-2a for qemu-devel@nongnu.org; Thu, 20 Jun 2019 15:52:22 -0400 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:24544) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1he36a-0004e9-On for qemu-devel@nongnu.org; Thu, 20 Jun 2019 15:52:20 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id E510D7462AA; Thu, 20 Jun 2019 21:52:13 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id C54127461AE; Thu, 20 Jun 2019 21:52:13 +0200 (CEST) From: BALATON Zoltan Date: Thu, 20 Jun 2019 21:46:06 +0200 To: qemu-devel@nongnu.org Message-Id: <20190620195213.C54127461AE@zero.eik.bme.hu> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:738:2001:2001::2001 Subject: [Qemu-devel] [PATCH] ati-vga: Clarify comment (to be squashed in previous patch) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/display/ati.c b/hw/display/ati.c index 6fbdda288f..932a1eacea 100644 --- a/hw/display/ati.c +++ b/hw/display/ati.c @@ -538,9 +538,14 @@ static void ati_mm_write(void *opaque, hwaddr addr, case GPIO_MONID ... GPIO_MONID + 3: /* FIXME What does Radeon have here? */ if (s->dev_id =3D=3D PCI_DEVICE_ID_ATI_RAGE128_PF) { - /* Rage128p accesses DDC used to get EDID on these pins */ ati_reg_write_offs(&s->regs.gpio_monid, addr - GPIO_MONID, data, size); + /* + * Rage128p accesses DDC used to get EDID via these bits. + * Only touch i2c when write overlaps 3rd byte because some + * drivers access this reg via multiple partial writes and + * without this spurious bits would be sent. + */ if ((s->regs.gpio_monid & BIT(25)) && addr <=3D GPIO_MONID + 2 && addr + size > GPIO_MONID + 2) { s->regs.gpio_monid =3D ati_i2c(s->bbi2c, s->regs.gpio_moni= d, 1); --=20 2.13.7