From nobody Tue Nov 11 05:00:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1561056959; cv=none; d=zoho.com; s=zohoarc; b=C+nZ63T8fqFrB//FsMgAKvO7O9tHq888gpKhAiONTYAicggvREig+j65iDnDAiFk5C6gXUlpF6XDUXboKC9/dydf0+Zld0J9uNnQkxJ7txiq+R5+7jW4Gp3jERISOrRmOQeC9VKmtMdW2R8JOpch4LwJVRus6FyzgPOL0p5RIDE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561056959; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Md1aJJlpBfsQ2g28/ln4S2g0lszCHVnTyUNl9Vr1pKQ=; b=SrlV3T26BqfnHLoKNgtwRe5ziAX/zwKct2p4PVxfjXVWDsSp2IPyePzJYyBDxKrPmUO0+ms6iHPl/CsZeIp+V2WffxemqYQG1qMpPPDXtmYinOyxHyIe4xrknFCJCPcpTKb4xsZ6kY3TWJS9S8e3GjW8vdYf31zJAgV5WnwurSU= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561056959108199.03749507359078; Thu, 20 Jun 2019 11:55:59 -0700 (PDT) Received: from localhost ([::1]:52204 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1he2Dy-0008DT-M9 for importer@patchew.org; Thu, 20 Jun 2019 14:55:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43128) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1he1cW-0005BR-GG for qemu-devel@nongnu.org; Thu, 20 Jun 2019 14:17:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1he1PC-0003w8-1V for qemu-devel@nongnu.org; Thu, 20 Jun 2019 14:03:47 -0400 Received: from mail-eopbgr720059.outbound.protection.outlook.com ([40.107.72.59]:35920 helo=NAM05-CO1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1he1PB-0003qK-R3 for qemu-devel@nongnu.org; Thu, 20 Jun 2019 14:03:25 -0400 Received: from DM6PR12MB2682.namprd12.prod.outlook.com (20.176.116.31) by DM6PR12MB3260.namprd12.prod.outlook.com (20.179.105.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.15; Thu, 20 Jun 2019 18:03:22 +0000 Received: from DM6PR12MB2682.namprd12.prod.outlook.com ([fe80::b9c1:b235:fff3:dba2]) by DM6PR12MB2682.namprd12.prod.outlook.com ([fe80::b9c1:b235:fff3:dba2%6]) with mapi id 15.20.1987.014; Thu, 20 Jun 2019 18:03:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Md1aJJlpBfsQ2g28/ln4S2g0lszCHVnTyUNl9Vr1pKQ=; b=qXc3+ms5ZSQszQDgNUG1dGFUiZITsoyHuGkzVKx3khp5EWHkUXOR0ejcb9OxVW8emA2j0WA3FHi1u+qeiM5yA1ffEpyisehxk/xqSfoQFmj4gCRfaXrwcOhjsyBV+hvRTFlrTdicN07F+bJIy033ZC2haNAbGJZc7LGpBjvb67E= From: "Singh, Brijesh" To: "qemu-devel@nongnu.org" Thread-Topic: [RFC PATCH v1 09/12] target/i386: sev: add support to encrypt the outgoing page Thread-Index: AQHVJ5JylDQBsN6QwEGUXzg2ihCEUQ== Date: Thu, 20 Jun 2019 18:03:21 +0000 Message-ID: <20190620180247.8825-10-brijesh.singh@amd.com> References: <20190620180247.8825-1-brijesh.singh@amd.com> In-Reply-To: <20190620180247.8825-1-brijesh.singh@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: DM5PR16CA0025.namprd16.prod.outlook.com (2603:10b6:4:15::11) To DM6PR12MB2682.namprd12.prod.outlook.com (2603:10b6:5:4a::31) authentication-results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [165.204.77.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8c37502b-cda5-43fc-e6b8-08d6f5a99457 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:DM6PR12MB3260; x-ms-traffictypediagnostic: DM6PR12MB3260: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:214; x-forefront-prvs: 0074BBE012 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(376002)(136003)(39860400002)(346002)(199004)(189003)(2351001)(53936002)(486006)(2616005)(11346002)(81156014)(8676002)(14444005)(6436002)(446003)(5640700003)(50226002)(6512007)(476003)(102836004)(6916009)(99286004)(2501003)(6486002)(76176011)(8936002)(52116002)(81166006)(316002)(186003)(6506007)(26005)(478600001)(256004)(3846002)(2906002)(386003)(66066001)(14454004)(54906003)(6116002)(305945005)(25786009)(1076003)(66946007)(66556008)(73956011)(64756008)(66446008)(71190400001)(71200400001)(68736007)(36756003)(66476007)(5660300002)(7736002)(86362001)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR12MB3260; H:DM6PR12MB2682.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: fwWuE5j5rNRAk4SY9iXs+Av4/QW2NuWNkAMpmj86z3+2gSDvv+RBaliMpNxwdWcGMPzmPpPZutTAK6L1I0q4CCbulpJs4OS31Sltz2pX+mTDvhI5ltUa/p67Mjkn0NvV5RX1tDW0n3MU4JsjlaVkdPazMoGGg+98mKDAq2RDtb1RhsigTGgfwc4ZFZFfWE8wNJ7HJTOg7gL5o9mcA8Bu0/GAzErjVQJYub3OzQXj5JPrM6jVwlKrrRxTI+wuqhuhRHVRBtoNmfjMv+1uMFo+vOaZUlkyIkiqN18wwQC43ua8Fd19zoEO1o/lHB9cXhIxzr+R6niFzbs3FeQIJfWFTti1TilQJwFW1PpprWtRhQ2gWW8eH5dSKJWMZhk3J4j/p7vKBFUc+rAkvMcmDtjmZeIoy3eKuuxiP5N8GqfMskE= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c37502b-cda5-43fc-e6b8-08d6f5a99457 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2019 18:03:21.2927 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sbrijesh@amd.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3260 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.72.59 Subject: [Qemu-devel] [RFC PATCH v1 09/12] target/i386: sev: add support to encrypt the outgoing page X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Lendacky, Thomas" , "Singh, Brijesh" , "kvm@vger.kernel.org" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The sev_save_outgoing_page() provide the implementation to encrypt the guest private pages during the transit. The routines uses the SEND_START command to create the outgoing encryption context on the first call then uses the SEND_UPDATE_DATA command to encrypt the data before writing it to the socket. While encrypting the data SEND_UPDATE_DATA produces some metadata (e.g MAC, IV). The metadata is also sent to the target machine. After migration is completed, we issue the SEND_FINISH command to transition the SEV guest state from sending to unrunnable state. Signed-off-by: Brijesh Singh --- accel/kvm/kvm-all.c | 1 + target/i386/sev.c | 229 +++++++++++++++++++++++++++++++++++++++ target/i386/sev_i386.h | 2 + target/i386/trace-events | 3 + 4 files changed, 235 insertions(+) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 0654d9a7cd..85d6508e7f 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -1784,6 +1784,7 @@ static int kvm_init(MachineState *ms) =20 kvm_state->memcrypt_encrypt_data =3D sev_encrypt_data; kvm_state->memcrypt_sync_page_enc_bitmap =3D sev_sync_page_enc_bit= map; + kvm_state->memcrypt_save_outgoing_page =3D sev_save_outgoing_page; } =20 ret =3D kvm_arch_init(ms, s); diff --git a/target/i386/sev.c b/target/i386/sev.c index 2c7c496593..b5aa53ec44 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -27,6 +27,8 @@ #include "sysemu/sysemu.h" #include "trace.h" #include "migration/blocker.h" +#include "migration/qemu-file.h" +#include "migration/misc.h" =20 #define DEFAULT_GUEST_POLICY 0x1 /* disable debug */ #define DEFAULT_SEV_DEVICE "/dev/sev" @@ -718,6 +720,39 @@ sev_vm_state_change(void *opaque, int running, RunStat= e state) } } =20 +static void +sev_send_finish(void) +{ + int ret, error; + + trace_kvm_sev_send_finish(); + ret =3D sev_ioctl(sev_state->sev_fd, KVM_SEV_SEND_FINISH, 0, &error); + if (ret) { + error_report("%s: LAUNCH_FINISH ret=3D%d fw_error=3D%d '%s'", + __func__, ret, error, fw_error_to_str(error)); + } + + sev_set_guest_state(SEV_STATE_RUNNING); +} + +static void +sev_migration_state_notifier(Notifier *notifier, void *data) +{ + MigrationState *s =3D data; + + if (migration_has_finished(s) || + migration_in_postcopy_after_devices(s) || + migration_has_failed(s)) { + if (sev_check_state(SEV_STATE_SEND_UPDATE)) { + sev_send_finish(); + } + } +} + +static Notifier sev_migration_state_notify =3D { + .notify =3D sev_migration_state_notifier, +}; + void * sev_guest_init(const char *id) { @@ -804,6 +839,7 @@ sev_guest_init(const char *id) ram_block_notifier_add(&sev_ram_notifier); qemu_add_machine_init_done_notifier(&sev_machine_done_notify); qemu_add_vm_change_state_handler(sev_vm_state_change, s); + add_migration_state_change_notifier(&sev_migration_state_notify); =20 return s; err: @@ -863,6 +899,199 @@ void sev_set_migrate_info(const char *pdh, const char= *plat_cert, s->amd_cert =3D g_base64_decode(amd_cert, &s->amd_cert_len); } =20 +static int +sev_get_send_session_length(void) +{ + int ret, fw_err =3D 0; + struct kvm_sev_send_start *start; + + start =3D g_new0(struct kvm_sev_send_start, 1); + + ret =3D sev_ioctl(sev_state->sev_fd, KVM_SEV_SEND_START, start, &fw_er= r); + if (fw_err !=3D SEV_RET_INVALID_LEN) { + ret =3D -1; + error_report("%s: failed to get session length ret=3D%d fw_error= =3D%d '%s'", + __func__, ret, fw_err, fw_error_to_str(fw_err)); + goto err; + } + + ret =3D start->session_len; +err: + g_free(start); + return ret; +} + +static int +sev_send_start(SEVState *s, QEMUFile *f, uint64_t *bytes_sent) +{ + gsize pdh_len =3D 0, plat_cert_len; + int session_len, ret, fw_error; + struct kvm_sev_send_start *start; + guchar *pdh =3D NULL, *plat_cert =3D NULL, *session =3D NULL; + + if (!s->remote_pdh || !s->remote_plat_cert) { + error_report("%s: missing remote PDH or PLAT_CERT", __func__); + return 1; + } + + start =3D g_new0(struct kvm_sev_send_start, 1); + + start->pdh_cert_uaddr =3D (unsigned long) s->remote_pdh; + start->pdh_cert_len =3D s->remote_pdh_len; + + start->plat_cert_uaddr =3D (unsigned long)s->remote_plat_cert; + start->plat_cert_len =3D s->remote_plat_cert_len; + + start->amd_cert_uaddr =3D (unsigned long)s->amd_cert; + start->amd_cert_len =3D s->amd_cert_len; + + /* get the session length */ + session_len =3D sev_get_send_session_length(); + if (session_len < 0) { + ret =3D 1; + goto err; + } + + session =3D g_new0(guchar, session_len); + start->session_uaddr =3D (unsigned long)session; + start->session_len =3D session_len; + + /* Get our PDH certificate */ + ret =3D sev_get_pdh_info(s->sev_fd, &pdh, &pdh_len, + &plat_cert, &plat_cert_len); + if (ret) { + error_report("Failed to get our PDH cert"); + goto err; + } + + trace_kvm_sev_send_start(start->pdh_cert_uaddr, start->pdh_cert_len, + start->plat_cert_uaddr, start->plat_cert_len, + start->amd_cert_uaddr, start->amd_cert_len); + + ret =3D sev_ioctl(s->sev_fd, KVM_SEV_SEND_START, start, &fw_error); + if (ret < 0) { + error_report("%s: SEND_START ret=3D%d fw_error=3D%d '%s'", + __func__, ret, fw_error, fw_error_to_str(fw_error)); + goto err; + } + + qemu_put_be32(f, start->policy); + qemu_put_be32(f, pdh_len); + qemu_put_buffer(f, (uint8_t *)pdh, pdh_len); + qemu_put_be32(f, start->session_len); + qemu_put_buffer(f, (uint8_t *)start->session_uaddr, start->session_len= ); + *bytes_sent =3D 12 + pdh_len + start->session_len; + + sev_set_guest_state(SEV_STATE_SEND_UPDATE); + +err: + g_free(start); + g_free(pdh); + g_free(plat_cert); + return ret; +} + +static int +sev_send_get_packet_len(int *fw_err) +{ + int ret; + struct kvm_sev_send_update_data *update; + + update =3D g_malloc0(sizeof(*update)); + if (!update) { + return -1; + } + + ret =3D sev_ioctl(sev_state->sev_fd, KVM_SEV_SEND_UPDATE_DATA, update,= fw_err); + if (*fw_err !=3D SEV_RET_INVALID_LEN) { + ret =3D -1; + error_report("%s: failed to get session length ret=3D%d fw_error= =3D%d '%s'", + __func__, ret, *fw_err, fw_error_to_str(*fw_err)); + goto err; + } + + ret =3D update->hdr_len; + +err: + g_free(update); + return ret; +} + +static int +sev_send_update_data(SEVState *s, QEMUFile *f, uint8_t *ptr, uint32_t size, + uint64_t *bytes_sent) +{ + int ret, fw_error; + guchar *trans; + struct kvm_sev_send_update_data *update; + + /* If this is first call then query the packet header bytes and alloca= te + * the packet buffer. + */ + if (!s->send_packet_hdr) { + s->send_packet_hdr_len =3D sev_send_get_packet_len(&fw_error); + if (s->send_packet_hdr_len < 1) { + error_report("%s: SEND_UPDATE fw_error=3D%d '%s'", + __func__, fw_error, fw_error_to_str(fw_error)); + return 1; + } + + s->send_packet_hdr =3D g_new(gchar, s->send_packet_hdr_len); + } + + update =3D g_new0(struct kvm_sev_send_update_data, 1); + + /* allocate transport buffer */ + trans =3D g_new(guchar, size); + + update->hdr_uaddr =3D (unsigned long)s->send_packet_hdr; + update->hdr_len =3D s->send_packet_hdr_len; + update->guest_uaddr =3D (unsigned long)ptr; + update->guest_len =3D size; + update->trans_uaddr =3D (unsigned long)trans; + update->trans_len =3D size; + + trace_kvm_sev_send_update_data(ptr, trans, size); + + ret =3D sev_ioctl(s->sev_fd, KVM_SEV_SEND_UPDATE_DATA, update, &fw_err= or); + if (ret) { + error_report("%s: SEND_UPDATE_DATA ret=3D%d fw_error=3D%d '%s'", + __func__, ret, fw_error, fw_error_to_str(fw_error)); + goto err; + } + + qemu_put_be32(f, update->hdr_len); + qemu_put_buffer(f, (uint8_t *)update->hdr_uaddr, update->hdr_len); + *bytes_sent =3D 4 + update->hdr_len; + + qemu_put_be32(f, update->trans_len); + qemu_put_buffer(f, (uint8_t *)update->trans_uaddr, update->trans_len); + *bytes_sent +=3D (4 + update->trans_len); + +err: + g_free(trans); + g_free(update); + return ret; +} + +int sev_save_outgoing_page(void *handle, QEMUFile *f, uint8_t *ptr, + uint32_t sz, uint64_t *bytes_sent) +{ + SEVState *s =3D sev_state; + + /* + * If this is a first buffer then create outgoing encryption context + * and write our PDH, policy and session data. + */ + if (!sev_check_state(SEV_STATE_SEND_UPDATE) && + sev_send_start(s, f, bytes_sent)) { + error_report("Failed to create outgoing context"); + return 1; + } + + return sev_send_update_data(s, f, ptr, sz, bytes_sent); +} + static void sev_register_types(void) { diff --git a/target/i386/sev_i386.h b/target/i386/sev_i386.h index 258047ab2c..38893fb1fa 100644 --- a/target/i386/sev_i386.h +++ b/target/i386/sev_i386.h @@ -88,6 +88,8 @@ struct SEVState { size_t remote_plat_cert_len; guchar *amd_cert; size_t amd_cert_len; + gchar *send_packet_hdr; + size_t send_packet_hdr_len; }; =20 typedef struct SEVState SEVState; diff --git a/target/i386/trace-events b/target/i386/trace-events index 789c700d4a..b41516cf9f 100644 --- a/target/i386/trace-events +++ b/target/i386/trace-events @@ -15,3 +15,6 @@ kvm_sev_launch_start(int policy, void *session, void *pdh= ) "policy 0x%x session kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRI= u64 kvm_sev_launch_measurement(const char *value) "data %s" kvm_sev_launch_finish(void) "" +kvm_sev_send_start(uint64_t pdh, int l1, uint64_t plat, int l2, uint64_t a= md, int l3) "pdh 0x%" PRIx64 " len %d plat 0x%" PRIx64 " len %d amd 0x%" PR= Ix64 " len %d" +kvm_sev_send_update_data(void *src, void *dst, int len) "guest %p trans %p= len %d" +kvm_sev_send_finish(void) "" --=20 2.17.1