From nobody Tue Nov 11 01:35:47 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561046209; cv=none; d=zoho.com; s=zohoarc; b=ZpN8vUhvqEPxRbuoJ8RKgLm2dbnAbbpJJEhry4sINhugoPUBZjcRb/z4ogqSTT0QTdI2aMwiGDUJcHz4Fjbp5EO+Oo1wOTofPRgJT+NC0AaxhUcrnvK08J3/5oKeBKfIkpVk8BUHe0qa08Kc5uKkDB1g1ZRPveQCnK7QnVdV9Y8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561046209; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=mcT6zpIELkhWYKqFPuAvtubYr1Z+w//ooBXFwUN/dg4=; b=AKd9IoXUIDCp+SPGkH1x9l7l4Qq3kIIhms22YTUPdD09Tbm+BuKrT4wFZ8uufgX4/XvQwbdNoQrdPNtA3yQX82dGLYvFprs0wli4T4vUNuBF6GBHwR2QrSuKd5Rv4U+d1bIVOm+sejeqlVOZXKZl8gx8oum/XkQOWOn6pm3CWu4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561046209789714.4258917000121; Thu, 20 Jun 2019 08:56:49 -0700 (PDT) Received: from localhost ([::1]:49790 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdzQa-0007Kn-Gz for importer@patchew.org; Thu, 20 Jun 2019 11:56:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52740) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdzIo-0008Mo-Lz for qemu-devel@nongnu.org; Thu, 20 Jun 2019 11:48:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdzB4-0007HS-9L for qemu-devel@nongnu.org; Thu, 20 Jun 2019 11:40:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55134) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hdzB4-0007Ge-3R for qemu-devel@nongnu.org; Thu, 20 Jun 2019 11:40:42 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6EFD0307D922 for ; Thu, 20 Jun 2019 15:40:41 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7543819C5B; Thu, 20 Jun 2019 15:40:40 +0000 (UTC) From: Igor Mammedov To: qemu-devel@nongnu.org Date: Thu, 20 Jun 2019 11:40:35 -0400 Message-Id: <20190620154035.30989-1-imammedo@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Thu, 20 Jun 2019 15:40:41 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2] qmp: make qmp-shell work with python3 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: crosa@redhat.com, armbru@redhat.com, ehabkost@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" python3 doesn't have raw_input(), so qmp-shell breaks. Use input() instead and override it with raw_input() if running on python2. Signed-off-by: Igor Mammedov --- v2: use sys.version_info[0] instead try/except=20 (Cleber Rosa ) scripts/qmp/qmp-shell | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell index 7776c7b141..f1cddeafbc 100755 --- a/scripts/qmp/qmp-shell +++ b/scripts/qmp/qmp-shell @@ -78,6 +78,9 @@ import re sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'pytho= n')) from qemu import qmp =20 +if sys.version_info[0] =3D=3D 2: + input =3D raw_input + class QMPCompleter(list): def complete(self, text, state): for cmd in self: @@ -308,7 +311,7 @@ class QMPShell(qmp.QEMUMonitorProtocol): @return True if execution was ok, return False if disconnected. """ try: - cmdline =3D raw_input(prompt) + cmdline =3D input(prompt) except EOFError: print() return False --=20 2.18.1