From nobody Tue Nov 11 01:39:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1560866981; cv=none; d=zoho.com; s=zohoarc; b=UweoNIc+/QszpKixpuHEhJAgtYDNAXJecLmMlZ6sqLtk3WvkB4xgkyF0/YNbt2bp65MZLvL4SH7W7WYXhQ7FWw61Fb5EyM+s3pTuruddWkdDyDPgPeb4NvgVXTQYqYB705+7LjW14lFtFRTmlfnLKkHlRcbfR8M63QpG/AFRKvQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560866981; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=FcODkutTPb6O50T5/FELUif2MPjVfuGHKu0GYjh0G9Q=; b=TGeb4YEfoc2eTMk+H2YkzEy8DLStI1hk9SvCyCMAcrWxqw0GF5w0ynMtPDAVuH2DJcMgfBQU03uR3npBpOgbuXDYOpzQB/PhGY1NZpPiYc59wmyrKQRYFg7fnjxouvfBzDHuBQ+I4c/gih3bjhxx2uGVNIi7KyOXbdevR/A3DBU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1560866981665239.3843732841798; Tue, 18 Jun 2019 07:09:41 -0700 (PDT) Received: from localhost ([::1]:58380 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdEnn-0000lL-5Q for importer@patchew.org; Tue, 18 Jun 2019 10:09:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59161) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hdEmT-00086A-67 for qemu-devel@nongnu.org; Tue, 18 Jun 2019 10:08:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hdEmQ-0003UM-Mh for qemu-devel@nongnu.org; Tue, 18 Jun 2019 10:08:13 -0400 Received: from relay.sw.ru ([185.231.240.75]:35210) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hdEmQ-0003Nt-Fv; Tue, 18 Jun 2019 10:08:10 -0400 Received: from [10.94.3.0] (helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.92) (envelope-from ) id 1hdEmL-0001ya-0C; Tue, 18 Jun 2019 17:08:05 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org, qemu-block@nongnu.org Date: Tue, 18 Jun 2019 17:08:04 +0300 Message-Id: <20190618140804.59214-1-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 Subject: [Qemu-devel] [PATCH] blockdev: enable non-root nodes for transaction drive-backup source X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, jsnow@redhat.com, armbru@redhat.com, mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We forget to enable it for transaction .prepare, while it is already enabled in do_drive_backup since commit a2d665c1bc362 "blockdev: loosen restrictions on drive-backup source node" Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- Hmm, I've to add John by hand, get_maintainer.pl don't report him. Shouldn't we include blockdev.c into Block Jobs in MAINTAINERS? It definitely related to block jobs. blockdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index b5c0fd3c49..4ae81d687a 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1775,7 +1775,7 @@ static void drive_backup_prepare(BlkActionState *comm= on, Error **errp) assert(common->action->type =3D=3D TRANSACTION_ACTION_KIND_DRIVE_BACKU= P); backup =3D common->action->u.drive_backup.data; =20 - bs =3D qmp_get_root_bs(backup->device, errp); + bs =3D bdrv_lookup_bs(backup->device, backup->device, errp); if (!bs) { return; } --=20 2.18.0