From nobody Sun Feb 8 17:21:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560507116; cv=none; d=zoho.com; s=zohoarc; b=mIBp/720ZCSmF+s1+6k2EA9HtzvhwTgl0ripk0CEF9+spddXk53h65QXxfs/1K/+S66JT+6U/7XZUs4lF4u9gRhUcuieyMyfTSqkidgVNSnATSaM6EGtW9c81Cwa7aIjg/fBOqRPwShf+G6dCBt4RJPqsqlwUpSbuRunwfZwsAw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560507116; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=gSlYAGC6yReVE8BL/sZ5foVPTAdilZILGl/VKZw2MAw=; b=Wnb6o2+Ra6Ns2nXtDhYDr/OmB6UxazddXccvZHMij1Tw0oGShbNTrJ+ZrNhPllcEKCp1r1shl4TEV6BMqiUPi1Ze9IGwopdcpATP2u2PX5k/sj8ZwDak++bkdI1e+7ORlyR060ajYiOR+GEdymRr0ACGKQEFXfYUMQMsobwdx+g= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1560507116251885.562464580245; Fri, 14 Jun 2019 03:11:56 -0700 (PDT) Received: from localhost ([::1]:49836 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbjBb-0005X9-4o for importer@patchew.org; Fri, 14 Jun 2019 06:11:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48563) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbj7W-0003eQ-Sw for qemu-devel@nongnu.org; Fri, 14 Jun 2019 06:07:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbj7V-00007Y-T9 for qemu-devel@nongnu.org; Fri, 14 Jun 2019 06:07:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35636) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbj7T-00005z-FF; Fri, 14 Jun 2019 06:07:39 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AECEA3082E23; Fri, 14 Jun 2019 10:07:38 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8355F1001B2F; Fri, 14 Jun 2019 10:07:32 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Date: Fri, 14 Jun 2019 12:07:10 +0200 Message-Id: <20190614100718.14019-2-philmd@redhat.com> In-Reply-To: <20190614100718.14019-1-philmd@redhat.com> References: <20190614100718.14019-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Fri, 14 Jun 2019 10:07:38 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 1/9] configure: Only generate GLUSTERFS variables if glusterfs is usable X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Thomas Huth , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Tokarev , Bharata B Rao , Gerd Hoffmann , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Niels de Vos Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" It is pointless and confusing to have GLUSTERFS variables in config-host.mak when glusterfs is not usable. Reviewed-by: Niels de Vos Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 --- configure | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/configure b/configure index b091b82cb3..13fd4a1166 100755 --- a/configure +++ b/configure @@ -7118,30 +7118,30 @@ if test "$glusterfs" =3D "yes" ; then echo "CONFIG_GLUSTERFS=3Dm" >> $config_host_mak echo "GLUSTERFS_CFLAGS=3D$glusterfs_cflags" >> $config_host_mak echo "GLUSTERFS_LIBS=3D$glusterfs_libs" >> $config_host_mak -fi =20 -if test "$glusterfs_xlator_opt" =3D "yes" ; then - echo "CONFIG_GLUSTERFS_XLATOR_OPT=3Dy" >> $config_host_mak -fi + if test "$glusterfs_xlator_opt" =3D "yes" ; then + echo "CONFIG_GLUSTERFS_XLATOR_OPT=3Dy" >> $config_host_mak + fi =20 -if test "$glusterfs_discard" =3D "yes" ; then - echo "CONFIG_GLUSTERFS_DISCARD=3Dy" >> $config_host_mak -fi + if test "$glusterfs_discard" =3D "yes" ; then + echo "CONFIG_GLUSTERFS_DISCARD=3Dy" >> $config_host_mak + fi =20 -if test "$glusterfs_fallocate" =3D "yes" ; then - echo "CONFIG_GLUSTERFS_FALLOCATE=3Dy" >> $config_host_mak -fi + if test "$glusterfs_fallocate" =3D "yes" ; then + echo "CONFIG_GLUSTERFS_FALLOCATE=3Dy" >> $config_host_mak + fi =20 -if test "$glusterfs_zerofill" =3D "yes" ; then - echo "CONFIG_GLUSTERFS_ZEROFILL=3Dy" >> $config_host_mak -fi + if test "$glusterfs_zerofill" =3D "yes" ; then + echo "CONFIG_GLUSTERFS_ZEROFILL=3Dy" >> $config_host_mak + fi =20 -if test "$glusterfs_ftruncate_has_stat" =3D "yes" ; then - echo "CONFIG_GLUSTERFS_FTRUNCATE_HAS_STAT=3Dy" >> $config_host_mak -fi + if test "$glusterfs_ftruncate_has_stat" =3D "yes" ; then + echo "CONFIG_GLUSTERFS_FTRUNCATE_HAS_STAT=3Dy" >> $config_host_mak + fi =20 -if test "$glusterfs_iocb_has_stat" =3D "yes" ; then - echo "CONFIG_GLUSTERFS_IOCB_HAS_STAT=3Dy" >> $config_host_mak + if test "$glusterfs_iocb_has_stat" =3D "yes" ; then + echo "CONFIG_GLUSTERFS_IOCB_HAS_STAT=3Dy" >> $config_host_mak + fi fi =20 if test "$libssh2" =3D "yes" ; then --=20 2.20.1