From nobody Mon Feb 9 06:34:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560439859; cv=none; d=zoho.com; s=zohoarc; b=AlroNLsM463Uk4I/DuICV8aG1gcaacj4ZLnRlczzAmavMJujAsCpg/VH3mxTP/HNRfvm3BnxGqLa2yoxocbAz/hJpdIGWopX2jtTy9ew+WyPEAbffSsm7POEuAI3V4/lYj4KW9Hv+8uadC0ahXH67QWQFE3KOlumKamLO7lBGuU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560439859; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=2C8kD8sjY3wkqASXT47xdNDGhLxziJGv3Etj531tVBs=; b=hyCsqN3PMExshMpbjdo/V0+RfcC3IDdcHHHeiMShdHxU0oeUxrCyGePKeJbrsxwnmFPt6Ubfn5JkX/G/BdjqTu56Rb/4ZatE4B3/K3YmSyZcei4VaVwWIfmkbhuWxTSD0+piOvxcslA1/Bgap+8lyHt5DCuwrtUZK9TUEPHhHLI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1560439859926807.8025225690666; Thu, 13 Jun 2019 08:30:59 -0700 (PDT) Received: from localhost ([::1]:40952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbRgU-0006K1-R3 for importer@patchew.org; Thu, 13 Jun 2019 11:30:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42827) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbQpu-0001hd-MT for qemu-devel@nongnu.org; Thu, 13 Jun 2019 10:36:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbQpj-0001ep-Nq for qemu-devel@nongnu.org; Thu, 13 Jun 2019 10:36:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35230) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbQpj-0001cV-8t for qemu-devel@nongnu.org; Thu, 13 Jun 2019 10:36:07 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 43CDF30872E6; Thu, 13 Jun 2019 14:36:06 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.141]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6F4B61001B0F; Thu, 13 Jun 2019 14:35:56 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Date: Thu, 13 Jun 2019 16:34:34 +0200 Message-Id: <20190613143446.23937-9-philmd@redhat.com> In-Reply-To: <20190613143446.23937-1-philmd@redhat.com> References: <20190613143446.23937-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 13 Jun 2019 14:36:06 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 08/20] hw/i386/pc: Use address_space_memory in place X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yang Zhong , Eduardo Habkost , kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , Li Qiang , Rob Bradford , Paolo Bonzini , Samuel Ortiz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The address_space_memory variable is used once. Use it in place and remove the argument. Suggested-by: Samuel Ortiz Reviewed-by: Li Qiang Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index c5c96a2e10..acde575ced 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -932,7 +932,7 @@ static void pc_build_smbios(PCMachineState *pcms) } } =20 -static FWCfgState *bochs_bios_init(AddressSpace *as, PCMachineState *pcms) +static FWCfgState *bochs_bios_init(PCMachineState *pcms) { FWCfgState *fw_cfg; uint64_t *numa_fw_cfg; @@ -940,7 +940,8 @@ static FWCfgState *bochs_bios_init(AddressSpace *as, PC= MachineState *pcms) const CPUArchIdList *cpus; MachineClass *mc =3D MACHINE_GET_CLASS(pcms); =20 - fw_cfg =3D fw_cfg_init_io_dma(FW_CFG_IO_BASE, FW_CFG_IO_BASE + 4, as); + fw_cfg =3D fw_cfg_init_io_dma(FW_CFG_IO_BASE, FW_CFG_IO_BASE + 4, + &address_space_memory); fw_cfg_add_i16(fw_cfg, FW_CFG_NB_CPUS, pcms->boot_cpus); =20 /* FW_CFG_MAX_CPUS is a bit confusing/problematic on x86: @@ -1765,7 +1766,7 @@ void pc_memory_init(PCMachineState *pcms, option_rom_mr, 1); =20 - fw_cfg =3D bochs_bios_init(&address_space_memory, pcms); + fw_cfg =3D bochs_bios_init(pcms); =20 rom_set_fw(fw_cfg); =20 --=20 2.20.1