From nobody Mon Feb 9 06:00:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560420509; cv=none; d=zoho.com; s=zohoarc; b=i2if+sgrc4dnWtRh3QYX465a8JvUGiOCQL2c2wv4ShMS2lThi+OZa79m0suTFrxNEsA4zprgJACjbiQa6F+r12hZfaGPh/tJU9j8wDfa8WQIDHP7W4VIvTIb85qxelBocJ2fZIogWOvW3jWelVQMT+ffIBdnEApV2OISZ9Hkouw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560420509; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=23wwr8zN6cZfOQ2O1aTgtw1pywasN44JJOA2KKFx4jE=; b=TRpsZ5bR2hD+zX9N9Ado75YOFGjy1OC3rn7FsWvaeDr/ZYLrBJn57D9hms3OCveIClkhU6Gf4o77Rle5aCgrWzL/CW3Qd4epw3wyanS2X9ev0oainGVdT9sQ3b9CJOHx64cwnKUkiPd99H9sU9y6ho5Ns1JoCTuEVnKrr6ZNtuA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15604205094621015.2506708921044; Thu, 13 Jun 2019 03:08:29 -0700 (PDT) Received: from localhost ([::1]:38192 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbMei-0003gJ-HQ for importer@patchew.org; Thu, 13 Jun 2019 06:08:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56312) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbMWG-0007MV-GH for qemu-devel@nongnu.org; Thu, 13 Jun 2019 05:59:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbMWF-0005zn-91 for qemu-devel@nongnu.org; Thu, 13 Jun 2019 05:59:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36416) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbMWE-0005z3-R4 for qemu-devel@nongnu.org; Thu, 13 Jun 2019 05:59:43 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 149056EB93 for ; Thu, 13 Jun 2019 09:59:42 +0000 (UTC) Received: from dgilbert-t580.localhost (ovpn-117-220.ams2.redhat.com [10.36.117.220]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF5D552FDE; Thu, 13 Jun 2019 09:59:40 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, jasowang@redhat.com, eblake@redhat.com, armbru@redhat.com, laine@redhat.com Date: Thu, 13 Jun 2019 10:59:23 +0100 Message-Id: <20190613095924.21908-5-dgilbert@redhat.com> In-Reply-To: <20190613095924.21908-1-dgilbert@redhat.com> References: <20190613095924.21908-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 13 Jun 2019 09:59:42 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v4 4/5] net/announce: Add HMP optional ID X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" Add the optional ID to the HMP command. e.g. # start an announce for a long time on eth1 migrate_set_parameter announce-rounds 1000 announce_self "eth1" e1 # start an announce on eth2 announce_self "eth2" e2 # Change e1 to be announcing on eth1 and eth3 announce_self "eth1,eth3" e1 # Cancel e1 migrate_set_parameter announce-rounds 0 announce_self "" e1 Signed-off-by: Dr. David Alan Gilbert --- hmp-commands.hx | 7 ++++--- hmp.c | 3 +++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 1b63372713..7ba8543cc3 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -955,8 +955,8 @@ ETEXI =20 { .name =3D "announce_self", - .args_type =3D "interfaces:s?", - .params =3D "[interfaces]", + .args_type =3D "interfaces:s?,id:s?", + .params =3D "[interfaces] [id]", .help =3D "Trigger GARP/RARP announcements", .cmd =3D hmp_announce_self, }, @@ -968,7 +968,8 @@ Trigger a round of GARP/RARP broadcasts; this is useful= for explicitly updating network infrastructure after a reconfiguration or some forms of migration. The timings of the round are set by the migration announce parameters. An optional comma separated @var{interfaces} list restricts the announce t= o the -named set of interfaces. +named set of interfaces. An optional @var{id} can be used to start a separ= ate announce +timer and to change the parameters of it later. ETEXI =20 { diff --git a/hmp.c b/hmp.c index 52efb4a4fa..fd498ca0a8 100644 --- a/hmp.c +++ b/hmp.c @@ -1669,12 +1669,15 @@ void hmp_info_snapshots(Monitor *mon, const QDict *= qdict) void hmp_announce_self(Monitor *mon, const QDict *qdict) { const char *interfaces_str =3D qdict_get_try_str(qdict, "interfaces"); + const char *id =3D qdict_get_try_str(qdict, "id"); AnnounceParameters *params =3D QAPI_CLONE(AnnounceParameters, migrate_announce_params()); =20 qapi_free_strList(params->interfaces); params->interfaces =3D strList_from_comma_list(interfaces_str); params->has_interfaces =3D params->interfaces !=3D NULL; + params->id =3D g_strdup(id); + params->has_id =3D !!params->id; qmp_announce_self(params, NULL); qapi_free_AnnounceParameters(params); } --=20 2.21.0