MAINTAINERS | 19 + arch_init.c | 2 + configure | 8 + default-configs/rx-softmmu.mak | 3 + hw/Kconfig | 1 + hw/char/Kconfig | 3 + hw/char/Makefile.objs | 1 + hw/char/renesas_sci.c | 340 ++++ hw/intc/Kconfig | 3 + hw/intc/Makefile.objs | 1 + hw/intc/rx_icu.c | 376 ++++ hw/rx/Kconfig | 14 + hw/rx/Makefile.objs | 2 + hw/rx/rx-virt.c | 113 ++ hw/rx/rx62n.c | 246 +++ hw/timer/Kconfig | 6 + hw/timer/Makefile.objs | 3 + hw/timer/renesas_cmt.c | 275 +++ hw/timer/renesas_tmr.c | 455 +++++ include/disas/dis-asm.h | 5 + include/exec/poison.h | 1 + include/hw/char/renesas_sci.h | 45 + include/hw/intc/rx_icu.h | 56 + include/hw/registerfields.h | 32 +- include/hw/rx/rx.h | 7 + include/hw/rx/rx62n.h | 91 + include/hw/timer/renesas_cmt.h | 38 + include/hw/timer/renesas_tmr.h | 53 + include/qemu/bitops.h | 38 + include/sysemu/arch_init.h | 1 + qapi/common.json | 3 +- target/rx/Makefile.objs | 12 + target/rx/cpu-qom.h | 42 + target/rx/cpu.c | 252 +++ target/rx/cpu.h | 201 ++ target/rx/disas.c | 1446 ++++++++++++++ target/rx/gdbstub.c | 112 ++ target/rx/helper.c | 148 ++ target/rx/helper.h | 31 + target/rx/insns.decode | 621 ++++++ target/rx/monitor.c | 38 + target/rx/op_helper.c | 470 +++++ target/rx/translate.c | 2432 ++++++++++++++++++++++++ tests/acceptance/boot_linux_console.py | 51 + tests/machine-none-test.c | 1 + 45 files changed, 8096 insertions(+), 2 deletions(-) create mode 100644 default-configs/rx-softmmu.mak create mode 100644 hw/char/renesas_sci.c create mode 100644 hw/intc/rx_icu.c create mode 100644 hw/rx/Kconfig create mode 100644 hw/rx/Makefile.objs create mode 100644 hw/rx/rx-virt.c create mode 100644 hw/rx/rx62n.c create mode 100644 hw/timer/renesas_cmt.c create mode 100644 hw/timer/renesas_tmr.c create mode 100644 include/hw/char/renesas_sci.h create mode 100644 include/hw/intc/rx_icu.h create mode 100644 include/hw/rx/rx.h create mode 100644 include/hw/rx/rx62n.h create mode 100644 include/hw/timer/renesas_cmt.h create mode 100644 include/hw/timer/renesas_tmr.h create mode 100644 target/rx/Makefile.objs create mode 100644 target/rx/cpu-qom.h create mode 100644 target/rx/cpu.c create mode 100644 target/rx/cpu.h create mode 100644 target/rx/disas.c create mode 100644 target/rx/gdbstub.c create mode 100644 target/rx/helper.c create mode 100644 target/rx/helper.h create mode 100644 target/rx/insns.decode create mode 100644 target/rx/monitor.c create mode 100644 target/rx/op_helper.c create mode 100644 target/rx/translate.c
Hi Yoshinori, Richard, Igor. This series an iteration of the previous v16 from Yoshinori with the fixups requested by Igor here: https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg07260.html and https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg01547.html plus trivial cleanups. It is based on commit 19735c837ae2056b4651720290eda59498eca65a, that is before the merge of pull-tcg-20190610 (CPUNegativeOffsetState) which resulted in commit a578cdfbdd8f9beff5ced52b7826ddb1669abbbf. Series reordered, some patches squashed. Patches modified: 2, 3, 14, 19 (wait review from Igor) New patch: 16 (wait review from Yoshinori) Extra patch: 21 (meant for testing) This branch is available here: https://gitlab.com/philmd/qemu/tree/rx-v19 We have: $ qemu-system-rx -cpu help rx62n (qemu) info qom-tree /machine (rx-virt-machine) /peripheral (container) /mcu (rx62n) /sci[0] (renesas-sci) /renesas-sci[0] (qemu:memory-region) /icu (rx-icu) ... /cpu (rx62n-rx-cpu) /unnamed-gpio-in[0] (irq) /unnamed-gpio-in[1] (irq) ... $ git backport-diff -u rx-16 -r 19735c837ae..rx-v19 Key: [----] : patches are identical [####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively 001/21:[----] [--] 'target/rx: TCG translation' 002/21:[0011] [FC] 'target/rx: TCG helper' 003/21:[0136] [FC] 'target/rx: CPU definition' 004/21:[----] [--] 'target/rx: RX disassembler' 005/21:[----] [--] 'target/rx: Disassemble rx_index_addr into a string' 006/21:[----] [--] 'target/rx: Replace operand with prt_ldmi in disassembler' 007/21:[----] [--] 'target/rx: Use prt_ldmi for XCHG_mr disassembly' 008/21:[----] [--] 'target/rx: Emit all disassembly in one prt()' 009/21:[----] [--] 'target/rx: Collect all bytes during disassembly' 010/21:[----] [--] 'target/rx: Dump bytes for each insn during disassembly' 011/21:[----] [--] 'hw/intc: RX62N interrupt controller (ICUa)' 012/21:[----] [--] 'hw/timer: RX62N internal timer modules' 013/21:[----] [--] 'hw/char: RX62N serial communication interface (SCI)' 014/21:[0013] [FC] 'hw/rx: RX Target hardware definition' 015/21:[----] [-C] 'hw/rx: Honor -accel qtest' 016/21:[down] 'hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core' 017/21:[----] [--] 'qemu/bitops.h: Add extract8 and extract16' 018/21:[----] [--] 'hw/registerfields.h: Add 8bit and 16bit register macros' 019/21:[0005] [FC] 'Add rx-softmmu' 020/21:[----] [--] 'MAINTAINERS: Add RX' 021/21:[down] 'BootLinuxConsoleTest: Test the RX-Virt machine' Thanks, Phil. Philippe Mathieu-Daudé (3): hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core hw/registerfields.h: Add 8bit and 16bit register macros BootLinuxConsoleTest: Test the RX-Virt machine Richard Henderson (7): target/rx: Disassemble rx_index_addr into a string target/rx: Replace operand with prt_ldmi in disassembler target/rx: Use prt_ldmi for XCHG_mr disassembly target/rx: Emit all disassembly in one prt() target/rx: Collect all bytes during disassembly target/rx: Dump bytes for each insn during disassembly hw/rx: Honor -accel qtest Yoshinori Sato (11): target/rx: TCG translation target/rx: TCG helper target/rx: CPU definition target/rx: RX disassembler hw/intc: RX62N interrupt controller (ICUa) hw/timer: RX62N internal timer modules hw/char: RX62N serial communication interface (SCI) hw/rx: RX Target hardware definition qemu/bitops.h: Add extract8 and extract16 Add rx-softmmu MAINTAINERS: Add RX MAINTAINERS | 19 + arch_init.c | 2 + configure | 8 + default-configs/rx-softmmu.mak | 3 + hw/Kconfig | 1 + hw/char/Kconfig | 3 + hw/char/Makefile.objs | 1 + hw/char/renesas_sci.c | 340 ++++ hw/intc/Kconfig | 3 + hw/intc/Makefile.objs | 1 + hw/intc/rx_icu.c | 376 ++++ hw/rx/Kconfig | 14 + hw/rx/Makefile.objs | 2 + hw/rx/rx-virt.c | 113 ++ hw/rx/rx62n.c | 246 +++ hw/timer/Kconfig | 6 + hw/timer/Makefile.objs | 3 + hw/timer/renesas_cmt.c | 275 +++ hw/timer/renesas_tmr.c | 455 +++++ include/disas/dis-asm.h | 5 + include/exec/poison.h | 1 + include/hw/char/renesas_sci.h | 45 + include/hw/intc/rx_icu.h | 56 + include/hw/registerfields.h | 32 +- include/hw/rx/rx.h | 7 + include/hw/rx/rx62n.h | 91 + include/hw/timer/renesas_cmt.h | 38 + include/hw/timer/renesas_tmr.h | 53 + include/qemu/bitops.h | 38 + include/sysemu/arch_init.h | 1 + qapi/common.json | 3 +- target/rx/Makefile.objs | 12 + target/rx/cpu-qom.h | 42 + target/rx/cpu.c | 252 +++ target/rx/cpu.h | 201 ++ target/rx/disas.c | 1446 ++++++++++++++ target/rx/gdbstub.c | 112 ++ target/rx/helper.c | 148 ++ target/rx/helper.h | 31 + target/rx/insns.decode | 621 ++++++ target/rx/monitor.c | 38 + target/rx/op_helper.c | 470 +++++ target/rx/translate.c | 2432 ++++++++++++++++++++++++ tests/acceptance/boot_linux_console.py | 51 + tests/machine-none-test.c | 1 + 45 files changed, 8096 insertions(+), 2 deletions(-) create mode 100644 default-configs/rx-softmmu.mak create mode 100644 hw/char/renesas_sci.c create mode 100644 hw/intc/rx_icu.c create mode 100644 hw/rx/Kconfig create mode 100644 hw/rx/Makefile.objs create mode 100644 hw/rx/rx-virt.c create mode 100644 hw/rx/rx62n.c create mode 100644 hw/timer/renesas_cmt.c create mode 100644 hw/timer/renesas_tmr.c create mode 100644 include/hw/char/renesas_sci.h create mode 100644 include/hw/intc/rx_icu.h create mode 100644 include/hw/rx/rx.h create mode 100644 include/hw/rx/rx62n.h create mode 100644 include/hw/timer/renesas_cmt.h create mode 100644 include/hw/timer/renesas_tmr.h create mode 100644 target/rx/Makefile.objs create mode 100644 target/rx/cpu-qom.h create mode 100644 target/rx/cpu.c create mode 100644 target/rx/cpu.h create mode 100644 target/rx/disas.c create mode 100644 target/rx/gdbstub.c create mode 100644 target/rx/helper.c create mode 100644 target/rx/helper.h create mode 100644 target/rx/insns.decode create mode 100644 target/rx/monitor.c create mode 100644 target/rx/op_helper.c create mode 100644 target/rx/translate.c -- 2.20.1
Patchew URL: https://patchew.org/QEMU/20190611113731.16940-1-philmd@redhat.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base" # branch set -e CC=$HOME/bin/cc INSTALL=$PWD/install BUILD=$PWD/build mkdir -p $BUILD $INSTALL SRC=$PWD cd $BUILD $SRC/configure --cc=$CC --prefix=$INSTALL make -j4 # XXX: we need reliable clean up # make check -j4 V=1 make install echo echo "=== ENV ===" env echo echo "=== PACKAGES ===" rpm -qa === TEST SCRIPT END === CC riscv32-softmmu/dump.o In file included from /var/tmp/patchew-tester-tmp-qtsaqt50/src/target/rx/cpu.h:31, from /var/tmp/patchew-tester-tmp-qtsaqt50/src/exec.c:23: /var/tmp/patchew-tester-tmp-qtsaqt50/src/include/exec/cpu-defs.h:38:10: fatal error: cpu-param.h: No such file or directory 38 | #include "cpu-param.h" | ^~~~~~~~~~~~~ compilation terminated. The full log is available at http://patchew.org/logs/20190611113731.16940-1-philmd@redhat.com/testing.s390x/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190611113731.16940-1-philmd@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support Type: series Message-id: 20190611113731.16940-1-philmd@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu t [tag update] patchew/20190611113731.16940-1-philmd@redhat.com -> patchew/20190611113731.16940-1-philmd@redhat.com Switched to a new branch 'test' 317f420e9c BootLinuxConsoleTest: Test the RX-Virt machine 46da289cdf MAINTAINERS: Add RX 2704b207bd Add rx-softmmu c55f2b26ed hw/registerfields.h: Add 8bit and 16bit register macros 895d810896 qemu/bitops.h: Add extract8 and extract16 0c6f47d495 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 2bd3bfc71c hw/rx: Honor -accel qtest 95cba7fab4 hw/rx: RX Target hardware definition c3722db947 hw/char: RX62N serial communication interface (SCI) aac94a1b90 hw/timer: RX62N internal timer modules 09c5203a18 hw/intc: RX62N interrupt controller (ICUa) 261816367b target/rx: Dump bytes for each insn during disassembly 65e6b8e8e1 target/rx: Collect all bytes during disassembly b85370af0c target/rx: Emit all disassembly in one prt() 317ee2b1e9 target/rx: Use prt_ldmi for XCHG_mr disassembly ade5bec5af target/rx: Replace operand with prt_ldmi in disassembler 55b02dec27 target/rx: Disassemble rx_index_addr into a string 3313d95145 target/rx: RX disassembler 1574eeedc9 target/rx: CPU definition d55b90871b target/rx: TCG helper 9ac51ee4c5 target/rx: TCG translation === OUTPUT BEGIN === 1/21 Checking commit 9ac51ee4c5a9 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 1/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/21 Checking commit d55b90871bb6 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 2/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/21 Checking commit 1574eeedc93e (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 645 lines checked Patch 3/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/21 Checking commit 3313d951455c (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 4/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/21 Checking commit 55b02dec27cc (target/rx: Disassemble rx_index_addr into a string) 6/21 Checking commit ade5bec5af34 (target/rx: Replace operand with prt_ldmi in disassembler) 7/21 Checking commit 317ee2b1e9cb (target/rx: Use prt_ldmi for XCHG_mr disassembly) 8/21 Checking commit b85370af0cee (target/rx: Emit all disassembly in one prt()) 9/21 Checking commit 65e6b8e8e1ec (target/rx: Collect all bytes during disassembly) 10/21 Checking commit 261816367bd9 (target/rx: Dump bytes for each insn during disassembly) 11/21 Checking commit 09c5203a18fa (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/21 Checking commit aac94a1b90a8 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 12/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/21 Checking commit c3722db9470e (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/21 Checking commit 95cba7fab4c5 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 457 lines checked Patch 14/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/21 Checking commit 2bd3bfc71cca (hw/rx: Honor -accel qtest) 16/21 Checking commit 0c6f47d495ab (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 17/21 Checking commit 895d8108961c (qemu/bitops.h: Add extract8 and extract16) 18/21 Checking commit c55f2b26ed2d (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 18/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/21 Checking commit 2704b207bda8 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 19/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/21 Checking commit 46da289cdff8 (MAINTAINERS: Add RX) 21/21 Checking commit 317f420e9c3e (BootLinuxConsoleTest: Test the RX-Virt machine) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190611113731.16940-1-philmd@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190611113731.16940-1-philmd@redhat.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base" # branch set -e CC=$HOME/bin/cc INSTALL=$PWD/install BUILD=$PWD/build mkdir -p $BUILD $INSTALL SRC=$PWD cd $BUILD $SRC/configure --cc=$CC --prefix=$INSTALL make -j4 # XXX: we need reliable clean up # make check -j4 V=1 make install echo echo "=== ENV ===" env echo echo "=== PACKAGES ===" rpm -qa === TEST SCRIPT END === CC ppc64-softmmu/accel/tcg/tcg-runtime-gvec.o In file included from /var/tmp/patchew-tester-tmp-l4v9bowf/src/target/rx/cpu.h:31, from /var/tmp/patchew-tester-tmp-l4v9bowf/src/exec.c:23: /var/tmp/patchew-tester-tmp-l4v9bowf/src/include/exec/cpu-defs.h:38:10: fatal error: cpu-param.h: No such file or directory 38 | #include "cpu-param.h" | ^~~~~~~~~~~~~ compilation terminated. The full log is available at http://patchew.org/logs/20190611113731.16940-1-philmd@redhat.com/testing.s390x/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190611113731.16940-1-philmd@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support Type: series Message-id: 20190611113731.16940-1-philmd@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu t [tag update] patchew/20190611113731.16940-1-philmd@redhat.com -> patchew/20190611113731.16940-1-philmd@redhat.com Switched to a new branch 'test' 58a573e6f3 BootLinuxConsoleTest: Test the RX-Virt machine 918428885e MAINTAINERS: Add RX 89799721e3 Add rx-softmmu f7f4625475 hw/registerfields.h: Add 8bit and 16bit register macros 6daadfe34a qemu/bitops.h: Add extract8 and extract16 0487222cc3 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 8a072d9cbd hw/rx: Honor -accel qtest 7436a614ae hw/rx: RX Target hardware definition 3fe9feaaa1 hw/char: RX62N serial communication interface (SCI) e5fa50acc3 hw/timer: RX62N internal timer modules 4d169ff249 hw/intc: RX62N interrupt controller (ICUa) 022078a0f7 target/rx: Dump bytes for each insn during disassembly 45adab31f7 target/rx: Collect all bytes during disassembly 9aff31efc4 target/rx: Emit all disassembly in one prt() 68d849ace3 target/rx: Use prt_ldmi for XCHG_mr disassembly 7e6d45f225 target/rx: Replace operand with prt_ldmi in disassembler 3967775d29 target/rx: Disassemble rx_index_addr into a string b679fbb1df target/rx: RX disassembler 2573ca0cc1 target/rx: CPU definition 64cf4c358f target/rx: TCG helper 694178d9a4 target/rx: TCG translation === OUTPUT BEGIN === 1/21 Checking commit 694178d9a413 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 1/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/21 Checking commit 64cf4c358ff3 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 2/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/21 Checking commit 2573ca0cc1e9 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 645 lines checked Patch 3/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/21 Checking commit b679fbb1df50 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 4/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/21 Checking commit 3967775d2986 (target/rx: Disassemble rx_index_addr into a string) 6/21 Checking commit 7e6d45f225f8 (target/rx: Replace operand with prt_ldmi in disassembler) 7/21 Checking commit 68d849ace328 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 8/21 Checking commit 9aff31efc4bc (target/rx: Emit all disassembly in one prt()) 9/21 Checking commit 45adab31f7e4 (target/rx: Collect all bytes during disassembly) 10/21 Checking commit 022078a0f706 (target/rx: Dump bytes for each insn during disassembly) 11/21 Checking commit 4d169ff2494a (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/21 Checking commit e5fa50acc396 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 12/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/21 Checking commit 3fe9feaaa1d1 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/21 Checking commit 7436a614ae29 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 457 lines checked Patch 14/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/21 Checking commit 8a072d9cbd6d (hw/rx: Honor -accel qtest) 16/21 Checking commit 0487222cc332 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 17/21 Checking commit 6daadfe34af6 (qemu/bitops.h: Add extract8 and extract16) 18/21 Checking commit f7f4625475a2 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 18/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/21 Checking commit 89799721e37a (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 19/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/21 Checking commit 918428885e8b (MAINTAINERS: Add RX) 21/21 Checking commit 58a573e6f38e (BootLinuxConsoleTest: Test the RX-Virt machine) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190611113731.16940-1-philmd@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190611113731.16940-1-philmd@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190611113731.16940-1-philmd@redhat.com Subject: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 54dc0dd BootLinuxConsoleTest: Test the RX-Virt machine a650693 MAINTAINERS: Add RX bb5922e Add rx-softmmu 57efd99 hw/registerfields.h: Add 8bit and 16bit register macros a043825 qemu/bitops.h: Add extract8 and extract16 b3d9518 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core dd0b312 hw/rx: Honor -accel qtest 7af162f hw/rx: RX Target hardware definition 52cee25 hw/char: RX62N serial communication interface (SCI) bf4a215 hw/timer: RX62N internal timer modules 51cf815 hw/intc: RX62N interrupt controller (ICUa) e0a06ae target/rx: Dump bytes for each insn during disassembly cda7b7d target/rx: Collect all bytes during disassembly 75be3f5 target/rx: Emit all disassembly in one prt() a4bbc9b target/rx: Use prt_ldmi for XCHG_mr disassembly 0d03cf7 target/rx: Replace operand with prt_ldmi in disassembler efe02d6 target/rx: Disassemble rx_index_addr into a string 268ed0e target/rx: RX disassembler 4b87235 target/rx: CPU definition 8893379 target/rx: TCG helper adee91c target/rx: TCG translation === OUTPUT BEGIN === 1/21 Checking commit adee91cee710 (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 1/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/21 Checking commit 8893379be728 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 2/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/21 Checking commit 4b8723519d74 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 645 lines checked Patch 3/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/21 Checking commit 268ed0ed5bed (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 4/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/21 Checking commit efe02d640116 (target/rx: Disassemble rx_index_addr into a string) 6/21 Checking commit 0d03cf7c4dea (target/rx: Replace operand with prt_ldmi in disassembler) 7/21 Checking commit a4bbc9b6f906 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 8/21 Checking commit 75be3f594a61 (target/rx: Emit all disassembly in one prt()) 9/21 Checking commit cda7b7deb78a (target/rx: Collect all bytes during disassembly) 10/21 Checking commit e0a06ae5bb91 (target/rx: Dump bytes for each insn during disassembly) 11/21 Checking commit 51cf8153697c (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/21 Checking commit bf4a2154e409 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 12/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/21 Checking commit 52cee25bb159 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/21 Checking commit 7af162fcb6fc (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 457 lines checked Patch 14/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/21 Checking commit dd0b312cbbf0 (hw/rx: Honor -accel qtest) 16/21 Checking commit b3d951869f12 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 17/21 Checking commit a043825aeef2 (qemu/bitops.h: Add extract8 and extract16) 18/21 Checking commit 57efd991b11b (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 18/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/21 Checking commit bb5922e03944 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 19/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/21 Checking commit a650693b9b8f (MAINTAINERS: Add RX) 21/21 Checking commit 54dc0ddfce91 (BootLinuxConsoleTest: Test the RX-Virt machine) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190611113731.16940-1-philmd@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190611113731.16940-1-philmd@redhat.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base" # branch set -e CC=$HOME/bin/cc INSTALL=$PWD/install BUILD=$PWD/build mkdir -p $BUILD $INSTALL SRC=$PWD cd $BUILD $SRC/configure --cc=$CC --prefix=$INSTALL make -j4 # XXX: we need reliable clean up # make check -j4 V=1 make install echo echo "=== ENV ===" env echo echo "=== PACKAGES ===" rpm -qa === TEST SCRIPT END === CC rx-softmmu/exec.o In file included from /var/tmp/patchew-tester-tmp-qkxrldtb/src/target/rx/cpu.h:31, from /var/tmp/patchew-tester-tmp-qkxrldtb/src/exec.c:23: /var/tmp/patchew-tester-tmp-qkxrldtb/src/include/exec/cpu-defs.h:38:10: fatal error: cpu-param.h: No such file or directory 38 | #include "cpu-param.h" | ^~~~~~~~~~~~~ compilation terminated. The full log is available at http://patchew.org/logs/20190611113731.16940-1-philmd@redhat.com/testing.s390x/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190611113731.16940-1-philmd@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support Type: series Message-id: 20190611113731.16940-1-philmd@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu t [tag update] patchew/20190611113731.16940-1-philmd@redhat.com -> patchew/20190611113731.16940-1-philmd@redhat.com Switched to a new branch 'test' e70c9a6cf7 BootLinuxConsoleTest: Test the RX-Virt machine 73390864df MAINTAINERS: Add RX f1c1d89045 Add rx-softmmu fe080a5d97 hw/registerfields.h: Add 8bit and 16bit register macros 84492a1c42 qemu/bitops.h: Add extract8 and extract16 ccbd0067c6 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 0b80c9380d hw/rx: Honor -accel qtest d4fce4d13b hw/rx: RX Target hardware definition 0c06063d0e hw/char: RX62N serial communication interface (SCI) edd009a215 hw/timer: RX62N internal timer modules a4488f79be hw/intc: RX62N interrupt controller (ICUa) 54c515fb2a target/rx: Dump bytes for each insn during disassembly c982b91035 target/rx: Collect all bytes during disassembly c430ed068c target/rx: Emit all disassembly in one prt() 3da99a6859 target/rx: Use prt_ldmi for XCHG_mr disassembly 50f2803038 target/rx: Replace operand with prt_ldmi in disassembler b8c3705eea target/rx: Disassemble rx_index_addr into a string dc265bd950 target/rx: RX disassembler ced4a3cd43 target/rx: CPU definition 4b8d4b55da target/rx: TCG helper 589682dbfc target/rx: TCG translation === OUTPUT BEGIN === 1/21 Checking commit 589682dbfc1b (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 1/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/21 Checking commit 4b8d4b55da67 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 2/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/21 Checking commit ced4a3cd43a8 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 645 lines checked Patch 3/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/21 Checking commit dc265bd95076 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 4/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/21 Checking commit b8c3705eea7f (target/rx: Disassemble rx_index_addr into a string) 6/21 Checking commit 50f280303836 (target/rx: Replace operand with prt_ldmi in disassembler) 7/21 Checking commit 3da99a68592f (target/rx: Use prt_ldmi for XCHG_mr disassembly) 8/21 Checking commit c430ed068cff (target/rx: Emit all disassembly in one prt()) 9/21 Checking commit c982b9103598 (target/rx: Collect all bytes during disassembly) 10/21 Checking commit 54c515fb2a8e (target/rx: Dump bytes for each insn during disassembly) 11/21 Checking commit a4488f79be75 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/21 Checking commit edd009a21569 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 12/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/21 Checking commit 0c06063d0e11 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/21 Checking commit d4fce4d13bb7 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 457 lines checked Patch 14/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/21 Checking commit 0b80c9380d08 (hw/rx: Honor -accel qtest) 16/21 Checking commit ccbd0067c656 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 17/21 Checking commit 84492a1c42fa (qemu/bitops.h: Add extract8 and extract16) 18/21 Checking commit fe080a5d9792 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 18/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/21 Checking commit f1c1d8904541 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 19/21 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/21 Checking commit 73390864df77 (MAINTAINERS: Add RX) 21/21 Checking commit e70c9a6cf719 (BootLinuxConsoleTest: Test the RX-Virt machine) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190611113731.16940-1-philmd@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
© 2016 - 2024 Red Hat, Inc.