From nobody Fri Apr 19 13:24:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1560236054; cv=none; d=zoho.com; s=zohoarc; b=CAdIReQHXVU3qLWTtwKvscKeL8G1TwfRmjyAZd/j47MFgbJcJRrg/3OYqpf16L7ujThnDPGXtnP+KUin7Z1O1hsn925aNVXjlZFaUf4uFGDnWR/LWmOY7tKCElcxUQgVh0r2ZiziCa/dDiGyu2WVCzAwMx6ePj3GUlvFJCWw5DE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560236054; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=eWBhgm2zVmJUDbi8/a4Qev0eiX6EgMAeE8zteuGZomo=; b=VHbspLdedpe55FsYpnjn/yjBB7FoNWFdBxpKfw2ZXeYuUz6zIewrozY2eMsy+36acSakzL4OMex2AtX+DMQa0tfCRvbGaxWkX4jfyehw0m/ItYqQHr5qXJdzw6kEi4ALkzvTP5o4w6ymO/8BcCrn8itdh4/7HyT9okYhQSM+8XI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15602360545031003.8623790895405; Mon, 10 Jun 2019 23:54:14 -0700 (PDT) Received: from localhost ([::1]:52182 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haafV-0005nG-CT for importer@patchew.org; Tue, 11 Jun 2019 02:54:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56435) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haaew-0005Iv-Gk for qemu-devel@nongnu.org; Tue, 11 Jun 2019 02:53:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1haaev-0007O2-Ga for qemu-devel@nongnu.org; Tue, 11 Jun 2019 02:53:30 -0400 Received: from mga17.intel.com ([192.55.52.151]:16010) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1haaev-0007JR-8n; Tue, 11 Jun 2019 02:53:29 -0400 Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jun 2019 23:53:21 -0700 Received: from npg-dpdk-virtio-tbie-2.sh.intel.com ([10.67.104.151]) by fmsmga006.fm.intel.com with ESMTP; 10 Jun 2019 23:53:20 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 From: Tiwei Bie To: mst@redhat.com, jasowang@redhat.com Date: Tue, 11 Jun 2019 14:51:37 +0800 Message-Id: <20190611065137.16329-1-tiwei.bie@intel.com> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.151 Subject: [Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The VIRTIO_NET_F_CTRL_VLAN feature requires the support of vhost-user backend. But it will be advertised to guest driver as long as it's enabled by users in QEMU, while it's not supported by vhost-user backend. This patch fixes this issue. Fixes: 72018d1e1917 ("vhost-user: ignore qemu-only features") Cc: qemu-stable@nongnu.org Signed-off-by: Tiwei Bie --- It's not clear in the spec that, whether vlan filtering is also best-effort: https://github.com/oasis-tcs/virtio-spec/blob/37057052e7/content.tex#L3372 hw/net/vhost_net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index a6b719035c..1444fc9230 100644 --- a/hw/net/vhost_net.c +++ b/hw/net/vhost_net.c @@ -75,6 +75,8 @@ static const int user_feature_bits[] =3D { VIRTIO_NET_F_MTU, VIRTIO_F_IOMMU_PLATFORM, =20 + VIRTIO_NET_F_CTRL_VLAN, + /* This bit implies RARP isn't sent by QEMU out of band */ VIRTIO_NET_F_GUEST_ANNOUNCE, =20 --=20 2.17.1