From nobody Mon May 20 14:56:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559936256; cv=none; d=zoho.com; s=zohoarc; b=RuXcE0O+Cuq1fpbJgUkDXAKF9R1CtHTHhRZFioKdDOD4umwjc1i767cCkjpCJik/dbT1tqOKEbygycXzMIhA2syeW1eKoJqR3G53P0FcYJgiudOiDHn+peUqCZxL7deQPgAvWSQP6xwXe5l7AuqwMC9KUlTt3daRKeUSCIVa59k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559936256; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=ynSd9rK08uQvY8Kb/itX0VUfAti4Ymlr2Zp2wBE4Exc=; b=k4/iD2x72jQYWQwxJYM67R3QdiuDmrrJ5KKUI2JmGfxoYx/jD8J32Gx3CdCygxX/u/aqA0cQTPftfNNS9OCxPK4f+Oz4ZO2nOEO4xZkMQYW7tc1WJXKvzvz+E+VkbTKhr9n/IaIxm+O/WnPTzOT1O7TI32rYHWmvlVSNoOJBmvw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559936256892733.7997661954133; Fri, 7 Jun 2019 12:37:36 -0700 (PDT) Received: from localhost ([::1]:51840 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZKg6-0003Ei-RO for importer@patchew.org; Fri, 07 Jun 2019 15:37:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51873) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZJfN-0006Cy-I6 for qemu-devel@nongnu.org; Fri, 07 Jun 2019 14:32:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZJfJ-0000QK-Jv for qemu-devel@nongnu.org; Fri, 07 Jun 2019 14:32:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57514) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hZJfH-0000N2-VI for qemu-devel@nongnu.org; Fri, 07 Jun 2019 14:32:36 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF7B318DF7C; Fri, 7 Jun 2019 18:32:34 +0000 (UTC) Received: from localhost (ovpn-116-9.gru2.redhat.com [10.97.116.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 72D267D656; Fri, 7 Jun 2019 18:32:34 +0000 (UTC) From: Eduardo Habkost To: Peter Maydell , qemu-devel@nongnu.org, Marcel Apfelbaum Date: Fri, 7 Jun 2019 15:32:27 -0300 Message-Id: <20190607183228.22454-2-ehabkost@redhat.com> In-Reply-To: <20190607183228.22454-1-ehabkost@redhat.com> References: <20190607183228.22454-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 07 Jun 2019 18:32:34 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 1/2] numa: improve cpu hotplug error message with a wrong node-id X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Laurent Vivier On pseries, core-ids are strongly binded to a node-id by the command line option. If an user tries to add a CPU to the wrong node, he has an error but it is not really helpful: qemu-system-ppc64 ... -smp 1,maxcpus=3D64,cores=3D1,threads=3D1,sockets= =3D1 \ -numa node,nodeid=3D0 -numa node,nodeid=3D1 ... (qemu) device_add power9_v2.0-spapr-cpu-core,core-id=3D30,node-id=3D1 Error: node-id=3D1 must match numa node specified with -numa option This patch improves this error message by giving to the user the good node-id to use with the core-id he's providing Error: invalid node-id, must be 0 Signed-off-by: Laurent Vivier Message-Id: <20190529160747.778-1-lvivier@redhat.com> Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- numa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/numa.c b/numa.c index 3875e1efda..955ec0c830 100644 --- a/numa.c +++ b/numa.c @@ -470,8 +470,8 @@ void numa_cpu_pre_plug(const CPUArchId *slot, DeviceSta= te *dev, Error **errp) "node-id", errp); } } else if (node_id !=3D slot->props.node_id) { - error_setg(errp, "node-id=3D%d must match numa node specified " - "with -numa option", node_id); + error_setg(errp, "invalid node-id, must be %"PRId64, + slot->props.node_id); } } =20 --=20 2.18.0.rc1.1.g3f1ff2140 From nobody Mon May 20 14:56:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559938080; cv=none; d=zoho.com; s=zohoarc; b=Gzr3StYNNn8t5abOcc2Um+2Yw1JE3zrnOuPpT19M9R+z0Ro6HFD044NVgWPO3RkxD+Tgws6z1hjo15xg+qqaEN1eaFCHumwhA6Nd70pHDb6xdbRy8m2R2Od/+wKD96TSW0/w1gsavZt+3a26umq/49COfzsYAPNdzyc2YmZsqUQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559938080; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=FWjVNQGE43Nuct9IsgC6x3FtYFFQr9J1MqRC/SrXEpA=; b=Gkwniv3GQPN1xlRBmcaGgwu9fj2ryJZPqFxOdwNc9gSd72gdVq73sJVdiqjDmUEaVLZwnIV+ggV0xyl46c2OHapYiPDZwT0+0x3RKs0w5trO7srFqmZTGg5OQzVg7q2iJDJyNN3CT5Kztmr1womuTESGNQ+2aWZycDqnEWWKLWM= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559938080221962.7589892278306; Fri, 7 Jun 2019 13:08:00 -0700 (PDT) Received: from localhost ([::1]:52616 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZL9Q-0007ag-RL for importer@patchew.org; Fri, 07 Jun 2019 16:07:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51964) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZJfv-0006cv-DS for qemu-devel@nongnu.org; Fri, 07 Jun 2019 14:33:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZJfr-0000zF-JG for qemu-devel@nongnu.org; Fri, 07 Jun 2019 14:33:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49474) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hZJfj-0000qG-W9 for qemu-devel@nongnu.org; Fri, 07 Jun 2019 14:33:07 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 087AB104C1; Fri, 7 Jun 2019 18:32:39 +0000 (UTC) Received: from localhost (ovpn-116-9.gru2.redhat.com [10.97.116.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5893061373; Fri, 7 Jun 2019 18:32:36 +0000 (UTC) From: Eduardo Habkost To: Peter Maydell , qemu-devel@nongnu.org, Marcel Apfelbaum Date: Fri, 7 Jun 2019 15:32:28 -0300 Message-Id: <20190607183228.22454-3-ehabkost@redhat.com> In-Reply-To: <20190607183228.22454-1-ehabkost@redhat.com> References: <20190607183228.22454-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 07 Jun 2019 18:32:47 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 2/2] accel: Remove unused AccelClass::opt_name attribute X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Wainer dos Santos Moschetta Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Wainer dos Santos Moschetta The AccelType type was converted to AccelClass QOM object on b14a0b7469f, and the original data type had a field to store the option name which in turn was used to search an accelerator. The lookup method (accel_find) changed too, making the option field unnecessary but it became AccelClass::opt_name despite that. Therefore, and given that none accelerator implementation sets AccelClass::opt_name, let's remove this attribute. Signed-off-by: Wainer dos Santos Moschetta Message-Id: <20190531165334.20403-2-wainersm@redhat.com> Signed-off-by: Eduardo Habkost --- include/sysemu/accel.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/sysemu/accel.h b/include/sysemu/accel.h index 70e9e2f2a1..81293cdb08 100644 --- a/include/sysemu/accel.h +++ b/include/sysemu/accel.h @@ -36,7 +36,6 @@ typedef struct AccelClass { ObjectClass parent_class; /*< public >*/ =20 - const char *opt_name; const char *name; int (*init_machine)(MachineState *ms); void (*setup_post)(MachineState *ms, AccelState *accel); --=20 2.18.0.rc1.1.g3f1ff2140