From nobody Mon Feb 9 08:11:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559918787; cv=none; d=zoho.com; s=zohoarc; b=NlWW7AOI7PZoQ2P21rEmKRy/Dt2oUQlD8GhlQGzxVhblEuij5pa9gWmkRoyA7EVuNJ1BQmS5QeMLipwb9a/tqfTXZDa1b4vlw/rb+TQ8dU3W0BrnAYl/sO4gYHhtmsNJXhHzL2w0mdun246mSMHO4l941xLdw1ZI9QAeyvAnU1Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559918787; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=RXz4AFbPUEU8r8Fytr+jp18YH/DKycFQrfB2w0gXHQo=; b=hFEoNZXfUGVk8kgCxCj6zG7H8ZVZ212lQ12XjIozMOYb0xdNAqEva3HvBZ0+8uXrFKpXtuYveFFlIRwWVxTDkhCCoQo9FrVVqyoJUGejxTsClPnjQt0CV2pYatiBWBtXv8UdMWSP5PlIO9engSysm3nxYyM8tPtsdR6tFBdxyW0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559918787864826.2911103533835; Fri, 7 Jun 2019 07:46:27 -0700 (PDT) Received: from localhost ([::1]:48398 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZG8H-0006ow-S8 for importer@patchew.org; Fri, 07 Jun 2019 10:46:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52929) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZFh8-0003Wn-Tv for qemu-devel@nongnu.org; Fri, 07 Jun 2019 10:18:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZFh6-0003DQ-DA for qemu-devel@nongnu.org; Fri, 07 Jun 2019 10:18:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56610) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hZFh4-000351-FY; Fri, 07 Jun 2019 10:18:12 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B06A330C318C; Fri, 7 Jun 2019 14:18:08 +0000 (UTC) Received: from localhost (dhcp-192-191.str.redhat.com [10.33.192.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C0E7A842B9; Fri, 7 Jun 2019 14:18:03 +0000 (UTC) From: Cornelia Huck To: Peter Maydell Date: Fri, 7 Jun 2019 16:17:02 +0200 Message-Id: <20190607141727.29018-10-cohuck@redhat.com> In-Reply-To: <20190607141727.29018-1-cohuck@redhat.com> References: <20190607141727.29018-1-cohuck@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 07 Jun 2019 14:18:08 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL v2 09/34] s390x/tcg: Fix max_byte detection for stfle X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org, Richard Henderson , qemu-devel@nongnu.org, David Hildenbrand Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: David Hildenbrand used_stfl_bytes is 0, before initialized via prepare_stfl() on the first invocation. We have to move the calculation of max_bytes after prepare_stfl(). Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/misc_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c index ee67c1fa0c51..34476134a407 100644 --- a/target/s390x/misc_helper.c +++ b/target/s390x/misc_helper.c @@ -669,7 +669,7 @@ uint32_t HELPER(stfle)(CPUS390XState *env, uint64_t add= r) { const uintptr_t ra =3D GETPC(); const int count_bytes =3D ((env->regs[0] & 0xff) + 1) * 8; - const int max_bytes =3D ROUND_UP(used_stfl_bytes, 8); + int max_bytes; int i; =20 if (addr & 0x7) { @@ -677,6 +677,7 @@ uint32_t HELPER(stfle)(CPUS390XState *env, uint64_t add= r) } =20 prepare_stfl(); + max_bytes =3D ROUND_UP(used_stfl_bytes, 8); for (i =3D 0; i < count_bytes; ++i) { cpu_stb_data_ra(env, addr + i, stfl_bytes[i], ra); } --=20 2.20.1