From nobody Wed May 15 13:43:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) client-ip=209.51.188.47; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559856836; cv=none; d=zoho.com; s=zohoarc; b=MYCy9L1X56hV1gIyj8Ye3es+sxtze/0oTJX1eZ9kP6UKtntSAC7kh3r2q7cL40azG6BUxZbil7CeLysg+pjBu0Wc9oylONtze6yLp/FgU61+HfYJxhPGH9B/dGVDJmvzy14oAFdpubFF9um/yuck4/XY6i2nOvkPUljR45xEwIU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559856836; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=zt56XlPok/IsZNGZfKCtzU8l2+H0c2I1CvOrN3gdqNY=; b=TCyhGgVbFcrynZ9NGOjFEHkXkQI0HyG39noqQwt52wYUExUCA3xVJ4e9JXOHbeqOiJNPNahg+PeWpTXiFZ6JN5FlVeGTRoPtDtaPfLXzvn/E1MngDX9TI17CN+R6vfdJpNBy3lwxHhiyjDii3Q/WQBtO8pP2C1Fb7bwvPIgHwCY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.47]) by mx.zohomail.com with SMTPS id 1559856836498677.7861967534297; Thu, 6 Jun 2019 14:33:56 -0700 (PDT) Received: from localhost ([::1]:42902 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZ018-0001oR-5h for importer@patchew.org; Thu, 06 Jun 2019 17:33:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51796) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hYzu9-0005vo-CY for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:26:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYziR-0007xg-Rw for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:14:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44848) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYziR-0007ut-Ih for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:14:31 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 61DA33092654; Thu, 6 Jun 2019 21:14:24 +0000 (UTC) Received: from dhcp-17-47.bos.redhat.com (dhcp-17-47.bos.redhat.com [10.18.17.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6D8E6108420A; Thu, 6 Jun 2019 21:14:21 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Date: Thu, 6 Jun 2019 17:14:08 -0400 Message-Id: <20190606211414.8681-2-crosa@redhat.com> In-Reply-To: <20190606211414.8681-1-crosa@redhat.com> References: <20190606211414.8681-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Thu, 06 Jun 2019 21:14:29 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v6 1/7] Acceptance tests: use relative location for tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Cornelia Huck , Wainer dos Santos Moschetta , Cleber Rosa , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Samuel Ortiz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" An Avocado Test ID[1] is composed by a number of components, but it starts with the Test Name, usually a file system location that was given to the loader. Because the source directory is being given as a prefix to the "tests/acceptance" directory containing the acceptance tests, the test names will needlessly include the directory the user is using to host the QEMU sources (and/or build tree). Let's remove the source dir (or a build dir) from the path given to the test loader. This should give more constant names, and when using result servers and databases, it should give the same test names across executions from different people or from different directories. [1] - https://avocado-framework.readthedocs.io/en/69.0/ReferenceGuide.html#= test-id Signed-off-by: Cleber Rosa --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 0cd5f465b7..991ad05aea 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -1147,7 +1147,7 @@ check-acceptance: check-venv $(TESTS_RESULTS_DIR) --show=3D$(AVOCADO_SHOW) run --job-results-dir=3D$(TESTS_RESUL= TS_DIR) \ --filter-by-tags-include-empty --filter-by-tags-include-empty-= key \ $(AVOCADO_TAGS) \ - --failfast=3Don $(SRC_PATH)/tests/acceptance, \ + --failfast=3Don tests/acceptance, \ "AVOCADO", "tests/acceptance") =20 # Consolidated targets --=20 2.21.0 From nobody Wed May 15 13:43:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) client-ip=209.51.188.47; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559856551; cv=none; d=zoho.com; s=zohoarc; b=DEb+/PiK3EYDKC5W8K4qsPnkXjGyfzpk3raNhCEBt0JOg3B1Sc6tsS2TtNBTGMEsJaVrjZxOV+A60XxPVempU4Pz6GA2kPwlNFqJmNHmyGFR2yqMielsM5wiqi9tv9l/IlwBDXc1XWjFyFUDFVLaJxrfWjwkLwM/NClPe50LaQI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559856551; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=EzdLaHNnDxPtolfDPnnQCKUjrvkBTK/mYD13Kit8+6o=; b=PT6zJdNzitKeA5h2NOHW3+NSJa/jAAlKLaCCz1UsaJakYQtqQJxvenqv2M4DjiJ+eicw+FNTunGntamlObn/u8afzJx8Ezxt0F0PSfeCPoXCdyB5h7Gbh99w4bdA0+3lowhs1YtviSoGM9cQT5EdOAW5cpJO8jgYh/zcOjY9WGo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.47 [209.51.188.47]) by mx.zohomail.com with SMTPS id 1559856551094692.9503194907453; Thu, 6 Jun 2019 14:29:11 -0700 (PDT) Received: from localhost ([::1]:42226 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hYzwD-0007lR-3x for importer@patchew.org; Thu, 06 Jun 2019 17:28:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51627) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hYzu5-0005bq-H6 for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:26:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYziZ-00087T-Ga for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:14:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46622) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYziZ-00086O-9Z for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:14:39 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7A463C0624A1; Thu, 6 Jun 2019 21:14:25 +0000 (UTC) Received: from dhcp-17-47.bos.redhat.com (dhcp-17-47.bos.redhat.com [10.18.17.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 83634108F832; Thu, 6 Jun 2019 21:14:24 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Date: Thu, 6 Jun 2019 17:14:09 -0400 Message-Id: <20190606211414.8681-3-crosa@redhat.com> In-Reply-To: <20190606211414.8681-1-crosa@redhat.com> References: <20190606211414.8681-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 06 Jun 2019 21:14:31 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v6 2/7] Acceptance tests: keep a stable reference to the QEMU build dir X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Cornelia Huck , Wainer dos Santos Moschetta , Cleber Rosa , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Samuel Ortiz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This is related to the the differences in in-tree and out-of-tree builds in QEMU. For simplification, means my build directory. Currently, by running a `make check-acceptance` one gets (in tests/acceptance/avocado_qemu/__init__.py): SRC_ROOT_DIR: /tests/acceptance/avocado_qemu/../../.. This in itself is problematic, because after the parent directories are applied, one may be left not with a pointer to the build directory as intended, but with the location of the source tree (assuming they differ). Built binaries, such as qemu-img, are of course not there and can't be found. Given that a Python '__file__' will contain the absolute path to the file backing the module, say: __file__: /tests/acceptance/avocado_qemu/__init__.py | 4 | 3 | 2 | 1 | A solution is to not "evaluate" the third parent dir (marked as 4 here) because that ends up following the "tests" directory symlink to the source tree. In fact, there's no need to keep or evaluate any of the parent directories, we can just drop the rightmost 4 components, and we'll keep a stable reference to the build directory (with no symlink being followed). This works for either a dedicated build directory or also a combined source and build tree. Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/a= vocado_qemu/__init__.py index 2b236a1cf0..ac59d36a4c 100644 --- a/tests/acceptance/avocado_qemu/__init__.py +++ b/tests/acceptance/avocado_qemu/__init__.py @@ -14,7 +14,7 @@ import uuid =20 import avocado =20 -SRC_ROOT_DIR =3D os.path.join(os.path.dirname(__file__), '..', '..', '..') +SRC_ROOT_DIR =3D os.path.dirname(os.path.dirname(os.path.dirname(os.path.d= irname(__file__)))) sys.path.append(os.path.join(SRC_ROOT_DIR, 'python')) =20 from qemu import QEMUMachine --=20 2.21.0 From nobody Wed May 15 13:43:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) client-ip=209.51.188.47; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559856824; cv=none; d=zoho.com; s=zohoarc; b=NC+nC9AGlSmSrGO0tmN7UFM2CPXbCZ3pwNi+T6nVH1MynCxk7dSA7ypd3hOqT0KMAdw/M00yIxsG5lqXQgmEd6QOHqI4iPQnVkc5B3bJhENDtqBE9upVqpos0L2LXb+/CHwww/nA0DzR/sMqLJk2CeVun+J7vc7AWXFuRVKSaMI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559856824; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=ABDk0kLiN0ewSK5P7DY0wfFHLPf/EHZNJpSGMZ2Xyxk=; b=Q1TXRpTFACe8M7aMTU6kfRRRhr3VcjZ+WIof40Y6L0JeY7J3GMh0HVCKAgfv/60VdsxAk/p5TEaxcQiCho2PHM5BASz50DJRcphX+gLqfT/f3tMYcH3Sl2cAzI4HkiW6cH+RXdyjGESCfA3WEMgplHND/Z6nSuwPO3UvwSCB6y8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.47 [209.51.188.47]) by mx.zohomail.com with SMTPS id 1559856824343653.5455186326462; Thu, 6 Jun 2019 14:33:44 -0700 (PDT) Received: from localhost ([::1]:42874 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZ00v-0001ju-PW for importer@patchew.org; Thu, 06 Jun 2019 17:33:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51942) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hYzu9-00064z-9B for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:26:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYziZ-00087N-G4 for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:14:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38720) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYziZ-00086Q-9R for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:14:39 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8E40D308A951; Thu, 6 Jun 2019 21:14:26 +0000 (UTC) Received: from dhcp-17-47.bos.redhat.com (dhcp-17-47.bos.redhat.com [10.18.17.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9B7D1108F83B; Thu, 6 Jun 2019 21:14:25 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Date: Thu, 6 Jun 2019 17:14:10 -0400 Message-Id: <20190606211414.8681-4-crosa@redhat.com> In-Reply-To: <20190606211414.8681-1-crosa@redhat.com> References: <20190606211414.8681-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Thu, 06 Jun 2019 21:14:31 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v6 3/7] Acceptance tests: add the build directory to the system PATH X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Cornelia Huck , Wainer dos Santos Moschetta , Cleber Rosa , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Samuel Ortiz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" So that when binaries such as qemu-img are searched for, those in the build tree will be favored. As a clarification, SRC_ROOT_DIR is dependent on the location from where tests are executed, so they are equal to the build directory if one is being used. The original motivation is that Avocado libraries such as avocado.utils.vmimage.get() may use the matching binaries, but it may also apply to any other binary that test code may eventually attempt to execute. Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/a= vocado_qemu/__init__.py index ac59d36a4c..47c57a9221 100644 --- a/tests/acceptance/avocado_qemu/__init__.py +++ b/tests/acceptance/avocado_qemu/__init__.py @@ -52,6 +52,12 @@ def pick_default_qemu_bin(arch=3DNone): =20 class Test(avocado.Test): def setUp(self): + # Some utility code uses binaries from the system's PATH. For + # instance, avocado.utils.vmimage.get() uses qemu-img, to + # create a snapshot image. This is a transparent way of + # making sure those utilities find and use binaries on the + # build tree by default. + os.environ['PATH'] =3D '%s:%s' % (SRC_ROOT_DIR, os.environ['PATH']) self._vms =3D {} arches =3D self.tags.get('arch', []) if len(arches) =3D=3D 1: --=20 2.21.0 From nobody Wed May 15 13:43:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) client-ip=209.51.188.47; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559856975; cv=none; d=zoho.com; s=zohoarc; b=OAgnE6rPtbhzkwycL3x7BIZ98//Z4WyrftEWikr7oKVkJIWD1HkyexYqPZff0XCi/EjTPus47aFyRu+FFF/8bMkUVWjoZsGsovD6kTD6Wq6p3UHxBe7vQrMjuWNrrY9tunIPuW8q1YlZeFeEV9D9Kpz7lto2CCHrg0OYx0KdWY0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559856975; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=CvwySEUQQGKGigXd4pkq2evB7JyeYYOH+AiKux2K5NY=; b=GlJ1lNmo0sIkeoCrbTiio1l++djsHlyFL3V/pO8Yfuz9QaWUpgIyVz+q7HCFAPBGTjFdRFVqWMDmM93lkaUYp/sSdt72TcQirTx248JFt4PRqshxEtC3/V0fMzu5+LBuWnbJumItk4nfTq6tEyzWKXakg8ai2RrbuwdvnFA28CQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.47]) by mx.zohomail.com with SMTPS id 1559856975990797.8469909068482; Thu, 6 Jun 2019 14:36:15 -0700 (PDT) Received: from localhost ([::1]:43232 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZ03N-0003aF-Cu for importer@patchew.org; Thu, 06 Jun 2019 17:36:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51627) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hYzu9-0005bq-BN for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:26:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYziU-00082g-Jh for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:14:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32972) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYziT-0007wy-5o for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:14:33 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A06FE3689B; Thu, 6 Jun 2019 21:14:27 +0000 (UTC) Received: from dhcp-17-47.bos.redhat.com (dhcp-17-47.bos.redhat.com [10.18.17.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AEC371091EFD; Thu, 6 Jun 2019 21:14:26 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Date: Thu, 6 Jun 2019 17:14:11 -0400 Message-Id: <20190606211414.8681-5-crosa@redhat.com> In-Reply-To: <20190606211414.8681-1-crosa@redhat.com> References: <20190606211414.8681-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 06 Jun 2019 21:14:31 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v6 4/7] Acceptance tests: depend on qemu-img X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Cornelia Huck , Wainer dos Santos Moschetta , Cleber Rosa , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Samuel Ortiz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Tests using the avocado.utils.vmimage library make use of qemu-img, and because it makes sense to use the version matching the rest of the source code, let's make sure it gets built. Its selection, instead of a possible qemu-img binary installed system wide, is already dealt with by the change that adds the build dir to the PATH during the test execution. This is based on the same work for qemu-iotests, and suggested by its author: - https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00951.html CC: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 991ad05aea..31fc6ec59c 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -1141,7 +1141,7 @@ $(TESTS_RESULTS_DIR): =20 check-venv: $(TESTS_VENV_DIR) =20 -check-acceptance: check-venv $(TESTS_RESULTS_DIR) +check-acceptance: check-venv $(TESTS_RESULTS_DIR) qemu-img$(EXESUF) $(call quiet-command, \ $(TESTS_VENV_DIR)/bin/python -m avocado \ --show=3D$(AVOCADO_SHOW) run --job-results-dir=3D$(TESTS_RESUL= TS_DIR) \ --=20 2.21.0 From nobody Wed May 15 13:43:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) client-ip=209.51.188.47; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559857085; cv=none; d=zoho.com; s=zohoarc; b=KNGET4yafq7jq+asnKQAS1Mo6xWBkAwYlD/vx7W0hCGWB1N2TTBND/0ArfLPgC5OPniDBv5LbnofK7nPLrJbP77QxOxzwSQhYz6hyJepFpUdNuihpFvqrh4Z/ERWmxUyCjGn67UsH765NNVBO0gXrsWiG9Ubm7+7aHYAKglGsi4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559857085; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=XRiiNgTiUqQafZ53l8j7TODftdGSRQhzgMzuzKF3sSQ=; b=ilJso+WDYIevTGe0miQaw4R1KUyocmJAUE8pAG+W2rDYagUYXJZSMuqqgA1rJeu+9AFHzRAJiGmORymM2OKG9V3J1ehuIrnxjc8Kp+HzZjBcsgkvtvknfCxc0Is2bD3aMUV4FGnq+DjVEvtUArqijRpPSVDuTOkW8vbbxenuKM0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.47 [209.51.188.47]) by mx.zohomail.com with SMTPS id 155985708549754.4038968419502; Thu, 6 Jun 2019 14:38:05 -0700 (PDT) Received: from localhost ([::1]:43460 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZ058-00054D-6x for importer@patchew.org; Thu, 06 Jun 2019 17:37:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51944) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hYzu9-000654-Ab for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:26:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYziU-00082m-KC for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:14:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38694) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYziT-0007wr-5h for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:14:34 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B96F83091851; Thu, 6 Jun 2019 21:14:29 +0000 (UTC) Received: from dhcp-17-47.bos.redhat.com (dhcp-17-47.bos.redhat.com [10.18.17.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C243E10ABD9F; Thu, 6 Jun 2019 21:14:27 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Date: Thu, 6 Jun 2019 17:14:12 -0400 Message-Id: <20190606211414.8681-6-crosa@redhat.com> In-Reply-To: <20190606211414.8681-1-crosa@redhat.com> References: <20190606211414.8681-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Thu, 06 Jun 2019 21:14:29 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v6 5/7] Add "boot_linux" test for x86_64 and pc and q35 machine types X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Cornelia Huck , Wainer dos Santos Moschetta , Cleber Rosa , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Samuel Ortiz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This acceptance test, validates that a full blown Linux guest can successfully boot in QEMU. In this specific case, the guest chosen is Fedora version 30. It adds two different tests for machine types pc and q35. The method for checking the successful boot is based on "cloudinit" and its "phone home" feature. The guest is given an ISO image with the location of the phone home server, and the information to post (the instance ID). Upon receiving the correct information, from the guest, the test is considered to have PASSed. This test is currently limited to user mode networking only, and instructs the guest to connect to the "router" address that is hard coded in QEMU. To create the cloudinit ISO image that will be used to configure the guest, the pycdlib library is also required and has been added as requirement to the virtual environment created by "check-venv". Signed-off-by: Cleber Rosa --- .travis.yml | 2 +- tests/acceptance/boot_linux.py | 83 ++++++++++++++++++++++++++++++++++ tests/requirements.txt | 2 + 3 files changed, 86 insertions(+), 1 deletion(-) create mode 100644 tests/acceptance/boot_linux.py diff --git a/.travis.yml b/.travis.yml index b053a836a3..df74234692 100644 --- a/.travis.yml +++ b/.travis.yml @@ -224,7 +224,7 @@ matrix: =20 # Acceptance (Functional) tests - env: - - CONFIG=3D"--python=3D/usr/bin/python3 --target-list=3Dx86_64-sof= tmmu,mips-softmmu,mips64el-softmmu,aarch64-softmmu,arm-softmmu,s390x-softmm= u,alpha-softmmu" + - CONFIG=3D"--python=3D/usr/bin/python3 --enable-slirp=3Dgit --tar= get-list=3Dx86_64-softmmu,mips-softmmu,mips64el-softmmu,aarch64-softmmu,arm= -softmmu,s390x-softmmu,alpha-softmmu" - TEST_CMD=3D"make check-acceptance" addons: apt: diff --git a/tests/acceptance/boot_linux.py b/tests/acceptance/boot_linux.py new file mode 100644 index 0000000000..2180f69a12 --- /dev/null +++ b/tests/acceptance/boot_linux.py @@ -0,0 +1,83 @@ +# Functional test that boots a complete Linux system via a cloud image +# +# Copyright (c) 2018-2019 Red Hat, Inc. +# +# Author: +# Cleber Rosa +# +# This work is licensed under the terms of the GNU GPL, version 2 or +# later. See the COPYING file in the top-level directory. + +import os + +from avocado_qemu import Test + +from avocado.utils import cloudinit +from avocado.utils import network +from avocado.utils import vmimage + + +class BootLinux(Test): + """ + Boots a Linux system, checking for a successful initialization + """ + + timeout =3D 600 + chksum =3D None + + def setUp(self): + super(BootLinux, self).setUp() + self.prepare_boot() + self.vm.add_args('-m', '1024') + self.vm.add_args('-drive', 'file=3D%s' % self.boot.path) + self.prepare_cloudinit() + + def prepare_boot(self): + try: + self.log.info('Downloading and preparing boot image') + self.boot =3D vmimage.get( + 'fedora', arch=3Dself.arch, version=3D'30', + checksum=3Dself.chksum, + algorithm=3D'sha256', + cache_dir=3Dself.cache_dirs[0], + snapshot_dir=3Dself.workdir) + except: + self.cancel('Failed to download boot image') + + def prepare_cloudinit(self): + cloudinit_iso =3D os.path.join(self.workdir, 'cloudinit.iso') + self.phone_home_port =3D network.find_free_port() + cloudinit.iso(cloudinit_iso, self.name, + username=3D'root', + password=3D'password', + # QEMU's hard coded usermode router address + phone_home_host=3D'10.0.2.2', + phone_home_port=3Dself.phone_home_port) + self.vm.add_args('-drive', 'file=3D%s,format=3Draw' % cloudinit_is= o) + + def wait_for_boot_confirmation(self): + self.log.info('VM launched, waiting for boot confirmation from gue= st') + cloudinit.wait_for_phone_home(('0.0.0.0', self.phone_home_port), s= elf.name) + + +class BootLinuxX8664(BootLinux): + + chksum =3D '72b6ae7b4ed09a4dccd6e966e1b3ac69bd97da419de9760b410e837ba0= 0b4e26' + + def test_pc(self): + """ + :avocado: tags=3Darch:x86_64 + :avocado: tags=3Dmachine:pc + """ + self.vm.set_machine('pc') + self.vm.launch() + self.wait_for_boot_confirmation() + + def test_q35(self): + """ + :avocado: tags=3Darch:x86_64 + :avocado: tags=3Dmachine:q35 + """ + self.vm.set_machine('q35') + self.vm.launch() + self.wait_for_boot_confirmation() diff --git a/tests/requirements.txt b/tests/requirements.txt index 3ae0e29ad7..9d2c79b146 100644 --- a/tests/requirements.txt +++ b/tests/requirements.txt @@ -3,3 +3,5 @@ # refer to: https://pip.pypa.io/en/stable/user_guide/#id1 avocado-framework=3D=3D68.0 paramiko +pycdlib=3D=3D1.6.0 + --=20 2.21.0 From nobody Wed May 15 13:43:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) client-ip=209.51.188.47; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559862026; cv=none; d=zoho.com; s=zohoarc; b=YbqneeDCc+frS7pCZkX/ZA/6Jk5qBmANZ6U4LOoensClrAsIF5nKEUitrna8Z8kLGVbzkd2eHaGMpypFuyZsxEOx7dJN25aMyOhrNOLOdoK8A3gPgfR6i0IfdomJCK1GBZezaZkIa2spYRhFtnx5xsr8j69gHj/+rPDxS6jJH+A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559862026; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=f+NopFU6FJZ2ewmY3lI2ooYVq0y28rRiRyUGUq7szHQ=; b=Q1cr9dbpOAvYUCXU2GWFEQIzE+dNKfM5gjrMcylzdUKNNc1Ykhvea+LpTN37BAiKNbsn/AlGX4tQUobGMT4pAd+vph9AW+NAQhk/mw/sTNq6ohArdCH02olmFUTLezyUkFBayGEzs+4HZGlAH0yvihwtWlv6ZB/sgLe0+s7b6IU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.47]) by mx.zohomail.com with SMTPS id 1559862026457501.1435529309248; Thu, 6 Jun 2019 16:00:26 -0700 (PDT) Received: from localhost ([::1]:42552 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hYzzz-00011o-Gp for importer@patchew.org; Thu, 06 Jun 2019 17:32:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51595) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hYzu9-0005bg-9v for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:26:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYziZ-000875-EJ for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:14:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38718) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYziZ-00086N-8b for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:14:39 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CB4A431628F9; Thu, 6 Jun 2019 21:14:30 +0000 (UTC) Received: from dhcp-17-47.bos.redhat.com (dhcp-17-47.bos.redhat.com [10.18.17.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D892C10A1832; Thu, 6 Jun 2019 21:14:29 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Date: Thu, 6 Jun 2019 17:14:13 -0400 Message-Id: <20190606211414.8681-7-crosa@redhat.com> In-Reply-To: <20190606211414.8681-1-crosa@redhat.com> References: <20190606211414.8681-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Thu, 06 Jun 2019 21:14:30 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v6 6/7] Add "boot_linux" test for aarch64 and virt machine type X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Cornelia Huck , Wainer dos Santos Moschetta , Cleber Rosa , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Samuel Ortiz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This boots a Fedora 30 guest using edk2. During the first Fedora 30 boot on aarch64, there's a filesystem resize operation. The typical output is similar to: [ 203.798938] EXT4-fs (sda2): resizing filesystem from 999168 to 999675= blocks [ 203.823032] EXT4-fs (sda2): resized filesystem to 999675 It was observed that, when using virtio-blk, it seems that random numbers are exhausted, unless an RNG device is given. Interestingly the same was *not* observed with virtio-scsi. In accordance with the other similar tests, this uses the default devices on the machine model used (virtio-blk here) and adds the necessary options to make it operation. In the future, other combinations (such as virtio-scsi) can, should and will be tested. Signed-off-by: Cleber Rosa --- tests/acceptance/boot_linux.py | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/tests/acceptance/boot_linux.py b/tests/acceptance/boot_linux.py index 2180f69a12..9b54a0241f 100644 --- a/tests/acceptance/boot_linux.py +++ b/tests/acceptance/boot_linux.py @@ -10,7 +10,7 @@ =20 import os =20 -from avocado_qemu import Test +from avocado_qemu import Test, SRC_ROOT_DIR =20 from avocado.utils import cloudinit from avocado.utils import network @@ -81,3 +81,23 @@ class BootLinuxX8664(BootLinux): self.vm.set_machine('q35') self.vm.launch() self.wait_for_boot_confirmation() + + +class BootLinuxAarch64(BootLinux): + + chksum =3D '528f2659a410e3a8bd47d32a6ac4e6c5729f1d28dbad0763b4282a753d= dcab1f' + + def test_virt(self): + """ + :avocado: tags=3Darch:aarch64 + :avocado: tags=3Dmachine:virt + """ + self.vm.set_machine('virt') + self.vm.add_args('-cpu', 'cortex-a53') + self.vm.add_args('-bios', + os.path.join(SRC_ROOT_DIR, 'pc-bios', + 'edk2-aarch64-code.fd')) + self.vm.add_args('-device', 'virtio-rng-pci,rng=3Drng0') + self.vm.add_args('-object', 'rng-random,id=3Drng0,filename=3D/dev/= urandom') + self.vm.launch() + self.wait_for_boot_confirmation() --=20 2.21.0 From nobody Wed May 15 13:43:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) client-ip=209.51.188.47; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559857751; cv=none; d=zoho.com; s=zohoarc; b=cmI2gc0kMdJxhu0NqeXQBLsL3VMMfiskCTqMIvJnF795aSVbkEVEmt3viUvgjqDw2UlUH1SWiIUrDSXNuteppOc+su+/n+kePBDRzsN56yna73rS4BGMapOqCB2oI4ArK/8/oa+287SVeFMVFTK8RFIBGPdz5NiFX3SeuwrWGks= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559857751; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=folki1DPTgj6mdWcl7xDBQTH292SlchvOPCyJhx2ETk=; b=cNZRhutUIGSmrnoP+A90qRExwE0DUSRqXIW5anffkxMK/VT8Q+YLLsS0K67SVrgAUG4SCqJDSrCYyQ1MtAZk3QLLB7VMtkUEMcYv5mOHWNCwETpes2FZjWm/FH5U3fWaS4us2uezZqeyE4flf98uSnfqstLmw+ApOSEWECXC3GQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.47 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.47 [209.51.188.47]) by mx.zohomail.com with SMTPS id 1559857751114971.2730534512345; Thu, 6 Jun 2019 14:49:11 -0700 (PDT) Received: from localhost ([::1]:42842 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZ00n-0001iQ-HM for importer@patchew.org; Thu, 06 Jun 2019 17:33:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51595) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hYzu5-0005bg-GE for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:26:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYziZ-00087g-Ic for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:14:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54712) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYziZ-00086W-AC for qemu-devel@nongnu.org; Thu, 06 Jun 2019 17:14:39 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF9F1330247; Thu, 6 Jun 2019 21:14:31 +0000 (UTC) Received: from dhcp-17-47.bos.redhat.com (dhcp-17-47.bos.redhat.com [10.18.17.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EBB9610ABD9F; Thu, 6 Jun 2019 21:14:30 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Date: Thu, 6 Jun 2019 17:14:14 -0400 Message-Id: <20190606211414.8681-8-crosa@redhat.com> In-Reply-To: <20190606211414.8681-1-crosa@redhat.com> References: <20190606211414.8681-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 06 Jun 2019 21:14:31 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v6 7/7] [RFC]: use Avocado data drainer for console logging X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Cornelia Huck , Wainer dos Santos Moschetta , Cleber Rosa , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Samuel Ortiz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This depends on a proposed feature to Avocado, a new module that "drains" data and processes it. In this case, a drainer for the console socket file descriptor is used, and the data is sent to the "console" logger. This allows for a much better feedback of the test process, showing boot data from the guest as it happens, without obstructing the test code path. Signed-off-by: Cleber Rosa --- tests/acceptance/boot_linux.py | 14 +++++++++++--- tests/requirements.txt | 2 +- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/tests/acceptance/boot_linux.py b/tests/acceptance/boot_linux.py index 9b54a0241f..f3507f519e 100644 --- a/tests/acceptance/boot_linux.py +++ b/tests/acceptance/boot_linux.py @@ -15,6 +15,7 @@ from avocado_qemu import Test, SRC_ROOT_DIR from avocado.utils import cloudinit from avocado.utils import network from avocado.utils import vmimage +from avocado.utils import datadrainer =20 =20 class BootLinux(Test): @@ -55,6 +56,13 @@ class BootLinux(Test): phone_home_port=3Dself.phone_home_port) self.vm.add_args('-drive', 'file=3D%s,format=3Draw' % cloudinit_is= o) =20 + def launch(self): + self.vm.set_console() + self.vm.launch() + console_drainer =3D datadrainer.LineLogger(self.vm.console_socket.= fileno(), + logger=3Dself.log.getChil= d('console')) + console_drainer.start() + def wait_for_boot_confirmation(self): self.log.info('VM launched, waiting for boot confirmation from gue= st') cloudinit.wait_for_phone_home(('0.0.0.0', self.phone_home_port), s= elf.name) @@ -70,7 +78,7 @@ class BootLinuxX8664(BootLinux): :avocado: tags=3Dmachine:pc """ self.vm.set_machine('pc') - self.vm.launch() + self.launch() self.wait_for_boot_confirmation() =20 def test_q35(self): @@ -79,7 +87,7 @@ class BootLinuxX8664(BootLinux): :avocado: tags=3Dmachine:q35 """ self.vm.set_machine('q35') - self.vm.launch() + self.launch() self.wait_for_boot_confirmation() =20 =20 @@ -99,5 +107,5 @@ class BootLinuxAarch64(BootLinux): 'edk2-aarch64-code.fd')) self.vm.add_args('-device', 'virtio-rng-pci,rng=3Drng0') self.vm.add_args('-object', 'rng-random,id=3Drng0,filename=3D/dev/= urandom') - self.vm.launch() + self.launch() self.wait_for_boot_confirmation() diff --git a/tests/requirements.txt b/tests/requirements.txt index 9d2c79b146..28eaf7b61e 100644 --- a/tests/requirements.txt +++ b/tests/requirements.txt @@ -1,7 +1,7 @@ # Add Python module requirements, one per line, to be installed # in the tests/venv Python virtual environment. For more info, # refer to: https://pip.pypa.io/en/stable/user_guide/#id1 -avocado-framework=3D=3D68.0 +-e git+https://github.com/clebergnu/avocado@datadrainer#egg=3Davocado_fram= ework paramiko pycdlib=3D=3D1.6.0 =20 --=20 2.21.0