From nobody Wed Dec 17 06:11:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1559844296; cv=none; d=zoho.com; s=zohoarc; b=A37ChL8/1g8ZUoXcYHgAUItXcjb2l2FkgdVZ2PYujTM9Vj54fA0zwBg2GReQO3GCflsdIgCV+Pkqat1064Xl8740/2YtpkskBjj5ZH1Og3tE7bvb5exdjzSXHyvdlRzsySsuafq51AQiprz2JPabg4RQmKPKcmH956bZKDkOJXI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559844296; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=YjVm+cX22zoyuHU03fYipUHvsizBftG/iHWYkwVfhEA=; b=ZTxyCMxv4LRwAJno6eH1fK/R4hq66bfvUHXoA5BSbaXa9QCXYHbRPbqOpI7JW+8PslwKU00PCT4KzQkmcszf18DR8/GpM/dEI1tQs8cTnaYkoAoj3Pbo4/cy1X+Gg2ZQ5hS4VPpmgszH4TgYR+dlUW7c1oHV5CfVsxzBRvDaxr4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559844296825141.54552001228365; Thu, 6 Jun 2019 11:04:56 -0700 (PDT) Received: from localhost ([127.0.0.1]:36161 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYwkv-0004l1-PW for importer@patchew.org; Thu, 06 Jun 2019 14:04:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYwU5-0004Qu-6y for qemu-devel@nongnu.org; Thu, 06 Jun 2019 13:47:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYwU2-000429-HN for qemu-devel@nongnu.org; Thu, 06 Jun 2019 13:47:27 -0400 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:43860) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hYwTz-0003Dk-S7 for qemu-devel@nongnu.org; Thu, 06 Jun 2019 13:47:25 -0400 Received: by mail-wr1-x442.google.com with SMTP id r18so3319700wrm.10 for ; Thu, 06 Jun 2019 10:46:45 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id z135sm2596784wmc.45.2019.06.06.10.46.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jun 2019 10:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YjVm+cX22zoyuHU03fYipUHvsizBftG/iHWYkwVfhEA=; b=eowGwb18WGDo4xD8H0ZWgGRnw2MQw0JMlxUcH0N2k4p0QBmJAtpzDuaLw+M+g+3y4o +G2o/HzlMzwzZ9EgsBsvdt++8C2KxFZm7LTjLmII28dTsKvf5Oux2KbIyY11PW7qTwCp ZWM6yoXvtLgbgZX+0GjGcy37Sz82Vs9HhWfi5XZ7dQJK7YARlwRW1dWC4aIaLTG6kIHm gfw9IPEjtIhObnuuLTyIEwenGBKIuMhnN9LWOZto1dhAdeygnAOnhfFwX7gcv+B6f54v TvuiiMiXHJ66JL+Pra0QfN+elX4OgBmYzVot6HcZCA/xnggn5vB7Rul6BqHhEnx7qdu2 Mplg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YjVm+cX22zoyuHU03fYipUHvsizBftG/iHWYkwVfhEA=; b=soHSkRgzmbms+Ca4zT/Uq5kn26p2mI/MbIOfacxdBnUTgLVC6hhbx0Is8UZdLf+JBM 5BymI8BkzUUVaKsp750n+4svgd6VMnzox9L7fJvN4RPXZ1tJWoneyKFaJUAvkNPBCevu qiw7dSHjf5VjxjYjJBEYsq6BuuhuUmd34IVsNGCckTFWTyuuOfM0iUR83+seg2AiOLul TAOgTV/UD13wF+ExwurgI4ay/2PUaWmlSFGg0DKQOI8oUGkA5c/sV/AnfDhxfywi0hEP c2wTIdihSAPa9sMxArSI/kU+WNChdGnXkOLx6QZ4nrupiNYA+h4zeH+XElZPxDCBLmn9 AWTQ== X-Gm-Message-State: APjAAAVHUtjer90tlqKriX+Yp5aD2YreShFoFQu6mf+pJmcwQsqdfOVg Vc0MmToFJ2SLllWNv5c8ov0Xt5XqAICfTg== X-Google-Smtp-Source: APXvYqwALLGDPtphcaCVv5Ve7CJ2hhdWViM1mwV+lorH3npXdDcxMxIBX2OFaDaSl22m6894AdNNAw== X-Received: by 2002:adf:dd82:: with SMTP id x2mr6457026wrl.27.1559843204615; Thu, 06 Jun 2019 10:46:44 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Thu, 6 Jun 2019 18:45:57 +0100 Message-Id: <20190606174609.20487-31-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190606174609.20487-1-peter.maydell@linaro.org> References: <20190606174609.20487-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 Subject: [Qemu-devel] [PATCH 30/42] target/arm: Convert VNEG to decodetree X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Convert the VNEG instruction to decodetree. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/translate-vfp.inc.c | 10 ++++++++++ target/arm/translate.c | 6 +----- target/arm/vfp.decode | 5 +++++ 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/target/arm/translate-vfp.inc.c b/target/arm/translate-vfp.inc.c index d0282f1f921..6e06b2a130a 100644 --- a/target/arm/translate-vfp.inc.c +++ b/target/arm/translate-vfp.inc.c @@ -1898,3 +1898,13 @@ static bool trans_VABS_dp(DisasContext *s, arg_VABS_= dp *a) { return do_vfp_2op_dp(s, gen_helper_vfp_absd, a->vd, a->vm); } + +static bool trans_VNEG_sp(DisasContext *s, arg_VNEG_sp *a) +{ + return do_vfp_2op_sp(s, gen_helper_vfp_negs, a->vd, a->vm); +} + +static bool trans_VNEG_dp(DisasContext *s, arg_VNEG_dp *a) +{ + return do_vfp_2op_dp(s, gen_helper_vfp_negd, a->vd, a->vm); +} diff --git a/target/arm/translate.c b/target/arm/translate.c index ace9f803ab7..cc67ab069bc 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -3098,7 +3098,7 @@ static int disas_vfp_insn(DisasContext *s, uint32_t i= nsn) return 1; case 15: switch (rn) { - case 1: + case 1 ... 2: /* Already handled by decodetree */ return 1; default: @@ -3112,7 +3112,6 @@ static int disas_vfp_insn(DisasContext *s, uint32_t i= nsn) /* rn is opcode, encoded as per VFP_SREG_N. */ switch (rn) { case 0x00: /* vmov */ - case 0x02: /* vneg */ case 0x03: /* vsqrt */ break; =20 @@ -3291,9 +3290,6 @@ static int disas_vfp_insn(DisasContext *s, uint32_t i= nsn) case 0: /* cpy */ /* no-op */ break; - case 2: /* neg */ - gen_vfp_neg(dp); - break; case 3: /* sqrt */ gen_vfp_sqrt(dp); break; diff --git a/target/arm/vfp.decode b/target/arm/vfp.decode index 7035861c270..79e41963be4 100644 --- a/target/arm/vfp.decode +++ b/target/arm/vfp.decode @@ -161,3 +161,8 @@ VABS_sp ---- 1110 1.11 0000 .... 1010 11.0 .... \ vd=3D%vd_sp vm=3D%vm_sp VABS_dp ---- 1110 1.11 0000 .... 1011 11.0 .... \ vd=3D%vd_dp vm=3D%vm_dp + +VNEG_sp ---- 1110 1.11 0001 .... 1010 01.0 .... \ + vd=3D%vd_sp vm=3D%vm_sp +VNEG_dp ---- 1110 1.11 0001 .... 1011 01.0 .... \ + vd=3D%vd_dp vm=3D%vm_dp --=20 2.20.1