From nobody Wed Dec 17 06:10:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1559844476; cv=none; d=zoho.com; s=zohoarc; b=dd1wrd/+EowyDQBSzPzDhVRQN4fyr5HXa6bvHZHjLDFJ0/oxFZSdOdGZ59GxPFO6BQpX2plEjgs5Es8UOmcoSxfIfPZJbDalirzOFJZqei1pNDpDbTiA7kWg6xJttMSkJLI3pbWa2qcpDL1m8/wHmOLj5H3QSKzmjd1+m/SHywQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559844476; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=O5grNllV+sv27kAA5O3rl1i8qW/FtM8e/iepHVf3KD8=; b=VEoQ/FtnW43xHjd4mCAUvNlGgy/TX4RAz9kObz2k6svpRZHCKGasyCl7H0yeb2txhDod0rTABqJkRVw4b7yEhCEtufilAzUAa028I4aTCQwEfatMo/PDYzG8LEQ04g0X7Xmzg0LW0Qrob/XJlAwEBfdufihQUjqhTVGrKW2I0L0= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559844476650531.4382992864957; Thu, 6 Jun 2019 11:07:56 -0700 (PDT) Received: from localhost ([127.0.0.1]:36226 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYwnr-0007p9-Ir for importer@patchew.org; Thu, 06 Jun 2019 14:07:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYwUB-0004Zy-5U for qemu-devel@nongnu.org; Thu, 06 Jun 2019 13:47:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYwU8-0004EB-4Z for qemu-devel@nongnu.org; Thu, 06 Jun 2019 13:47:35 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:42579) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hYwU7-00035y-N5 for qemu-devel@nongnu.org; Thu, 06 Jun 2019 13:47:31 -0400 Received: by mail-wr1-x444.google.com with SMTP id x17so3323023wrl.9 for ; Thu, 06 Jun 2019 10:46:36 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id z135sm2596784wmc.45.2019.06.06.10.46.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jun 2019 10:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O5grNllV+sv27kAA5O3rl1i8qW/FtM8e/iepHVf3KD8=; b=p8kaIRy4pZWp1AK0+YjVMmUWTVQxxPrT3d5rzcuG+7xKitRD1gc9N1kKuqrO/vjL+f fKmx+2O9OzWJIQzC42CK31rdK8J6QrWAcSswUzCgrT3VsB8jPcQgS5ei9Cblf3P7lrUQ CoUBaVKB59i+KxtZaKwWFrpLNIC0ma0yKMksOokoFPcICBHDz4QfomgOUtBQV3E4rwU6 9CBUJQCKlzOUpOWgcdjjCXhcR3HgjBucwdpryWsP6HLNGqT4A6KkMrUH3YE70ANwEiRx aRrHdffAUDWgB3+/gJ4d/EIQhNVzq2unFwMkFoNVWL+AZS8AY6uoP7SBHq9axK5SR/mx jzAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O5grNllV+sv27kAA5O3rl1i8qW/FtM8e/iepHVf3KD8=; b=PY/Lz5wZNT2lwd0kfyThD1tWoJHJ7+k6Wl0YRZhyj659m1UuVIgpjm0LG3VyZfNTIr 9/8JSK2E5EiWCmLtnrWnGEoXP2ZfZAhA9Lb3NlGeHEjPIAkr/pvxAwQFaZqtbKn8/Upf 8J7Mlr7KdJBMOkGubG+2r5ca5KSQWs33XTa1s8YSzA0ZKSjBcNQIwKEU9bdXL6Y8XcYK HU0bkdlqYG11QjXT12OA/yXoRU9escKdWhcaQvtKVsAF53VM+WkaLRKYCz/Ge481FdLR HHrC+bKAhhGRALS2gF/nW4ucCym8v6InmpfQLVj6o/rYyzDmdzqcG7qWRJy0TrKWgJBC rJMg== X-Gm-Message-State: APjAAAWZNU7N6AFadnR3PZBatrxVGY7SBi4aCeUgHr8hjHn6NE2MM0YC LFH6fwWtybtcqkaZVaVooXfRMA== X-Google-Smtp-Source: APXvYqz1q6bLJI+Vj7CpTmKUxNMjB2p68bB+/xd2pWJyorFWeGVK4i3ODMpdNovY/VfC+Mj4d2jhBg== X-Received: by 2002:adf:e309:: with SMTP id b9mr30659068wrj.135.1559843195961; Thu, 06 Jun 2019 10:46:35 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Date: Thu, 6 Jun 2019 18:45:49 +0100 Message-Id: <20190606174609.20487-23-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190606174609.20487-1-peter.maydell@linaro.org> References: <20190606174609.20487-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH 22/42] target/arm: Convert VMUL to decodetree X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Convert the VMUL instruction to decodetree. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/translate-vfp.inc.c | 10 ++++++++++ target/arm/translate.c | 5 +---- target/arm/vfp.decode | 5 +++++ 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/target/arm/translate-vfp.inc.c b/target/arm/translate-vfp.inc.c index 8532bf4abcd..a2afe82b349 100644 --- a/target/arm/translate-vfp.inc.c +++ b/target/arm/translate-vfp.inc.c @@ -1417,3 +1417,13 @@ static bool trans_VNMLA_dp(DisasContext *s, arg_VNML= A_sp *a) { return do_vfp_3op_dp(s, gen_VNMLA_dp, a->vd, a->vn, a->vm, true); } + +static bool trans_VMUL_sp(DisasContext *s, arg_VMUL_sp *a) +{ + return do_vfp_3op_sp(s, gen_helper_vfp_muls, a->vd, a->vn, a->vm, fals= e); +} + +static bool trans_VMUL_dp(DisasContext *s, arg_VMUL_sp *a) +{ + return do_vfp_3op_dp(s, gen_helper_vfp_muld, a->vd, a->vn, a->vm, fals= e); +} diff --git a/target/arm/translate.c b/target/arm/translate.c index 73b30ed33d1..226f1006ced 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -3112,7 +3112,7 @@ static int disas_vfp_insn(DisasContext *s, uint32_t i= nsn) rn =3D VFP_SREG_N(insn); =20 switch (op) { - case 0 ... 3: + case 0 ... 4: /* Already handled by decodetree */ return 1; default: @@ -3298,9 +3298,6 @@ static int disas_vfp_insn(DisasContext *s, uint32_t i= nsn) for (;;) { /* Perform the calculation. */ switch (op) { - case 4: /* mul: fn * fm */ - gen_vfp_mul(dp); - break; case 5: /* nmul: -(fn * fm) */ gen_vfp_mul(dp); gen_vfp_neg(dp); diff --git a/target/arm/vfp.decode b/target/arm/vfp.decode index c50d2c3ebf3..d7fcb9709a9 100644 --- a/target/arm/vfp.decode +++ b/target/arm/vfp.decode @@ -117,3 +117,8 @@ VNMLA_sp ---- 1110 0.01 .... .... 1010 .1.0 .... \ vm=3D%vm_sp vn=3D%vn_sp vd=3D%vd_sp VNMLA_dp ---- 1110 0.01 .... .... 1011 .1.0 .... \ vm=3D%vm_dp vn=3D%vn_dp vd=3D%vd_dp + +VMUL_sp ---- 1110 0.10 .... .... 1010 .0.0 .... \ + vm=3D%vm_sp vn=3D%vn_sp vd=3D%vd_sp +VMUL_dp ---- 1110 0.10 .... .... 1011 .0.0 .... \ + vm=3D%vm_dp vn=3D%vn_dp vd=3D%vd_dp --=20 2.20.1