From nobody Fri May 3 02:10:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1559813223; cv=none; d=zoho.com; s=zohoarc; b=W+qvdaYR8kQuxxnKemq3Orq1qxs8QeIJ5Lyx2umCK1RcuzF6F5mttJbIPKf5ENKdvXW4jAKwp2h3PV13bjsl8XLfwCuP0fKwhuUxnlz8cXCDGuKc6SBcq1IDP0ISd//DpCk14fN5697MZotHKevF20rJgi0sblDnb05OM+I9OEc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559813223; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=8Fd8dzodNNRDzJWR01DDiTIGwHWr1eAlsflSEthz88U=; b=g0NCtyVkW2pU+e9haAYVAVMw+Q3siLtynJI0W8Ivu5nXk3HFQEWGeq8G+8VRaHh5nyHcW4VjvD1PBZYQ9NYvjXKRpB8bDSaHrG23nmZEb5uECm97fWRUoW2KWpKoNTQ442f+GlgRMoWvWFUYjWWrs55SK0WoMDLd/uSpaljaV3E= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559813223273427.3352468422571; Thu, 6 Jun 2019 02:27:03 -0700 (PDT) Received: from localhost ([127.0.0.1]:57098 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYoff-0007lY-RF for importer@patchew.org; Thu, 06 Jun 2019 05:26:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYoeb-0006qa-F4 for qemu-devel@nongnu.org; Thu, 06 Jun 2019 05:25:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYoea-0003fs-Kw for qemu-devel@nongnu.org; Thu, 06 Jun 2019 05:25:49 -0400 Received: from charlie.dont.surf ([128.199.63.193]:42578) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYoeY-0003YA-HH; Thu, 06 Jun 2019 05:25:46 -0400 Received: from apples.localdomain (soho-cph.cust-cnex.dsd101.net [194.62.216.132]) by charlie.dont.surf (Postfix) with ESMTPSA id F1191BF724; Thu, 6 Jun 2019 09:25:43 +0000 (UTC) From: Klaus Birkelund Jensen To: qemu-block@nongnu.org Date: Thu, 6 Jun 2019 11:25:30 +0200 Message-Id: <20190606092530.14206-1-klaus@birkelund.eu> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 128.199.63.193 Subject: [Qemu-devel] [PATCH] nvme: do not advertise support for unsupported arbitration mechanism X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Kevin Wolf , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The device mistakenly reports that the Weighted Round Robin with Urgent Priority Class arbitration mechanism is supported. It is not. Signed-off-by: Klaus Birkelund Jensen Acked-by: Maxim Levitsky --- hw/block/nvme.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 30e50f7a3853..415b4641d6b4 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -1383,7 +1383,6 @@ static void nvme_realize(PCIDevice *pci_dev, Error **= errp) n->bar.cap =3D 0; NVME_CAP_SET_MQES(n->bar.cap, 0x7ff); NVME_CAP_SET_CQR(n->bar.cap, 1); - NVME_CAP_SET_AMS(n->bar.cap, 1); NVME_CAP_SET_TO(n->bar.cap, 0xf); NVME_CAP_SET_CSS(n->bar.cap, 1); NVME_CAP_SET_MPSMAX(n->bar.cap, 4); --=20 2.21.0