From nobody Sun Feb 8 17:48:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559767326; cv=none; d=zoho.com; s=zohoarc; b=OYahyw6Ra4Rtuod14Go/SH3Sg5KkcImLIcirWJVdUz/FcVT0nR99r58r+LCYKQ1a4BWRtVsg5BUPB4VOMLOHFodnTKrnLyHes8yMziD+oJ1ygUcXeasn/i0XU7ql0JFhPDcZedPaeeayzfFhAbNVKuPHIlNsDuZnvHjimLpP1QU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559767326; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Sy9PgHB5vvAdgWIcr0JAnFkTqUiyEPaq9y1+646ix7Q=; b=fCSXr3DDyd/yTHeChVJe45SlxGioVJaa8LJoLSxp9Zh83O5AiAvIMoyJXJNodyDBztb4jrEZopHx7DxzUXWsyRbgjmSOgcWyM3C3A92BEXk9c+KUYv1TPt9wHTwJFOULkKWp7Y2IDSj9U9d101jbW3c6ymN8WzCsAK2DYHmELRs= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559767326599562.5060040513897; Wed, 5 Jun 2019 13:42:06 -0700 (PDT) Received: from localhost ([127.0.0.1]:49588 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYcj0-0000GG-9f for importer@patchew.org; Wed, 05 Jun 2019 16:41:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYccp-0003Hg-Km for qemu-devel@nongnu.org; Wed, 05 Jun 2019 16:35:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYccZ-0006pG-HS for qemu-devel@nongnu.org; Wed, 05 Jun 2019 16:35:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3645) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYccQ-00065S-97; Wed, 05 Jun 2019 16:34:51 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BBF3FC18B2D6; Wed, 5 Jun 2019 20:34:25 +0000 (UTC) Received: from t460s.redhat.com (ovpn-116-124.ams2.redhat.com [10.36.116.124]) by smtp.corp.redhat.com (Postfix) with ESMTP id 43501619A9; Wed, 5 Jun 2019 20:34:24 +0000 (UTC) From: David Hildenbrand To: qemu-devel@nongnu.org Date: Wed, 5 Jun 2019 22:33:38 +0200 Message-Id: <20190605203403.29461-9-david@redhat.com> In-Reply-To: <20190605203403.29461-1-david@redhat.com> References: <20190605203403.29461-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 05 Jun 2019 20:34:25 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL SUBSYSTEM s390x 08/33] s390x/tcg: Fix max_byte detection for stfle X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , David Hildenbrand , Cornelia Huck , Richard Henderson , qemu-s390x@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" used_stfl_bytes is 0, before initialized via prepare_stfl() on the first invocation. We have to move the calculation of max_bytes after prepare_stfl(). Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/misc_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c index ee67c1fa0c..34476134a4 100644 --- a/target/s390x/misc_helper.c +++ b/target/s390x/misc_helper.c @@ -669,7 +669,7 @@ uint32_t HELPER(stfle)(CPUS390XState *env, uint64_t add= r) { const uintptr_t ra =3D GETPC(); const int count_bytes =3D ((env->regs[0] & 0xff) + 1) * 8; - const int max_bytes =3D ROUND_UP(used_stfl_bytes, 8); + int max_bytes; int i; =20 if (addr & 0x7) { @@ -677,6 +677,7 @@ uint32_t HELPER(stfle)(CPUS390XState *env, uint64_t add= r) } =20 prepare_stfl(); + max_bytes =3D ROUND_UP(used_stfl_bytes, 8); for (i =3D 0; i < count_bytes; ++i) { cpu_stb_data_ra(env, addr + i, stfl_bytes[i], ra); } --=20 2.21.0