From nobody Mon Feb 9 08:57:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559765392; cv=none; d=zoho.com; s=zohoarc; b=e9GxNEHKaVUPQfGx9pP8qofTY9pLwp+/ca1kRU6S8drYfdJYz1avO3C6yItVwoEZrLnNjiwkeMpMPCaNVozYVlq3uyxF+8csEgGVdLk+7vDiTL1sC5kqe3Cu3gqCtwKwKWeYvgI1ZtNPXnvCqjaYFWGmpS01Tcm1PmtuFrxVmNk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559765392; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=VVEi9i7PEAHQCxMf9KerkSAmIyOSHS0sEA/Oo9jVOxg=; b=nSJ6kM67U16CAmY+KCUeB8qihV2Qybwr+EKBHRjrNPNbCmBhYpHIclXB2M/mYt9D9AV6v53qaUXW4lckF1wCCFsBwOpfJyRSreksskU/n40DxwpjUDxq/1Do35zqP4h3iVU/ZRplPZtLFfGIVAEH1dZBDXl/V2+Mm0qNixZ/cLc= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559765392787975.3336448685972; Wed, 5 Jun 2019 13:09:52 -0700 (PDT) Received: from localhost ([127.0.0.1]:49171 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYcEB-0001ON-JY for importer@patchew.org; Wed, 05 Jun 2019 16:09:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYc5h-0003KC-Qw for qemu-devel@nongnu.org; Wed, 05 Jun 2019 16:00:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYc5g-00065c-LK for qemu-devel@nongnu.org; Wed, 05 Jun 2019 16:00:57 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:45868) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hYc5g-00062r-GL for qemu-devel@nongnu.org; Wed, 05 Jun 2019 16:00:56 -0400 Received: by mail-qk1-f196.google.com with SMTP id s22so5969481qkj.12 for ; Wed, 05 Jun 2019 13:00:53 -0700 (PDT) Received: from redhat.com (pool-100-0-197-103.bstnma.fios.verizon.net. [100.0.197.103]) by smtp.gmail.com with ESMTPSA id h128sm12426293qkc.27.2019.06.05.13.00.51 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 05 Jun 2019 13:00:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VVEi9i7PEAHQCxMf9KerkSAmIyOSHS0sEA/Oo9jVOxg=; b=lon2aoYBg6m6CafxndviUSFU1Ij95G7oEcGEQ1qZHoGos9m2AmJTBujeu4h7nuciE4 Yzdc4D4zMgAUkwzRR9wYF8Gb4LqOLP/XQzICJdI5r8LJvTallWtx03raRc31HMvzLVS4 U3lbuPTAFTGx7WwRVFUeU/etttrNhSQ03oMH4zbKgpgYS5kHy6YrIPxFuqds3x7SPLO2 eFThmYd/vdGnT3uJw8edjlfNqfSFnel+XdPJ/cB5nRRefmf4ydiNKXcUphXcW1oG9kU7 NkWccFrmpqGHw9KdO5DuEmh/lA5lTiCqBIrRbS+jFKhWPiJwCk7Tav+uvZkzKFY28Wwy VN2g== X-Gm-Message-State: APjAAAWNP0rh8EXMG4gQcLohGzW71nvF6ryjGlpKOaE7Zj2JUompx5z9 KANnbA/zGlj6EtlecSDrXf+y8ZcCI8U= X-Google-Smtp-Source: APXvYqzWTstoBrEzs1P2bXPyKyZlvhBSMRBsqyV7LFrL1qopO6xGWdHGuaLbaGXGDAk/jq8hmMp6vA== X-Received: by 2002:a37:de06:: with SMTP id h6mr16013992qkj.322.1559764852522; Wed, 05 Jun 2019 13:00:52 -0700 (PDT) Date: Wed, 5 Jun 2019 16:00:50 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Message-ID: <20190605195913.12243-18-mst@redhat.com> References: <20190605195913.12243-1-mst@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190605195913.12243-1-mst@redhat.com> X-Mailer: git-send-email 2.17.1.1206.gb667731e2e.dirty X-Mutt-Fcc: =sent X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.222.196 Subject: [Qemu-devel] [PULL v3 17/17] bios-tables-test: ignore identical binaries X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , Thomas Huth , Igor Mammedov , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" when binary of the tables is identical, there is no need to run iasl to check that they are functionally equivalent. Signed-off-by: Michael S. Tsirkin --- tests/bios-tables-test.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index d80ea7f7f3..0ce55182f2 100644 --- a/tests/bios-tables-test.c +++ b/tests/bios-tables-test.c @@ -375,6 +375,20 @@ static void test_acpi_asl(test_data *data) sdt =3D &g_array_index(data->tables, AcpiSdtTable, i); exp_sdt =3D &g_array_index(exp_data.tables, AcpiSdtTable, i); =20 + if (sdt->aml_len =3D=3D exp_sdt->aml_len && + !memcmp(sdt->aml, exp_sdt->aml, sdt->aml_len)) { + /* Identical table binaries: no need to disassemble. */ + continue; + } + + fprintf(stderr, + "acpi-test: Warning! %.4s binary file mismatch. " + "Actual [aml:%s], Expected [aml:%s].\n", + exp_sdt->aml, sdt->aml_file, exp_sdt->aml_file); + + all_tables_match =3D all_tables_match && + test_acpi_find_diff_allowed(exp_sdt); + err =3D load_asl(data->tables, sdt); asl =3D normalize_asl(sdt->asl); =20 @@ -413,8 +427,6 @@ static void test_acpi_asl(test_data *data) } } } - all_tables_match =3D all_tables_match && - test_acpi_find_diff_allowed(exp_sdt); } g_string_free(asl, true); g_string_free(exp_asl, true); --=20 MST