From nobody Tue Feb 10 05:39:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1559746874; cv=none; d=zoho.com; s=zohoarc; b=NX72PCLB8+KIuc4D1QopayqTnKd+I4IflSFX8VB9UGWKwNZoFTNyVTzcTfLZRl1TQrEyLS7kr1vVKu4EamgkxSOIeImwwWF6/T7YM7dLQkTkRxDMEBQGfN8OZbm4GVfpHaxZwJ5UbM/d/bZoT2bVeePY13r9NQKlIM/SEqSIQbI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559746874; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=LET7dk6qUgqpC38CgnsnLz/OHBHTgG9zUuz8MrRmOyI=; b=nVru2aPDHPNVzUZiwcEpCSzs/szehbU0nXearMBDX+uzcbR3++335FF1FM2I8ekKa2gXVHnAyL6z4I3Yf5lR5tiYNowKXPt5oillXMJhkqK8oIqdlxuPmEZcbK1LAduzUuTs4Eol41JREjtX2RJ9AnV3kOuVDF2pxKFDKml+Iy8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559746874719974.7588593260269; Wed, 5 Jun 2019 08:01:14 -0700 (PDT) Received: from localhost ([127.0.0.1]:44121 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYXPb-0001qv-Ne for importer@patchew.org; Wed, 05 Jun 2019 11:01:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYXNf-0000aw-Oz for qemu-devel@nongnu.org; Wed, 05 Jun 2019 10:59:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYXNe-0002gI-PW for qemu-devel@nongnu.org; Wed, 05 Jun 2019 10:59:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54042) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYXNe-0002fN-Ju for qemu-devel@nongnu.org; Wed, 05 Jun 2019 10:59:10 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F049FA3EB3 for ; Wed, 5 Jun 2019 14:59:09 +0000 (UTC) Received: from localhost (ovpn-112-54.ams2.redhat.com [10.36.112.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id C75D11A7D0; Wed, 5 Jun 2019 14:59:02 +0000 (UTC) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Date: Wed, 5 Jun 2019 16:58:29 +0200 Message-Id: <20190605145829.7674-6-marcandre.lureau@redhat.com> In-Reply-To: <20190605145829.7674-1-marcandre.lureau@redhat.com> References: <20190605145829.7674-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 05 Jun 2019 14:59:09 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 5/5] vhost-user-gpu: initialize msghdr & iov at declaration X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This should fix uninitialized fields found by coverity CID 1401762. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Peter Maydell --- contrib/vhost-user-gpu/main.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/contrib/vhost-user-gpu/main.c b/contrib/vhost-user-gpu/main.c index 0ef649ffaa..04b753046f 100644 --- a/contrib/vhost-user-gpu/main.c +++ b/contrib/vhost-user-gpu/main.c @@ -138,22 +138,20 @@ static int vg_sock_fd_write(int sock, const void *buf, ssize_t buflen, int fd) { ssize_t ret; - struct msghdr msg; - struct iovec iov; + struct iovec iov =3D { + .iov_base =3D (void *)buf, + .iov_len =3D buflen, + }; + struct msghdr msg =3D { + .msg_iov =3D &iov, + .msg_iovlen =3D 1, + }; union { struct cmsghdr cmsghdr; char control[CMSG_SPACE(sizeof(int))]; } cmsgu; struct cmsghdr *cmsg; =20 - iov.iov_base =3D (void *)buf; - iov.iov_len =3D buflen; - - msg.msg_name =3D NULL; - msg.msg_namelen =3D 0; - msg.msg_iov =3D &iov; - msg.msg_iovlen =3D 1; - if (fd !=3D -1) { msg.msg_control =3D cmsgu.control; msg.msg_controllen =3D sizeof(cmsgu.control); @@ -164,9 +162,6 @@ vg_sock_fd_write(int sock, const void *buf, ssize_t buf= len, int fd) cmsg->cmsg_type =3D SCM_RIGHTS; =20 *((int *)CMSG_DATA(cmsg)) =3D fd; - } else { - msg.msg_control =3D NULL; - msg.msg_controllen =3D 0; } =20 do { --=20 2.22.0.rc2.384.g1a9a72ea1d