From nobody Mon Feb 9 12:10:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1559738115; cv=none; d=zoho.com; s=zohoarc; b=mraJBqQFt1pntn/GeX0iCI+PIDjwkJIRSiDvPEBGkhgRuglyxdbQnDQuzvWTn/e5OV/QJjsC0Uu2T/dPBB9H21Z+tEcXK5CVl0CcsnQKNVqFNLquh5iW+dGTM2gGJy7xFN0OlK4HujRMRo1fFLsZjDKk508RWIIR3aWd6I/BvgI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1559738115; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=hP9hJcQ3Xl+VZzryIUxLthYrwDuCjtrT00Zidqb4nQs=; b=JCgTYbg0PU4vwhci5Jxwh4zr+KhvbYKs7BN/I5jNVqMAqqg2ku7oO+dQQDI/vJ0g09wuUu93BnIEqS95bdDnmPmaQ0uhQlna51Uh9Geo1I6ei5zKGfJUknQbGuTrcuzrZWjG/jVv6j7kVKXCZcQAl3WP1s9/Xowdc3Rhcu53i5E= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1559738115934673.1053790378994; Wed, 5 Jun 2019 05:35:15 -0700 (PDT) Received: from localhost ([127.0.0.1]:40668 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYV7l-0000Wt-8j for importer@patchew.org; Wed, 05 Jun 2019 08:34:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYV5q-00081i-5q for qemu-devel@nongnu.org; Wed, 05 Jun 2019 08:32:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYV5p-0006Kc-7H for qemu-devel@nongnu.org; Wed, 05 Jun 2019 08:32:38 -0400 Received: from relay.sw.ru ([185.231.240.75]:52310) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hYV5o-0006EE-Ue; Wed, 05 Jun 2019 08:32:37 -0400 Received: from [10.94.3.0] (helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.91) (envelope-from ) id 1hYV5i-0001rG-Lf; Wed, 05 Jun 2019 15:32:30 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org, qemu-block@nongnu.org Date: Wed, 5 Jun 2019 15:32:29 +0300 Message-Id: <20190605123229.92848-3-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20190605123229.92848-1-vsementsov@virtuozzo.com> References: <20190605123229.92848-1-vsementsov@virtuozzo.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 Subject: [Qemu-devel] [PATCH v2 2/2] blockjob: use blk_new_pinned in block_job_create X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, jsnow@redhat.com, mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" child_role job already has .stay_at_node=3Dtrue, so on bdrv_replace_node operation these child are unchanged. Make block job blk behave in same manner, to avoid inconsistent intermediate graph states and workarounds like in mirror. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/mirror.c | 6 +----- blockjob.c | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index f8bdb5b21b..23443116e4 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -713,12 +713,8 @@ static int mirror_exit_common(Job *job) &error_abort); bdrv_replace_node(mirror_top_bs, backing_bs(mirror_top_bs), &error_abo= rt); =20 - /* We just changed the BDS the job BB refers to (with either or both o= f the - * bdrv_replace_node() calls), so switch the BB back so the cleanup do= es - * the right thing. We don't need any permissions any more now. */ - blk_remove_bs(bjob->blk); + /* We don't need any permissions any more now. */ blk_set_perm(bjob->blk, 0, BLK_PERM_ALL, &error_abort); - blk_insert_bs(bjob->blk, mirror_top_bs, &error_abort); =20 bs_opaque->job =3D NULL; =20 diff --git a/blockjob.c b/blockjob.c index 931d675c0c..f5c8d31491 100644 --- a/blockjob.c +++ b/blockjob.c @@ -398,7 +398,7 @@ void *block_job_create(const char *job_id, const BlockJ= obDriver *driver, job_id =3D bdrv_get_device_name(bs); } =20 - blk =3D blk_new(bdrv_get_aio_context(bs), perm, shared_perm); + blk =3D blk_new_pinned(bdrv_get_aio_context(bs), perm, shared_perm); ret =3D blk_insert_bs(blk, bs, errp); if (ret < 0) { blk_unref(blk); --=20 2.18.0